[GitHub] azai91 commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators

2018-06-13 Thread GitBox
azai91 commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators URL: https://github.com/apache/incubator-mxnet/pull/11129#discussion_r195193780 ## File path: src/common/exec_utils.h ## @@ -98,10 +98,13 @@ inline bool

[GitHub] azai91 commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators

2018-06-12 Thread GitBox
azai91 commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators URL: https://github.com/apache/incubator-mxnet/pull/11129#discussion_r194874083 ## File path: src/operator/nn/mkldnn/mkldnn_base.cc ## @@ -304,18 +383,26 @@ void

[GitHub] azai91 commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators

2018-06-12 Thread GitBox
azai91 commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators URL: https://github.com/apache/incubator-mxnet/pull/11129#discussion_r194869335 ## File path: src/operator/nn/mkldnn/mkldnn_base.cc ## @@ -128,12 +201,18 @@ void

[GitHub] azai91 commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators

2018-06-12 Thread GitBox
azai91 commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators URL: https://github.com/apache/incubator-mxnet/pull/11129#discussion_r194870537 ## File path: tests/cpp/operator/mkldnn.cc ## @@ -571,9 +613,8 @@ void