azai91 commented on a change in pull request #11232: [MXNET-498] Test MKLDNN
backward operators
URL: https://github.com/apache/incubator-mxnet/pull/11232#discussion_r196636904
##########
File path: tests/cpp/operator/mkldnn.cc
##########
@@ -93,40 +93,26 @@ TEST(MKLDNN_UTIL_FUNC, MemFormat) {
// Init arrays with the default layout.
static void InitDefaultArray(NDArray *arr, bool is_rand = false) {
Review comment:
No reason to have two inits. We can just have one that covers negative and
positives.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
