cjolivier01 commented on a change in pull request #9761: Don't use FIRST_CUDA
on generators which don't support toolsets
URL: https://github.com/apache/incubator-mxnet/pull/9761#discussion_r167719518
##########
File path: CMakeLists.txt
##########
@@ -1,6 +1,8 @@
cmake_minimum_required(VERSION 3.0.2)
-
-if((${CMAKE_VERSION} VERSION_GREATER "3.9.0") OR (${CMAKE_VERSION}
VERSION_EQUAL "3.9.0"))
+message(STATUS "CMake version '${CMAKE_VERSION}' using generator
'${CMAKE_GENERATOR}'")
+if(((${CMAKE_GENERATOR} MATCHES "Visual Studio.*") OR (${CMAKE_GENERATOR}
MATCHES "Xcode.*"))
Review comment:
You left out "Unix Makefiles" and broke the Linux builds, it seems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
