[GitHub] cjolivier01 commented on a change in pull request #9931: Add axes support to Dropout for variational dropout in NLP

2018-03-05 Thread GitBox
cjolivier01 commented on a change in pull request #9931: Add axes support to Dropout for variational dropout in NLP URL: https://github.com/apache/incubator-mxnet/pull/9931#discussion_r172388095 ## File path: src/operator/nn/dropout-inl.h ## @@ -337,6 +336,7 @@ class Dropo

[GitHub] cjolivier01 commented on a change in pull request #9931: Add axes support to Dropout for variational dropout in NLP

2018-03-02 Thread GitBox
cjolivier01 commented on a change in pull request #9931: Add axes support to Dropout for variational dropout in NLP URL: https://github.com/apache/incubator-mxnet/pull/9931#discussion_r171937542 ## File path: src/operator/nn/dropout-inl.h ## @@ -228,11 +301,27 @@ class Dro

[GitHub] cjolivier01 commented on a change in pull request #9931: Add axes support to Dropout for variational dropout in NLP

2018-03-02 Thread GitBox
cjolivier01 commented on a change in pull request #9931: Add axes support to Dropout for variational dropout in NLP URL: https://github.com/apache/incubator-mxnet/pull/9931#discussion_r171937353 ## File path: src/operator/nn/dropout-inl.h ## @@ -178,30 +184,17 @@ class Dro

[GitHub] cjolivier01 commented on a change in pull request #9931: Add axes support to Dropout for variational dropout in NLP

2018-03-02 Thread GitBox
cjolivier01 commented on a change in pull request #9931: Add axes support to Dropout for variational dropout in NLP URL: https://github.com/apache/incubator-mxnet/pull/9931#discussion_r171930460 ## File path: src/operator/nn/dropout-inl.h ## @@ -178,30 +184,17 @@ class Dro

[GitHub] cjolivier01 commented on a change in pull request #9931: Add axes support to Dropout for variational dropout in NLP

2018-03-01 Thread GitBox
cjolivier01 commented on a change in pull request #9931: Add axes support to Dropout for variational dropout in NLP URL: https://github.com/apache/incubator-mxnet/pull/9931#discussion_r171649722 ## File path: src/operator/nn/dropout-inl.h ## @@ -67,9 +70,92 @@ struct Dropo