[GitHub] eric-haibin-lin commented on issue #7893: Add barriers in kvstore init

2017-10-09 Thread git
eric-haibin-lin commented on issue #7893: Add barriers in kvstore init URL: https://github.com/apache/incubator-mxnet/pull/7893#issuecomment-335201037 PR moved to #8187 now. This is an automated message from the Apache Git

[GitHub] eric-haibin-lin commented on issue #7893: Add barriers in kvstore init

2017-10-03 Thread git
eric-haibin-lin commented on issue #7893: Add barriers in kvstore init URL: https://github.com/apache/incubator-mxnet/pull/7893#issuecomment-334042834 @solin319 no worries. Happy mid-autumn festival! This is an automated

[GitHub] eric-haibin-lin commented on issue #7893: Add barriers in kvstore init

2017-10-03 Thread git
eric-haibin-lin commented on issue #7893: Add barriers in kvstore init URL: https://github.com/apache/incubator-mxnet/pull/7893#issuecomment-334014237 The test failure seems irrelevant. Do you mind sync up with master again to see if it passes? Regarding fp16, yes I think we need that

[GitHub] eric-haibin-lin commented on issue #7893: Add barriers in kvstore init

2017-09-29 Thread git
eric-haibin-lin commented on issue #7893: Add barriers in kvstore init URL: https://github.com/apache/incubator-mxnet/pull/7893#issuecomment-333282304 The fix looks good. Could you add a test in `tests/nightly/dist_sync_kvstore.py `, which tests `kv.pull ` right after `kv.init`? Also

[GitHub] eric-haibin-lin commented on issue #7893: Add barriers in kvstore init

2017-09-19 Thread git
eric-haibin-lin commented on issue #7893: Add barriers in kvstore init URL: https://github.com/apache/incubator-mxnet/pull/7893#issuecomment-330613450 Are you using multi-machine with GPUs? I'm not getting the setup here. Could you post a code snippet for others to reproduce?