javelinjs commented on issue #8297: [scala] Make accuracy idependant of output
size (fix #8226)
URL: https://github.com/apache/incubator-mxnet/pull/8297#issuecomment-346217712
Thanks.
This is an automated message from the
javelinjs commented on issue #8297: [scala] Make accuracy idependant of output
size (fix #8226)
URL: https://github.com/apache/incubator-mxnet/pull/8297#issuecomment-341723565
Sorry to see that. Please rebase again, I think the CI is OK now.
javelinjs commented on issue #8297: [scala] Make accuracy idependant of output
size (fix #8226)
URL: https://github.com/apache/incubator-mxnet/pull/8297#issuecomment-340267178
@piiswrong Could you help to do a force merge?
javelinjs commented on issue #8297: [scala] Make accuracy idependant of output
size (fix #8226)
URL: https://github.com/apache/incubator-mxnet/pull/8297#issuecomment-339866201
@benqua could you rebase the pr and re-trigger the CI build?
javelinjs commented on issue #8297: [scala] Make accuracy idependant of output
size (fix #8226)
URL: https://github.com/apache/incubator-mxnet/pull/8297#issuecomment-338253032
LGTM.
The CI seems to have some problems these days. Lets try again this weekend.
javelinjs commented on issue #8297: [scala] Make accuracy idependant of output
size (fix #8226)
URL: https://github.com/apache/incubator-mxnet/pull/8297#issuecomment-337832673
We can convert it back to Float when calling `EvalMetric.get`
javelinjs commented on issue #8297: [scala] Make accuracy idependant of output
size (fix #8226)
URL: https://github.com/apache/incubator-mxnet/pull/8297#issuecomment-337790078
We should keep it the same as other language bindings, especially python.
What if we make it Double in EvalMetric
javelinjs commented on issue #8297: [scala] Make accuracy idependant of output
size (fix #8226)
URL: https://github.com/apache/incubator-mxnet/pull/8297#issuecomment-337584492
Thanks @benqua , I think a better way is to change `sumMetric` to `Double`.
The fix here changes the definition
