joey2014 commented on a change in pull request #7381: fix [#7368] Caffe converter test fails, causing CI to halt for all PRs URL: https://github.com/apache/incubator-mxnet/pull/7381#discussion_r132065167
########## File path: tools/caffe_converter/convert_symbol.py ########## @@ -128,6 +128,16 @@ def _parse_proto(prototxt_fname): param_string = '' skip_layer = False name = re.sub('[-/]', '_', layer.name) + for k in range(len(layer.bottom)): Review comment: @piiswrong as comment on #7368 The layer input name in some cases is changed which causes the layer added to group by mistake, for example, in vgg16, the layer fc6 input name pool5 is changed to flatten_0. Moving the state recording code to the begin of the function can fix the issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services