juliusshufan opened a new pull request #9783: Fixing a symbol file for image-classification example URL: https://github.com/apache/incubator-mxnet/pull/9783 ## Description ## This PR is trying to fix a runtime error when running benchmark_score.py on CPU machine. The existing implementation of GoogleNet symbol under: example/image-classification/symbols/googlenet.py will introduce a run time error when input shape set as 3*224*224, per the error message below and topo of GoogleNet, I use global_pool option to avoid this issue. src/operator/nn/./pooling-inl.h:215: Check failed: param_.kernel[0] <= dshape[2] + 2 * param_.pad[0] kernel size (7) exceeds input (6 padded to 6) ## Checklist ## ### Essentials ### - [ ] Passed code style checking (`make lint`) - [ ] Changes are complete (i.e. I finished coding on this PR) - [ ] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [ ] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### example/image-classification/symbols/google.py, on CPU platform, the input to the last layer (7x7 avg pooling is 6x6, and therefore a runtime error will be triggered, I avoid this issue by using global_pool option. ## Comments ## - If this change is a backward incompatible change, why must this change be made. - Interesting edge cases to note here
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
