[GitHub] larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-11-09 Thread GitBox
larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r232294727 ## File path: tests/cpp/include/test_ndarray_utils.h ## @@ -47,16 +49,13 @@ inline

[GitHub] larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-08-13 Thread GitBox
larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r209621953 ## File path: src/operator/rnn_impl.h ## @@ -1890,7 +1896,11 @@ void

[GitHub] larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-08-13 Thread GitBox
larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r209621811 ## File path: src/operator/rnn_impl.h ## @@ -174,17 +174,21 @@ void

[GitHub] larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-08-13 Thread GitBox
larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r209620682 ## File path: cmake/ChooseBLAS.cmake ## @@ -0,0 +1,266 @@ +# Licensed to the Apache

[GitHub] larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-08-13 Thread GitBox
larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r209620456 ## File path: cmake/ChooseBLAS.cmake ## @@ -0,0 +1,266 @@ +# Licensed to the Apache

[GitHub] larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-08-13 Thread GitBox
larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r209620535 ## File path: cmake/ChooseBLAS.cmake ## @@ -0,0 +1,266 @@ +# Licensed to the Apache

[GitHub] larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-08-13 Thread GitBox
larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r209612375 ## File path: CMakeLists.txt ## @@ -268,13 +356,18 @@ else() endif()

[GitHub] larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-08-13 Thread GitBox
larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r209612020 ## File path: CMakeLists.txt ## @@ -38,7 +48,117 @@ mxnet_option(BUILD_CPP_EXAMPLES

[GitHub] larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-08-13 Thread GitBox
larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r209612020 ## File path: CMakeLists.txt ## @@ -38,7 +48,117 @@ mxnet_option(BUILD_CPP_EXAMPLES

[GitHub] larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-08-09 Thread GitBox
larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r208935625 ## File path: CMakeLists.txt ## @@ -38,7 +48,117 @@ mxnet_option(BUILD_CPP_EXAMPLES

[GitHub] larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-08-09 Thread GitBox
larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r208934607 ## File path: CMakeLists.txt ## @@ -1,11 +1,25 @@ cmake_minimum_required(VERSION

[GitHub] larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-08-09 Thread GitBox
larroy commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r208934971 ## File path: CMakeLists.txt ## @@ -38,7 +48,117 @@ mxnet_option(BUILD_CPP_EXAMPLES