[GitHub] larroy commented on a change in pull request #8915: NVLink communication pattern updated

2018-02-12 Thread GitBox
larroy commented on a change in pull request #8915: NVLink communication pattern updated URL: https://github.com/apache/incubator-mxnet/pull/8915#discussion_r167594127 ## File path: src/kvstore/comm.h ## @@ -644,38 +803,44 @@ class CommDevice : public Comm {

[GitHub] larroy commented on a change in pull request #8915: NVLink communication pattern updated

2018-01-11 Thread GitBox
larroy commented on a change in pull request #8915: NVLink communication pattern updated URL: https://github.com/apache/incubator-mxnet/pull/8915#discussion_r160935045 ## File path: src/kvstore/comm.h ## @@ -22,29 +22,28 @@ */ #ifndef MXNET_KVSTORE_COMM_H_ #define

[GitHub] larroy commented on a change in pull request #8915: NVLink communication pattern updated

2018-01-11 Thread GitBox
larroy commented on a change in pull request #8915: NVLink communication pattern updated URL: https://github.com/apache/incubator-mxnet/pull/8915#discussion_r160936864 ## File path: src/kvstore/comm.h ## @@ -526,101 +541,238 @@ class CommDevice : public Comm { }

[GitHub] larroy commented on a change in pull request #8915: NVLink communication pattern updated

2018-01-11 Thread GitBox
larroy commented on a change in pull request #8915: NVLink communication pattern updated URL: https://github.com/apache/incubator-mxnet/pull/8915#discussion_r160935839 ## File path: src/kvstore/comm.h ## @@ -526,101 +541,238 @@ class CommDevice : public Comm { }

[GitHub] larroy commented on a change in pull request #8915: NVLink communication pattern updated

2018-01-11 Thread GitBox
larroy commented on a change in pull request #8915: NVLink communication pattern updated URL: https://github.com/apache/incubator-mxnet/pull/8915#discussion_r160935226 ## File path: src/kvstore/comm.h ## @@ -53,33 +52,32 @@ class Comm { /** * \brief returns src[0]