[GitHub] larroy commented on issue #8872: Minor refactor: prevent string copying, list -> vector, shared_ptr by?

2017-12-14 Thread GitBox
larroy commented on issue #8872: Minor refactor: prevent string copying, list -> vector, shared_ptr by? URL: https://github.com/apache/incubator-mxnet/pull/8872#issuecomment-351787107 Changing the strings to references instead of unnecesary copies is not just for the sake of changing

[GitHub] larroy commented on issue #8872: Minor refactor: prevent string copying, list -> vector, shared_ptr by?

2017-12-14 Thread GitBox
larroy commented on issue #8872: Minor refactor: prevent string copying, list -> vector, shared_ptr by? URL: https://github.com/apache/incubator-mxnet/pull/8872#issuecomment-351762064 @cjolivier01 this should be good to go as well. Thank you so much for merging my PRs.

[GitHub] larroy commented on issue #8872: Minor refactor: prevent string copying, list -> vector, shared_ptr by?

2017-12-12 Thread GitBox
larroy commented on issue #8872: Minor refactor: prevent string copying, list -> vector, shared_ptr by? URL: https://github.com/apache/incubator-mxnet/pull/8872#issuecomment-351120257 @piiswrong please merge? This is an

[GitHub] larroy commented on issue #8872: Minor refactor: prevent string copying, list -> vector, shared_ptr by?

2017-12-10 Thread GitBox
larroy commented on issue #8872: Minor refactor: prevent string copying, list -> vector, shared_ptr by? URL: https://github.com/apache/incubator-mxnet/pull/8872#issuecomment-350594885 Done This is an automated message from