[GitHub] larroy commented on issue #9853: Flaky test_operator.test_binary_op

2018-06-13 Thread GitBox
larroy commented on issue #9853: Flaky test_operator.test_binary_op URL: https://github.com/apache/incubator-mxnet/issues/9853#issuecomment-397011088 1060292419 This is an automated message from the Apache Git Service. To

[GitHub] larroy commented on issue #9853: Flaky test_operator.test_binary_op

2018-06-13 Thread GitBox
larroy commented on issue #9853: Flaky test_operator.test_binary_op URL: https://github.com/apache/incubator-mxnet/issues/9853#issuecomment-397011088 seed 1060292419 This is an automated message from the Apache Git Service.

[GitHub] larroy commented on issue #9853: Flaky test_operator.test_binary_op

2018-06-13 Thread GitBox
larroy commented on issue #9853: Flaky test_operator.test_binary_op URL: https://github.com/apache/incubator-mxnet/issues/9853#issuecomment-396886126 I have likely found the root cause of this problem, just so we don't duplicate resources on this one.

[GitHub] larroy commented on issue #9853: Flaky test_operator.test_binary_op

2018-05-06 Thread GitBox
larroy commented on issue #9853: Flaky test_operator.test_binary_op URL: https://github.com/apache/incubator-mxnet/issues/9853#issuecomment-386885128 reproducible 100% with export MXNET_TEST_SEED=1688524483 nosetests-3.4 -s -v test_operator_gpu.py:test_binary_op diff

[GitHub] larroy commented on issue #9853: Flaky test_operator.test_binary_op

2018-05-06 Thread GitBox
larroy commented on issue #9853: Flaky test_operator.test_binary_op URL: https://github.com/apache/incubator-mxnet/issues/9853#issuecomment-386885128 reproducible 100% with export MXNET_TEST_SEED=1688524483 nosetests-3.4 -s -v test_operator_gpu.py:test_binary_op ``` diff

[GitHub] larroy commented on issue #9853: Flaky test_operator.test_binary_op

2018-05-06 Thread GitBox
larroy commented on issue #9853: Flaky test_operator.test_binary_op URL: https://github.com/apache/incubator-mxnet/issues/9853#issuecomment-386885067 I tried to increase the tolerance, but I found out one failure where the difference is much bigger than expected 0.28679015 . I think we

[GitHub] larroy commented on issue #9853: Flaky test_operator.test_binary_op

2018-05-06 Thread GitBox
larroy commented on issue #9853: Flaky test_operator.test_binary_op URL: https://github.com/apache/incubator-mxnet/issues/9853#issuecomment-386875707 I think the cause of this is that operator mod is using doubles to make the computation, while the test is forcing float32, also the modulo

[GitHub] larroy commented on issue #9853: Flaky test_operator.test_binary_op

2018-05-06 Thread GitBox
larroy commented on issue #9853: Flaky test_operator.test_binary_op URL: https://github.com/apache/incubator-mxnet/issues/9853#issuecomment-386875707 I think the cause of this is that operator mod is using doubles to make the computation, while the test is forcing float32, also the modulo

[GitHub] larroy commented on issue #9853: Flaky test_operator.test_binary_op

2018-05-06 Thread GitBox
larroy commented on issue #9853: Flaky test_operator.test_binary_op URL: https://github.com/apache/incubator-mxnet/issues/9853#issuecomment-386875707 I think the cause of this is that operator mod is using doubles to make the computation, while the test is forcing float32