[GitHub] lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-11-20 Thread GitBox
lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r234940359 ## File path: tests/cpp/include/test_ndarray_utils.h ## @@ -47,16 +49,13 @@ inline

[GitHub] lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-10-15 Thread GitBox
lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r225256514 ## File path: CMakeLists.txt ## @@ -39,7 +49,123 @@ mxnet_option(INSTALL_EXAMPLES

[GitHub] lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-10-15 Thread GitBox
lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r225256232 ## File path: CMakeLists.txt ## @@ -39,7 +49,123 @@ mxnet_option(INSTALL_EXAMPLES

[GitHub] lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-10-15 Thread GitBox
lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r225255729 ## File path: CMakeLists.txt ## @@ -39,7 +49,123 @@ mxnet_option(INSTALL_EXAMPLES

[GitHub] lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-08-15 Thread GitBox
lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r210255985 ## File path: src/operator/rnn_impl.h ## @@ -994,7 +998,6 @@ void

[GitHub] lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-08-13 Thread GitBox
lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r209664405 ## File path: src/operator/rnn_impl.h ## @@ -174,17 +174,21 @@ void

[GitHub] lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-08-13 Thread GitBox
lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r209664120 ## File path: cmake/ChooseBLAS.cmake ## @@ -0,0 +1,266 @@ +# Licensed to the Apache

[GitHub] lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-08-13 Thread GitBox
lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r209664058 ## File path: CMakeLists.txt ## @@ -268,13 +356,18 @@ else() endif() if(USE_CUDA

[GitHub] lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-08-13 Thread GitBox
lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r209654913 ## File path: CMakeLists.txt ## @@ -38,7 +48,117 @@ mxnet_option(BUILD_CPP_EXAMPLES

[GitHub] lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-08-13 Thread GitBox
lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r209539556 ## File path: cmake/ChooseBLAS.cmake ## @@ -0,0 +1,273 @@ +# Licensed to the Apache

[GitHub] lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-08-13 Thread GitBox
lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r209539259 ## File path: cmake/ChooseBLAS.cmake ## @@ -0,0 +1,273 @@ +# Licensed to the Apache

[GitHub] lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-08-09 Thread GitBox
lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r208959097 ## File path: CMakeLists.txt ## @@ -38,7 +48,117 @@ mxnet_option(BUILD_CPP_EXAMPLES

[GitHub] lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake

2018-08-09 Thread GitBox
lebeg commented on a change in pull request #11148: [MXNET-679] Refactor handling BLAS libraries with cmake URL: https://github.com/apache/incubator-mxnet/pull/11148#discussion_r208958508 ## File path: CMakeLists.txt ## @@ -1,11 +1,25 @@ cmake_minimum_required(VERSION