[GitHub] lebeg commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible

2018-10-02 Thread GitBox
lebeg commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible URL: https://github.com/apache/incubator-mxnet/pull/12356#discussion_r222135483 ## File path: src/imperative/cached_op.cc ## @@ -658,9 +658,9 @@ void

[GitHub] lebeg commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible

2018-10-02 Thread GitBox
lebeg commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible URL: https://github.com/apache/incubator-mxnet/pull/12356#discussion_r222135326 ## File path: src/executor/graph_executor.cc ## @@ -1551,16 +1550,16 @@ static

[GitHub] lebeg commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible

2018-10-02 Thread GitBox
lebeg commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible URL: https://github.com/apache/incubator-mxnet/pull/12356#discussion_r222134518 ## File path: src/c_api/c_api_symbolic.cc ## @@ -268,8 +268,8 @@ int

[GitHub] lebeg commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible

2018-10-02 Thread GitBox
lebeg commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible URL: https://github.com/apache/incubator-mxnet/pull/12356#discussion_r222134743 ## File path: src/common/exec_utils.h ## @@ -594,11 +594,11 @@ inline nnvm::Graph

[GitHub] lebeg commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible

2018-10-02 Thread GitBox
lebeg commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible URL: https://github.com/apache/incubator-mxnet/pull/12356#discussion_r222135194 ## File path: src/executor/attach_op_execs_pass.cc ## @@ -58,12 +58,10 @@ class

[GitHub] lebeg commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible

2018-10-02 Thread GitBox
lebeg commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible URL: https://github.com/apache/incubator-mxnet/pull/12356#discussion_r222135633 ## File path: src/imperative/cached_op.cc ## @@ -1283,8 +1283,8 @@ void