[GitHub] marcoabreu commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-12 Thread GitBox
marcoabreu commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r173892544 ## File path: python/mxnet/text/embedding.py ## @@ -0,0 +1,583 @@ +# Licensed to the Apache Software

[GitHub] marcoabreu commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-12 Thread GitBox
marcoabreu commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r173891663 ## File path: tests/python/unittest/test_text.py ## @@ -0,0 +1,675 @@ +# Licensed to the Apache Software

[GitHub] marcoabreu commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-12 Thread GitBox
marcoabreu commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r173891599 ## File path: tests/python/unittest/test_text.py ## @@ -0,0 +1,675 @@ +# Licensed to the Apache Software

[GitHub] marcoabreu commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-12 Thread GitBox
marcoabreu commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r173891556 ## File path: tests/python/unittest/test_text.py ## @@ -0,0 +1,675 @@ +# Licensed to the Apache Software