[GitHub] marcoabreu commented on issue #13952: Fix MXNet R package build

2019-01-27 Thread GitBox
marcoabreu commented on issue #13952: Fix MXNet R package build URL: https://github.com/apache/incubator-mxnet/pull/13952#issuecomment-458005284 Think about a small task that just creates a 5x5 matrix of ones. Just to make sure everything is properly linked at runtime. Or pick a random

[GitHub] marcoabreu commented on issue #13952: Fix MXNet R package build

2019-01-24 Thread GitBox
marcoabreu commented on issue #13952: Fix MXNet R package build URL: https://github.com/apache/incubator-mxnet/pull/13952#issuecomment-457442716 My feedback regarding the amount of testing is still unchanged. Am Fr., 25. Jan. 2019, 04:15 hat PatricZhao geschrieben: >

[GitHub] marcoabreu commented on issue #13952: Fix MXNet R package build

2019-01-23 Thread GitBox
marcoabreu commented on issue #13952: Fix MXNet R package build URL: https://github.com/apache/incubator-mxnet/pull/13952#issuecomment-456985929 Ideally, we could do some smoketests for different compilation options by running a simple test to ensure everything is working. Considering we