[GitHub] mseeger commented on issue #8361: Simplified unary/binary math operators

2017-10-31 Thread GitBox
mseeger commented on issue #8361: Simplified unary/binary math operators URL: https://github.com/apache/incubator-mxnet/pull/8361#issuecomment-340729397 @piiswrong OK, this went through. Please go ahead and merge it This is

[GitHub] mseeger commented on issue #8361: Simplified unary/binary math operators

2017-10-30 Thread GitBox
mseeger commented on issue #8361: Simplified unary/binary math operators URL: https://github.com/apache/incubator-mxnet/pull/8361#issuecomment-340587235 @cjolivier01 My new unit tests should indeed fail if functions for DType = double are not computed in double, but in float. Even though

[GitHub] mseeger commented on issue #8361: Simplified unary/binary math operators

2017-10-30 Thread GitBox
mseeger commented on issue #8361: Simplified unary/binary math operators URL: https://github.com/apache/incubator-mxnet/pull/8361#issuecomment-340552182 I am trying again. This is an automated message from the Apache Git

[GitHub] mseeger commented on issue #8361: Simplified unary/binary math operators

2017-10-30 Thread GitBox
mseeger commented on issue #8361: Simplified unary/binary math operators URL: https://github.com/apache/incubator-mxnet/pull/8361#issuecomment-340524830 Sorry, I am getting real confused with these different repos. I now have nnvm at commit 8d79cfd0b42fbe9f6ad75886d495065d5500b9dd.

[GitHub] mseeger commented on issue #8361: Simplified unary/binary math operators

2017-10-30 Thread GitBox
mseeger commented on issue #8361: Simplified unary/binary math operators URL: https://github.com/apache/incubator-mxnet/pull/8361#issuecomment-340498334 Yeah weird, a colleague told me his PR went through. But this failed already twice for me, with the same error. I try another force push.

[GitHub] mseeger commented on issue #8361: Simplified unary/binary math operators

2017-10-30 Thread GitBox
mseeger commented on issue #8361: Simplified unary/binary math operators URL: https://github.com/apache/incubator-mxnet/pull/8361#issuecomment-340428659 ??? Are unit tests of master broken (not mine!) ??? test_viz.test_print_summary ... ERROR

[GitHub] mseeger commented on issue #8361: Simplified unary/binary math operators

2017-10-29 Thread GitBox
mseeger commented on issue #8361: Simplified unary/binary math operators URL: https://github.com/apache/incubator-mxnet/pull/8361#issuecomment-340254925 Are we back to square 1 (Jenkins failed)? Can you skip CI? This is an

[GitHub] mseeger commented on issue #8361: Simplified unary/binary math operators

2017-10-28 Thread GitBox
mseeger commented on issue #8361: Simplified unary/binary math operators URL: https://github.com/apache/incubator-mxnet/pull/8361#issuecomment-340162717 Yes, please merge it. I rebase to master. This triggers Jenkins again, but please do not wait (there are no changes of mine).

[GitHub] mseeger commented on issue #8361: Simplified unary/binary math operators

2017-10-27 Thread GitBox
mseeger commented on issue #8361: Simplified unary/binary math operators URL: https://github.com/apache/incubator-mxnet/pull/8361#issuecomment-339969347 Finally! This is an automated message from the Apache Git Service. To

[GitHub] mseeger commented on issue #8361: Simplified unary/binary math operators

2017-10-27 Thread GitBox
mseeger commented on issue #8361: Simplified unary/binary math operators URL: https://github.com/apache/incubator-mxnet/pull/8361#issuecomment-339892674 BTW @cjolivier01 This PR just does not get built at all, since 6 days. Is it better I push it again regularly, or wait until it finally

[GitHub] mseeger commented on issue #8361: Simplified unary/binary math operators

2017-10-23 Thread GitBox
mseeger commented on issue #8361: Simplified unary/binary math operators URL: https://github.com/apache/incubator-mxnet/pull/8361#issuecomment-338802232 @piiswrong Jenkins just won't run for this one, I am giving up This is

[GitHub] mseeger commented on issue #8361: Simplified unary/binary math operators

2017-10-22 Thread GitBox
mseeger commented on issue #8361: Simplified unary/binary math operators URL: https://github.com/apache/incubator-mxnet/pull/8361#issuecomment-338503770 What is wrong with Jenkins? This is an automated message from the Apache

[GitHub] mseeger commented on issue #8361: Simplified unary/binary math operators

2017-10-21 Thread GitBox
mseeger commented on issue #8361: Simplified unary/binary math operators URL: https://github.com/apache/incubator-mxnet/pull/8361#issuecomment-338430529 Which functions in mshadow_op.h would be used in an LSTM? sigmoid, or relu? We could easily change them back to the old code and compare

[GitHub] mseeger commented on issue #8361: Simplified unary/binary math operators

2017-10-21 Thread GitBox
mseeger commented on issue #8361: Simplified unary/binary math operators URL: https://github.com/apache/incubator-mxnet/pull/8361#issuecomment-338430381 Due to the unary/binary math functions? In principle, at least for the majority of all expressions, we should go through the same

[GitHub] mseeger commented on issue #8361: Simplified unary/binary math operators

2017-10-20 Thread GitBox
mseeger commented on issue #8361: Simplified unary/binary math operators URL: https://github.com/apache/incubator-mxnet/pull/8361#issuecomment-338238388 @piiswrong : This is #8323, plus further changes of mine. This is an