[GitHub] nikrao commented on issue #7390: adding ranking metrics (precision/recall) at position K.

nikrao commented on issue #7390: adding ranking metrics (precision/recall) at position K. URL: https://github.com/apache/incubator-mxnet/pull/7390#issuecomment-328617706 *@eric-haibin-lin *fixed version and pushed yes needs to copy it. but that's just taking the topK entries and

[GitHub] nikrao commented on issue #7390: adding ranking metrics (precision/recall) at position K.

nikrao commented on issue #7390: adding ranking metrics (precision/recall) at position K. URL: https://github.com/apache/incubator-mxnet/pull/7390#issuecomment-328232367 done On Fri, Sep 8, 2017 at 3:44 PM, Haibin Lin wrote: > *@eric-haibin-lin*

[GitHub] nikrao commented on issue #7390: adding ranking metrics (precision/recall) at position K.

nikrao commented on issue #7390: adding ranking metrics (precision/recall) at position K. URL: https://github.com/apache/incubator-mxnet/pull/7390#issuecomment-328215271 @eric-haibin-lin done. added one for true positives predicted positives are done separately since that involves

[GitHub] nikrao commented on issue #7390: adding ranking metrics (precision/recall) at position K.

nikrao commented on issue #7390: adding ranking metrics (precision/recall) at position K. URL: https://github.com/apache/incubator-mxnet/pull/7390#issuecomment-327367484 actually on second thought, the functions literally just return the set of 1's (true positive) and the set of sorted

[GitHub] nikrao commented on issue #7390: adding ranking metrics (precision/recall) at position K.

nikrao commented on issue #7390: adding ranking metrics (precision/recall) at position K. URL: https://github.com/apache/incubator-mxnet/pull/7390#issuecomment-327367226 hmm, maybe. since they are basically one-liners, does it make sense to have a separate class just for those? Free

[GitHub] nikrao commented on issue #7390: adding ranking metrics (precision/recall) at position K.

nikrao commented on issue #7390: adding ranking metrics (precision/recall) at position K. URL: https://github.com/apache/incubator-mxnet/pull/7390#issuecomment-326394318 @eric-haibin-lin @szha I think it's better to have them separate. In many occasions you might use them together, but

[GitHub] nikrao commented on issue #7390: adding ranking metrics (precision/recall) at position K.

nikrao commented on issue #7390: adding ranking metrics (precision/recall) at position K. URL: https://github.com/apache/incubator-mxnet/pull/7390#issuecomment-326130469 yes. tested that. On Wed, Aug 30, 2017 at 2:53 PM, Haibin Lin wrote: >

[GitHub] nikrao commented on issue #7390: adding ranking metrics (precision/recall) at position K.

nikrao commented on issue #7390: adding ranking metrics (precision/recall) at position K. URL: https://github.com/apache/incubator-mxnet/pull/7390#issuecomment-325532433 Hello @eric-haibin-lin , I've updated the code in metric.py and added tests . Please review.

[GitHub] nikrao commented on issue #7390: adding ranking metrics (precision/recall) at position K.

nikrao commented on issue #7390: adding ranking metrics (precision/recall) at position K. URL: https://github.com/apache/incubator-mxnet/pull/7390#issuecomment-321143824 fixed. pylint checks pass now. This is an