pengzhao-intel commented on issue #13697: [MKLDNN] Enable signed int8 support
for convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-461996525
@szha @reminisce @KellenSunderland @TaoLv all comments are resolved now.
Could you help take a look again and
pengzhao-intel commented on issue #13697: [MKLDNN] Enable signed int8 support
for convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-460113921
Thanks for the suggestions and comments @szha @reminisce @sergeykolychev
We are on the Chinese holiday now and
pengzhao-intel commented on issue #13697: [MKLDNN] Enable signed int8 support
for convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-460013352
@xinyu-intel could you help verify the GPU accuracy with this PR?
pengzhao-intel commented on issue #13697: [MKLDNN] Enable signed int8 support
for convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-458346704
@KellenSunderland @szha @TaoLv could you help take a review again?
pengzhao-intel commented on issue #13697: [MKLDNN] Enable signed int8 support
for convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-451635860
It's not easy to pass the CI.
@KellenSunderland @reminisce @zheng-da could you help take a reveiw again?
We
pengzhao-intel commented on issue #13697: [MKLDNN] Enable signed int8 support
for convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-450779824
@KellenSunderland Happy New Year!
Really thanks for your review and providing amount of very good comments.
pengzhao-intel commented on issue #13697: [MKLDNN] Enable signed int8 support
for convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-449673327
> @marcoabreu Looks like CI has trouble to build this PR. Some builds failed
to compile this line
> ..
pengzhao-intel commented on issue #13697: [MKLDNN] Enable signed int8 support
for convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-449204694
FYI @yoel-shapiro
This is an automated message
pengzhao-intel commented on issue #13697: [MKLDNN] Enable signed int8 support
for convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-449204470
@KellenSunderland could you help take a look for the CI issue?
