piiswrong commented on a change in pull request #10437: [MXNET-171] Fix a bug that was causing training accuracy to be printed as nan sometimes URL: https://github.com/apache/incubator-mxnet/pull/10437#discussion_r179824119
########## File path: python/mxnet/module/base_module.py ########## @@ -523,8 +524,9 @@ def fit(self, train_data, eval_data=None, eval_metric='acc', monitor.toc_print() if batch_end_callback is not None: + arg_eval_metric = eval_metric if not end_of_batch else deepcopy(eval_metric) Review comment: This is too hacky and potentially very slow ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services