[GitHub] piiswrong commented on issue #10970: [MXNET-424] dtype option for multinomial

2018-05-30 Thread GitBox
piiswrong commented on issue #10970: [MXNET-424] dtype option for multinomial URL: https://github.com/apache/incubator-mxnet/pull/10970#issuecomment-393279769 otherwise LGTM This is an automated message from the Apache Git

[GitHub] piiswrong commented on issue #10970: [MXNET-424] dtype option for multinomial

2018-05-29 Thread GitBox
piiswrong commented on issue #10970: [MXNET-424] dtype option for multinomial URL: https://github.com/apache/incubator-mxnet/pull/10970#issuecomment-392892701 Ok. We can add this, but using float to represent int is only accurate within certain ranges. Please add checks for input