[GitHub] piiswrong commented on issue #8361: Simplified unary/binary math operators

2017-10-31 Thread GitBox
piiswrong commented on issue #8361: Simplified unary/binary math operators URL: https://github.com/apache/incubator-mxnet/pull/8361#issuecomment-340853298 I'm merging this. Afterwards, we'll need to decide whether log2 and log10 should use float constants instead

[GitHub] piiswrong commented on issue #8361: Simplified unary/binary math operators

2017-10-30 Thread GitBox
piiswrong commented on issue #8361: Simplified unary/binary math operators URL: https://github.com/apache/incubator-mxnet/pull/8361#issuecomment-340509092 You are updating nnvm with this PR. Try removing that. This is an

[GitHub] piiswrong commented on issue #8361: Simplified unary/binary math operators

2017-10-27 Thread GitBox
piiswrong commented on issue #8361: Simplified unary/binary math operators URL: https://github.com/apache/incubator-mxnet/pull/8361#issuecomment-340122609 can this be merged? This is an automated message from the Apache Git

[GitHub] piiswrong commented on issue #8361: Simplified unary/binary math operators

2017-10-24 Thread GitBox
piiswrong commented on issue #8361: Simplified unary/binary math operators URL: https://github.com/apache/incubator-mxnet/pull/8361#issuecomment-339223000 CI seems to be in better shape now. Please rebase your PR on master and push again.

[GitHub] piiswrong commented on issue #8361: Simplified unary/binary math operators

2017-10-21 Thread GitBox
piiswrong commented on issue #8361: Simplified unary/binary math operators URL: https://github.com/apache/incubator-mxnet/pull/8361#issuecomment-338425272 Chris observed 4x performance regression for LSTMs that might be related to the previous PR. @cjolivier01 have you found the