[GitHub] reminisce commented on issue #8246: Continued Work on Advanced Indexing

reminisce commented on issue #8246: Continued Work on Advanced Indexing URL: https://github.com/apache/incubator-mxnet/pull/8246#issuecomment-374781422 @cjolivier01 For assigning a value to a whole array, it still calls `_internal._full`. Are there any other places you expect to call

[GitHub] reminisce commented on issue #8246: Continued Work on Advanced Indexing

reminisce commented on issue #8246: Continued Work on Advanced Indexing URL: https://github.com/apache/incubator-mxnet/pull/8246#issuecomment-343993705 @meanmee This is a feature for 1.0 which is coming soon. Thanks for your interest.

[GitHub] reminisce commented on issue #8246: Continued Work on Advanced Indexing

reminisce commented on issue #8246: Continued Work on Advanced Indexing URL: https://github.com/apache/incubator-mxnet/pull/8246#issuecomment-343549343 @piiswrong @eric-haibin-lin @szha I added support for `__setitem__` and simplified basic and advanced indexing dispatching logic. Please

[GitHub] reminisce commented on issue #8246: Continued Work on Advanced Indexing

reminisce commented on issue #8246: Continued Work on Advanced Indexing URL: https://github.com/apache/incubator-mxnet/pull/8246#issuecomment-338322812 @JeanKossaifi Thanks for the comment. This only implements `__getitem__` of `NDArray`. We will add support for `__setitem__` later and add