[GitHub] szha commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
szha commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174646639 ## File path: python/mxnet/gluon/text/vocab.py ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software Foundation

[GitHub] szha commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
szha commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174643877 ## File path: docs/api/python/gluon/text.md ## @@ -0,0 +1,332 @@ +# Gluon Text API + +## Overview + +The

[GitHub] szha commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
szha commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174643617 ## File path: python/mxnet/gluon/text/vocab.py ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software Foundation

[GitHub] szha commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
szha commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174642866 ## File path: docs/api/python/gluon/text.md ## @@ -0,0 +1,332 @@ +# Gluon Text API + +## Overview + +The

[GitHub] szha commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
szha commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174643108 ## File path: python/mxnet/gluon/text/embedding.py ## @@ -0,0 +1,582 @@ +# Licensed to the Apache Software

[GitHub] szha commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
szha commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174642802 ## File path: docs/api/python/gluon/text.md ## @@ -0,0 +1,332 @@ +# Gluon Text API + +## Overview + +The

[GitHub] szha commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
szha commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174643223 ## File path: python/mxnet/gluon/text/vocab.py ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software Foundation

[GitHub] szha commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
szha commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174643415 ## File path: python/mxnet/gluon/text/vocab.py ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software Foundation

[GitHub] szha commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-13 Thread GitBox
szha commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174341439 ## File path: python/mxnet/gluon/text/embedding.py ## @@ -29,10 +29,10 @@ import warnings import zipfile