szha commented on a change in pull request #10120: Update profiler example code URL: https://github.com/apache/incubator-mxnet/pull/10120#discussion_r174672622
########## File path: docs/faq/perf.md ########## @@ -228,12 +228,12 @@ See [example/profiler](https://github.com/dmlc/mxnet/tree/master/example/profile for complete examples of how to use the profiler in code, but briefly, the Python code looks like: ``` - mx.profiler.profiler_set_config(mode='all', filename='profile_output.json') - mx.profiler.profiler_set_state('run') + mx.profiler.set_config(profile_all=True, filename='profile_output.json') + mx.profiler.set_state('run') Review comment: This API change shouldn't have happened. @cjolivier01 would you mind adding `profiler_set_state` back to fix the breaking change in #8972? cc'd @eric-haibin-lin who discovered the issue in #8972, @piiswrong who merged the breaking change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
