[GitHub] tdomhan commented on issue #10354: Expose the number of GPUs.

2018-05-15 Thread GitBox
tdomhan commented on issue #10354: Expose the number of GPUs. URL: https://github.com/apache/incubator-mxnet/pull/10354#issuecomment-389205718 So it seems to be the case that test_operator.py is indeed also run with GPUs. See (all GPU tests failed for this reason): ``` File

[GitHub] tdomhan commented on issue #10354: Expose the number of GPUs.

2018-05-14 Thread GitBox
tdomhan commented on issue #10354: Expose the number of GPUs. URL: https://github.com/apache/incubator-mxnet/pull/10354#issuecomment-388894115 rebased. let me know if there are any remaining concerns or if we can merge this.

[GitHub] tdomhan commented on issue #10354: Expose the number of GPUs.

2018-05-11 Thread GitBox
tdomhan commented on issue #10354: Expose the number of GPUs. URL: https://github.com/apache/incubator-mxnet/pull/10354#issuecomment-388423999 Finally got around updating this. I reverted the logic to what I had originally (as requested) and added a CPU test.

[GitHub] tdomhan commented on issue #10354: Expose the number of GPUs.

2018-04-23 Thread GitBox
tdomhan commented on issue #10354: Expose the number of GPUs. URL: https://github.com/apache/incubator-mxnet/pull/10354#issuecomment-383766297 so any test in the `unittest` directory is run with a version of MXNet that is not compiled with CUDA, is that correct?

[GitHub] tdomhan commented on issue #10354: Expose the number of GPUs.

2018-04-20 Thread GitBox
tdomhan commented on issue #10354: Expose the number of GPUs. URL: https://github.com/apache/incubator-mxnet/pull/10354#issuecomment-383013176 that is correct. I'm not sure why it happens or how it can be fixed. With the recent changes that is what will happen now that it will raise an

[GitHub] tdomhan commented on issue #10354: Expose the number of GPUs.

2018-04-18 Thread GitBox
tdomhan commented on issue #10354: Expose the number of GPUs. URL: https://github.com/apache/incubator-mxnet/pull/10354#issuecomment-382502963 so for CPU tests we run MXNet without CUDA built in, meaning that we compile once for CPU tests and then also for GPU tests with different flags?

[GitHub] tdomhan commented on issue #10354: Expose the number of GPUs.

2018-04-12 Thread GitBox
tdomhan commented on issue #10354: Expose the number of GPUs. URL: https://github.com/apache/incubator-mxnet/pull/10354#issuecomment-380841598 I changed the code now to raise an exception when MXNet is built without CUDA support as per suggestion by @piiswrong. For the CPU tests I'm

[GitHub] tdomhan commented on issue #10354: Expose the number of GPUs.

2018-04-10 Thread GitBox
tdomhan commented on issue #10354: Expose the number of GPUs. URL: https://github.com/apache/incubator-mxnet/pull/10354#issuecomment-380239943 I added a test to `test_operator_gpu.py`. For CPU only hosts I'm not sure what to test, as a CUDA internal error isn't exactly the expected

[GitHub] tdomhan commented on issue #10354: Expose the number of GPUs.

2018-04-10 Thread GitBox
tdomhan commented on issue #10354: Expose the number of GPUs. URL: https://github.com/apache/incubator-mxnet/pull/10354#issuecomment-380232929 Tried to address all comments. I did not add a test, as CUDA seems to run into an issue on a CPU only machine, namely raising the following: ```

[GitHub] tdomhan commented on issue #10354: Expose the number of GPUs.

2018-04-03 Thread GitBox
tdomhan commented on issue #10354: Expose the number of GPUs. URL: https://github.com/apache/incubator-mxnet/pull/10354#issuecomment-378237715 @KellenSunderland I also wasn't entirely sure whether this deserves a place in the core API, but also wasn't sure where else to put it. What would

[GitHub] tdomhan commented on issue #10354: Expose the number of GPUs.

2018-04-01 Thread GitBox
tdomhan commented on issue #10354: Expose the number of GPUs. URL: https://github.com/apache/incubator-mxnet/pull/10354#issuecomment-30427 yeah, I think that makes sense. I will add that test. This is an automated message