thirdwing commented on a change in pull request #8121: [R] Initializer fix and
adjustments to RNN API
URL: https://github.com/apache/incubator-mxnet/pull/8121#discussion_r150346131
##########
File path: R-package/R/initializer.R
##########
@@ -4,11 +4,11 @@
#' @param shape the shape of the array to be generated.
#'
mx.init.internal.default <- function(name, shape, ctx, allow.unknown=FALSE) {
- if (endsWith(name, "bias")) return (mx.nd.zeros(shape, ctx))
- if (endsWith(name, "gamma")) return (mx.nd.ones(shape, ctx))
- if (endsWith(name, "beta")) return (mx.nd.zeros(shape, ctx))
- if (endsWith(name, "moving_mean")) return (mx.nd.zeros(shape, ctx))
- if (endsWith(name, "moving_var")) return (mx.nd.ones(shape, ctx))
+ if (endsWith(name, "bias")) return (mx.nd.zeros(shape))
Review comment:
Why we need to remove the `ctx`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
