[GitHub] tqchen commented on issue #11320: Static alloc for hybridblock

2018-06-16 Thread GitBox
tqchen commented on issue #11320: Static alloc for hybridblock URL: https://github.com/apache/incubator-mxnet/pull/11320#issuecomment-397839131 @ThomasDelteil a few things thoughts, please feel free to comment - Bench-marking against mnist is a good reference but may not reflect

[GitHub] tqchen commented on issue #11320: Static alloc for hybridblock

2018-06-16 Thread GitBox
tqchen commented on issue #11320: Static alloc for hybridblock URL: https://github.com/apache/incubator-mxnet/pull/11320#issuecomment-397830554 I think the specific comment of @ThomasDelteil on the documents are actionable and should be addressed. The time difference in terms of resnet50,

[GitHub] tqchen commented on issue #11320: Static alloc for hybridblock

2018-06-16 Thread GitBox
tqchen commented on issue #11320: Static alloc for hybridblock URL: https://github.com/apache/incubator-mxnet/pull/11320#issuecomment-397828737 @ThomasDelteil can you copy your list of concerns over and make comments on the code? It is good to comment on the code and request changes, so

[GitHub] tqchen commented on issue #11320: Static alloc for hybridblock

2018-06-16 Thread GitBox
tqchen commented on issue #11320: Static alloc for hybridblock URL: https://github.com/apache/incubator-mxnet/pull/11320#issuecomment-397828737 @ThomasDelteil can you copy your list of concerns over and make comments on the code?