[GitHub] wentingj commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

2018-04-19 Thread GitBox
wentingj commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r182657549 ## File path: src/operator/quantization/quantize_graph_pass.cc ## @@ -198,7 +198,7 @@

[GitHub] wentingj commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

2018-04-19 Thread GitBox
wentingj commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r182641222 ## File path: src/c_api/c_api_symbolic.cc ## @@ -595,7 +597,12 @@ int

[GitHub] wentingj commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

2018-04-19 Thread GitBox
wentingj commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r182640860 ## File path: src/operator/quantization/quantized_conv.cc ## @@ -86,12 +89,10 @@ bool

[GitHub] wentingj commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

2018-04-18 Thread GitBox
wentingj commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r182639741 ## File path: src/operator/quantization/quantize_graph_pass.cc ## @@ -198,7 +198,7 @@

[GitHub] wentingj commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

2018-04-06 Thread GitBox
wentingj commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r179894359 ## File path: src/operator/nn/pooling.cc ## @@ -368,7 +368,11 @@ height, width)*. })