[GitHub] zheng-da commented on a change in pull request #10913: Fix _backward_norm op registration

2018-05-14 Thread GitBox
zheng-da commented on a change in pull request #10913: Fix _backward_norm op registration URL: https://github.com/apache/incubator-mxnet/pull/10913#discussion_r188119526 ## File path: src/operator/tensor/broadcast_reduce_op.h ## @@ -880,17 +878,30 @@ inline bool L2NormStor

[GitHub] zheng-da commented on a change in pull request #10913: Fix _backward_norm op registration

2018-05-14 Thread GitBox
zheng-da commented on a change in pull request #10913: Fix _backward_norm op registration URL: https://github.com/apache/incubator-mxnet/pull/10913#discussion_r188086270 ## File path: src/operator/tensor/broadcast_reduce_op.h ## @@ -880,17 +878,30 @@ inline bool L2NormStor

[GitHub] zheng-da commented on a change in pull request #10913: Fix _backward_norm op registration

2018-05-14 Thread GitBox
zheng-da commented on a change in pull request #10913: Fix _backward_norm op registration URL: https://github.com/apache/incubator-mxnet/pull/10913#discussion_r188084767 ## File path: src/operator/tensor/broadcast_reduce_op.h ## @@ -707,18 +707,16 @@ void ReduceCsr(const n

[GitHub] zheng-da commented on a change in pull request #10913: Fix _backward_norm op registration

2018-05-14 Thread GitBox
zheng-da commented on a change in pull request #10913: Fix _backward_norm op registration URL: https://github.com/apache/incubator-mxnet/pull/10913#discussion_r188084204 ## File path: src/operator/optimizer_op.cc ## @@ -305,7 +305,7 @@ inline bool SGDStorageType(const nnvm