[GitHub] zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test

2018-07-19 Thread GitBox
zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test URL: https://github.com/apache/incubator-mxnet/pull/11608#discussion_r203869745 ## File path: src/operator/nn/mkldnn/mkldnn_pooling.cc ## @@ -86,15 +86,15 @@ void

[GitHub] zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test

2018-07-16 Thread GitBox
zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test URL: https://github.com/apache/incubator-mxnet/pull/11608#discussion_r202820068 ## File path: src/operator/nn/mkldnn/mkldnn_pooling.cc ## @@ -255,7 +252,10 @@ void

[GitHub] zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test

2018-07-16 Thread GitBox
zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test URL: https://github.com/apache/incubator-mxnet/pull/11608#discussion_r202778963 ## File path: src/operator/nn/mkldnn/mkldnn_pooling.cc ## @@ -255,7 +252,10 @@ void

[GitHub] zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test

2018-07-16 Thread GitBox
zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test URL: https://github.com/apache/incubator-mxnet/pull/11608#discussion_r202781156 ## File path: tests/cpp/operator/mkldnn.cc ## @@ -1042,6 +1106,115 @@ void TestConcatOp(const OpAttrs ,

[GitHub] zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test

2018-07-16 Thread GitBox
zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test URL: https://github.com/apache/incubator-mxnet/pull/11608#discussion_r202779339 ## File path: src/operator/nn/pooling.cc ## @@ -223,12 +223,13 @@ void PoolingComputeExCPU(const

[GitHub] zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test

2018-07-16 Thread GitBox
zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test URL: https://github.com/apache/incubator-mxnet/pull/11608#discussion_r202778438 ## File path: src/operator/nn/mkldnn/mkldnn_pooling.cc ## @@ -255,7 +252,10 @@ void

[GitHub] zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test

2018-07-16 Thread GitBox
zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test URL: https://github.com/apache/incubator-mxnet/pull/11608#discussion_r202779751 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_pooling.cc ## @@ -39,7 +39,11 @@ static void

[GitHub] zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test

2018-07-11 Thread GitBox
zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test URL: https://github.com/apache/incubator-mxnet/pull/11608#discussion_r201889199 ## File path: tests/cpp/operator/mkldnn.cc ## @@ -1042,6 +1106,115 @@ void TestConcatOp(const OpAttrs ,

[GitHub] zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test

2018-07-11 Thread GitBox
zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test URL: https://github.com/apache/incubator-mxnet/pull/11608#discussion_r201888472 ## File path: tests/cpp/operator/mkldnn.cc ## @@ -515,33 +557,34 @@ void PrintVerifyMsg(const NDArrayAttrs ,

[GitHub] zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test

2018-07-11 Thread GitBox
zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test URL: https://github.com/apache/incubator-mxnet/pull/11608#discussion_r201888769 ## File path: tests/cpp/operator/mkldnn.cc ## @@ -1042,6 +1106,115 @@ void TestConcatOp(const OpAttrs ,

[GitHub] zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test

2018-07-11 Thread GitBox
zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test URL: https://github.com/apache/incubator-mxnet/pull/11608#discussion_r201887521 ## File path: tests/cpp/operator/mkldnn.cc ## @@ -485,6 +486,47 @@ OpAttrs GetConcatBackwardsOp(int

[GitHub] zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test

2018-07-11 Thread GitBox
zheng-da commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool test URL: https://github.com/apache/incubator-mxnet/pull/11608#discussion_r201887497 ## File path: tests/cpp/operator/mkldnn.cc ## @@ -485,6 +486,47 @@ OpAttrs GetConcatBackwardsOp(int