This is an automated email from the ASF dual-hosted git repository.

anirudh2290 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git


The following commit(s) were added to refs/heads/master by this push:
     new 58560f6  fixed flaky test issue for 
test_operator_gpu.test_depthwise_convolution (#12402)
58560f6 is described below

commit 58560f6d2e96da605c658742ebb0e26a7d0cbcd3
Author: Manu Seth <22492939+mset...@users.noreply.github.com>
AuthorDate: Fri Aug 31 18:13:09 2018 -0700

    fixed flaky test issue for test_operator_gpu.test_depthwise_convolution 
(#12402)
    
    * fixed flaky test issue for test_operator_gpu.test_depthwise_convolution
    
    * Changed implicit cast to explicit cast
---
 tests/python/unittest/test_operator.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/python/unittest/test_operator.py 
b/tests/python/unittest/test_operator.py
index 78285b6..f246689 100644
--- a/tests/python/unittest/test_operator.py
+++ b/tests/python/unittest/test_operator.py
@@ -1616,7 +1616,6 @@ def test_convolution_grouping():
             np.testing.assert_allclose(arr1.asnumpy(), arr2.asnumpy(), 
rtol=1e-3, atol=1e-3)
 
 
-@unittest.skip("Flaky test 
https://github.com/apache/incubator-mxnet/issues/12203";)
 @with_seed()
 def test_depthwise_convolution():
     for dim in [1,2]:
@@ -1650,7 +1649,7 @@ def test_depthwise_convolution():
                             exe2 = y2.simple_bind(mx.cpu(), x=shape, 
w=(num_filter, shape[1]//num_group)+kernel,
                                     b=(num_filter,))
                             for arr1, arr2 in zip(exe1.arg_arrays, 
exe2.arg_arrays):
-                                arr1[:] = np.random.normal(size=arr1.shape)
+                                arr1[:] = 
np.float32(np.random.normal(size=arr1.shape))
                                 arr2[:] = arr1
                             exe1.forward(is_train=True)
                             exe1.backward(exe1.outputs[0])
@@ -1658,7 +1657,7 @@ def test_depthwise_convolution():
                             exe2.backward(exe2.outputs[0])
 
                             for arr1, arr2 in zip(exe1.outputs + 
exe1.grad_arrays, exe2.outputs + exe2.grad_arrays):
-                                np.testing.assert_allclose(arr1.asnumpy(), 
arr2.asnumpy(), rtol=1e-3, atol=1e-3)
+                                np.testing.assert_allclose(arr1.asnumpy(), 
arr2.asnumpy(), rtol=1e-2, atol=1e-3)
 
 def gen_broadcast_data(idx):
     # Manually set test cases

Reply via email to