[GitHub] TaoLv commented on a change in pull request #10025: Language model with Google's billion words dataset

2018-03-07 Thread GitBox
TaoLv commented on a change in pull request #10025: Language model with Google's billion words dataset URL: https://github.com/apache/incubator-mxnet/pull/10025#discussion_r172867957 ## File path: src/operator/nn/fully_connected.cc ## @@ -87,8 +90,16 @@ void

[GitHub] eric-haibin-lin commented on a change in pull request #10025: Language model with Google's billion words dataset

2018-03-07 Thread GitBox
eric-haibin-lin commented on a change in pull request #10025: Language model with Google's billion words dataset URL: https://github.com/apache/incubator-mxnet/pull/10025#discussion_r172870624 ## File path: src/operator/nn/fully_connected.cc ## @@ -214,9 +238,7 @@ If

[GitHub] eric-haibin-lin commented on a change in pull request #10025: Language model with Google's billion words dataset

2018-03-07 Thread GitBox
eric-haibin-lin commented on a change in pull request #10025: Language model with Google's billion words dataset URL: https://github.com/apache/incubator-mxnet/pull/10025#discussion_r172870497 ## File path: src/operator/nn/fully_connected.cc ## @@ -87,8 +90,16 @@ void

[GitHub] TaoLv commented on a change in pull request #10025: Language model with Google's billion words dataset

2018-03-07 Thread GitBox
TaoLv commented on a change in pull request #10025: Language model with Google's billion words dataset URL: https://github.com/apache/incubator-mxnet/pull/10025#discussion_r172880571 ## File path: src/operator/nn/fully_connected.cc ## @@ -214,9 +238,7 @@ If ``no_bias`` is

[GitHub] eric-haibin-lin commented on issue #9921: [DISCUSSION] module.contrib.SparseModule API

2018-03-07 Thread GitBox
eric-haibin-lin commented on issue #9921: [DISCUSSION] module.contrib.SparseModule API URL: https://github.com/apache/incubator-mxnet/issues/9921#issuecomment-371033223 @anirudh2290 How much would a function call cost? I don't think static dictionary would be a common case.. Usually you

[GitHub] reminisce opened a new pull request #10022: Fix ndarray assignment issue with basic indexing

2018-03-07 Thread GitBox
reminisce opened a new pull request #10022: Fix ndarray assignment issue with basic indexing URL: https://github.com/apache/incubator-mxnet/pull/10022 The following code would throw exception before this fix because the value was not broadcast to the right shape . ```python data =

[GitHub] wkcn commented on issue #9939: add multi proposal operator (cpu version) and fix the bug in proposal op (gpu version)

2018-03-07 Thread GitBox
wkcn commented on issue #9939: add multi proposal operator (cpu version) and fix the bug in proposal op (gpu version) URL: https://github.com/apache/incubator-mxnet/pull/9939#issuecomment-371059934 @pengzhao-intel Thank you!

[GitHub] ashokei commented on a change in pull request #10021: [MXNET-33] Mkldnn pooling convention crash

2018-03-07 Thread GitBox
ashokei commented on a change in pull request #10021: [MXNET-33] Mkldnn pooling convention crash URL: https://github.com/apache/incubator-mxnet/pull/10021#discussion_r172909508 ## File path: src/operator/nn/mkldnn/mkldnn_pooling-inl.h ## @@ -92,6 +92,8 @@ inline bool

[GitHub] zheng-da commented on a change in pull request #10021: [WIP] [MXNET-33] Mkldnn pooling convention crash

2018-03-07 Thread GitBox
zheng-da commented on a change in pull request #10021: [WIP] [MXNET-33] Mkldnn pooling convention crash URL: https://github.com/apache/incubator-mxnet/pull/10021#discussion_r172915279 ## File path: src/operator/nn/mkldnn/mkldnn_pooling-inl.h ## @@ -92,6 +92,8 @@ inline

[GitHub] zheng-da commented on issue #9921: [DISCUSSION] module.contrib.SparseModule API

2018-03-07 Thread GitBox
zheng-da commented on issue #9921: [DISCUSSION] module.contrib.SparseModule API URL: https://github.com/apache/incubator-mxnet/issues/9921#issuecomment-371185700 @eric-haibin-lin I agree the first benefit is important. I wonder if we can have forward() to pull required weights from

[GitHub] marcoabreu commented on issue #9552: [REQUEST FOR REVIEW | DO NOT MERGE] Model Quantization with Calibration

2018-03-07 Thread GitBox
marcoabreu commented on issue #9552: [REQUEST FOR REVIEW | DO NOT MERGE] Model Quantization with Calibration URL: https://github.com/apache/incubator-mxnet/pull/9552#issuecomment-371187782 @reminisce I have updated the slave. Please resolve all conflicts and trigger CI to test if

[GitHub] tlby commented on a change in pull request #9988: [Perl] Sparse feature.

2018-03-07 Thread GitBox
tlby commented on a change in pull request #9988: [Perl] Sparse feature. URL: https://github.com/apache/incubator-mxnet/pull/9988#discussion_r172895513 ## File path: perl-package/AI-MXNet/lib/AI/MXNet/NDArray/Sparse.pm ## @@ -0,0 +1,1342 @@ +# Licensed to the Apache

<    1   2