[GitHub] tqchen commented on issue #11307: Memory Management

2018-06-15 Thread GitBox
tqchen commented on issue #11307: Memory Management URL: https://github.com/apache/incubator-mxnet/issues/11307#issuecomment-397770425 The fact is you can't. Unfortunately, we have to blame JVM in this case, which does not have ARC(accurate ref counting). The gc works well for the

[GitHub] tqchen commented on issue #11318: Revert "Static alloc for hybridblock"

2018-06-15 Thread GitBox
tqchen commented on issue #11318: Revert "Static alloc for hybridblock" URL: https://github.com/apache/incubator-mxnet/pull/11318#issuecomment-39148 it seems p This is an automated message from the Apache Git Service. To

[GitHub] marcoabreu closed pull request #11318: Revert "Static alloc for hybridblock"

2018-06-15 Thread GitBox
marcoabreu closed pull request #11318: Revert "Static alloc for hybridblock" URL: https://github.com/apache/incubator-mxnet/pull/11318 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] tqchen closed pull request #11318: Revert "Static alloc for hybridblock"

2018-06-15 Thread GitBox
tqchen closed pull request #11318: Revert "Static alloc for hybridblock" URL: https://github.com/apache/incubator-mxnet/pull/11318 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] tqchen commented on issue #11318: Revert "Static alloc for hybridblock"

2018-06-15 Thread GitBox
tqchen commented on issue #11318: Revert "Static alloc for hybridblock" URL: https://github.com/apache/incubator-mxnet/pull/11318#issuecomment-39148 it seems you have been using veto too often lately, please @marcoabreu we are not being unreasonable here, your concern about testcases

[GitHub] marcoabreu opened a new pull request #11318: Revert "Static alloc for hybridblock"

2018-06-15 Thread GitBox
marcoabreu opened a new pull request #11318: Revert "Static alloc for hybridblock" URL: https://github.com/apache/incubator-mxnet/pull/11318 Reverts apache/incubator-mxnet#11313 My veto has been ignored and thus I'm allowed to revert this PR. See

[GitHub] chenbiaolong commented on issue #8474: How to train variable input shape CNN?

2018-06-15 Thread GitBox
chenbiaolong commented on issue #8474: How to train variable input shape CNN? URL: https://github.com/apache/incubator-mxnet/issues/8474#issuecomment-397787011 @lanking520 @marcoabreu We found MXNet is convenient in c++ deployment,especially when we want to improve our throughputs. The

[GitHub] marcoabreu commented on a change in pull request #11294: [MXNET-543][WIP]Scala Spark test

2018-06-15 Thread GitBox
marcoabreu commented on a change in pull request #11294: [MXNET-543][WIP]Scala Spark test URL: https://github.com/apache/incubator-mxnet/pull/11294#discussion_r195887039 ## File path: scala-package/spark/src/test/scala/org/apache/mxnet/spark/MXNetGeneralSuite.scala ## @@

[incubator-mxnet] branch master updated: Static alloc for hybridblock (#11313)

2018-06-15 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 5431e12 Static alloc for hybridblock

[GitHub] chenbiaolong commented on issue #8474: How to train variable input shape CNN?

2018-06-15 Thread GitBox
chenbiaolong commented on issue #8474: How to train variable input shape CNN? URL: https://github.com/apache/incubator-mxnet/issues/8474#issuecomment-397514469 @lanking520 the main framework we use to train models is Tensorflow now.In last year we use tensorflow train variable shape

[GitHub] anirudh2290 closed pull request #11309: Backport fix discard_stderr

2018-06-15 Thread GitBox
anirudh2290 closed pull request #11309: Backport fix discard_stderr URL: https://github.com/apache/incubator-mxnet/pull/11309 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] marcoabreu commented on issue #11318: Revert "Static alloc for hybridblock"

2018-06-15 Thread GitBox
marcoabreu commented on issue #11318: Revert "Static alloc for hybridblock" URL: https://github.com/apache/incubator-mxnet/pull/11318#issuecomment-397778459 https://github.com/apache/incubator-mxnet/issues/11171 has not been addressed Pedros review in

[GitHub] TaoLv commented on issue #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging

2018-06-15 Thread GitBox
TaoLv commented on issue #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging URL: https://github.com/apache/incubator-mxnet/pull/11262#issuecomment-397780096 @azai91 Yes, please see the comments and description in

[incubator-mxnet] 01/04: Add NEWS and README

2018-06-15 Thread anirudh2290
This is an automated email from the ASF dual-hosted git repository. anirudh2290 pushed a commit to branch v1.2.0 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit f6a8cb76b7e182e86c4c9a382421baba56bd6cb4 Author: Anirudh Subramanian AuthorDate: Fri Jun 15 00:15:06 2018

[GitHub] nswamy commented on issue #11307: Memory Management

2018-06-15 Thread GitBox
nswamy commented on issue #11307: Memory Management URL: https://github.com/apache/incubator-mxnet/issues/11307#issuecomment-397773700 We could explore using WeakReferences like how ND4J does or use ObjectPoo. Scala Implicits helps to remove the ugliness of boiler plate code. I'll write

[GitHub] ThomasDelteil commented on issue #11318: Revert "Static alloc for hybridblock"

2018-06-15 Thread GitBox
ThomasDelteil commented on issue #11318: Revert "Static alloc for hybridblock" URL: https://github.com/apache/incubator-mxnet/pull/11318#issuecomment-397778642 I think I have raised specific concerns (twice) that have gone unanswered, just in case they got lost in the flow, let me write

[GitHub] tqchen commented on issue #11318: Revert "Static alloc for hybridblock"

2018-06-15 Thread GitBox
tqchen commented on issue #11318: Revert "Static alloc for hybridblock" URL: https://github.com/apache/incubator-mxnet/pull/11318#issuecomment-397778667 This PR is already fixing the problems and added test coverages. If we just block this, how can we move forward?

[GitHub] tqchen commented on issue #11318: Revert "Static alloc for hybridblock"

2018-06-15 Thread GitBox
tqchen commented on issue #11318: Revert "Static alloc for hybridblock" URL: https://github.com/apache/incubator-mxnet/pull/11318#issuecomment-397778646 This PR is already fixing the problems and added test coverages. If we just block this, how can we move forward?

[GitHub] tqchen commented on issue #11318: Revert "Static alloc for hybridblock"

2018-06-15 Thread GitBox
tqchen commented on issue #11318: Revert "Static alloc for hybridblock" URL: https://github.com/apache/incubator-mxnet/pull/11318#issuecomment-397778667 This PR is already fixing the problems and added test coverages. If we just block this, how can we move forward?

[GitHub] marcoabreu closed pull request #11319: Static alloc for hybridblock

2018-06-15 Thread GitBox
marcoabreu closed pull request #11319: Static alloc for hybridblock URL: https://github.com/apache/incubator-mxnet/pull/11319 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] tqchen closed pull request #11319: Static alloc for hybridblock

2018-06-15 Thread GitBox
tqchen closed pull request #11319: Static alloc for hybridblock URL: https://github.com/apache/incubator-mxnet/pull/11319 This is an automated message from the Apache Git Service. To respond to the message, please log on

[incubator-mxnet] branch piiswrong-patch-3 deleted (was 29faa9f)

2018-06-15 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch piiswrong-patch-3 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. was 29faa9f fix The revisions that were on this branch are still contained in other references;

[incubator-mxnet] branch piiswrong-patch-2 deleted (was fcdca35)

2018-06-15 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch piiswrong-patch-2 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. was fcdca35 Update cached_op.cc The revisions that were on this branch are still contained in

[incubator-mxnet] branch revert-11318-revert-11313-static deleted (was c8a9374)

2018-06-15 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch revert-11318-revert-11313-static in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. was c8a9374 Revert "Revert "Static alloc for hybridblock (#11313)" (#11318)" The

[GitHub] TaoLv commented on issue #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging

2018-06-15 Thread GitBox
TaoLv commented on issue #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging URL: https://github.com/apache/incubator-mxnet/pull/11262#issuecomment-397785653 I verifed the performance of commit 83ce4f0. It looks good to me, compared with commit 9514a1e.

[incubator-mxnet] 04/04: [MXNET-532] Clarify documentation of save_parameters(), load_parameters() (#11210)

2018-06-15 Thread anirudh2290
This is an automated email from the ASF dual-hosted git repository. anirudh2290 pushed a commit to branch v1.2.0 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit 332056a3413d8065adf7ede5d6a789954b3a8326 Author: Thomas Delteil AuthorDate: Thu Jun 14 14:10:11 2018

[incubator-mxnet] branch v1.2.0 updated (00ec21c -> 332056a)

2018-06-15 Thread anirudh2290
This is an automated email from the ASF dual-hosted git repository. anirudh2290 pushed a change to branch v1.2.0 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 00ec21c Scala inference memory leak fix #11204 (#11216) new f6a8cb7 Add NEWS and README

[incubator-mxnet] 02/04: add import_ for SymbolBlock (#11127)

2018-06-15 Thread anirudh2290
This is an automated email from the ASF dual-hosted git repository. anirudh2290 pushed a commit to branch v1.2.0 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit 719beeaab96be2b282761ddbf479670226a77f83 Author: Eric Junyuan Xie AuthorDate: Wed Jun 13 22:01:40 2018

[incubator-mxnet] branch v1.2.0 updated: Fix discard_stderr (#11309)

2018-06-15 Thread anirudh2290
This is an automated email from the ASF dual-hosted git repository. anirudh2290 pushed a commit to branch v1.2.0 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/v1.2.0 by this push: new daa957c Fix discard_stderr

[GitHub] tqchen commented on issue #11318: Revert "Static alloc for hybridblock"

2018-06-15 Thread GitBox
tqchen commented on issue #11318: Revert "Static alloc for hybridblock" URL: https://github.com/apache/incubator-mxnet/pull/11318#issuecomment-39458 If you have specific concerns, raise them. Your concern of lack of test coverage has been addressed, and you are abusing your right as

[GitHub] marcoabreu commented on issue #11318: Revert "Static alloc for hybridblock"

2018-06-15 Thread GitBox
marcoabreu commented on issue #11318: Revert "Static alloc for hybridblock" URL: https://github.com/apache/incubator-mxnet/pull/11318#issuecomment-397779766 Exactly, that's all I'm asking for. Give the community enough time to review the PR and address their concerns before merging it.

[GitHub] zheng-da commented on issue #11318: Revert "Static alloc for hybridblock"

2018-06-15 Thread GitBox
zheng-da commented on issue #11318: Revert "Static alloc for hybridblock" URL: https://github.com/apache/incubator-mxnet/pull/11318#issuecomment-397779690 @marcoabreu I think you should at least give people who understand the PR the opportunity to review it.

[GitHub] haojin2 commented on issue #11319: Static alloc for hybridblock

2018-06-15 Thread GitBox
haojin2 commented on issue #11319: Static alloc for hybridblock URL: https://github.com/apache/incubator-mxnet/pull/11319#issuecomment-397786323 @marcoabreu Can we bring this commit back? I've got some work (#11179) that depends of part of this PR.

[GitHub] TaoLv commented on issue #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging

2018-06-15 Thread GitBox
TaoLv commented on issue #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging URL: https://github.com/apache/incubator-mxnet/pull/11262#issuecomment-397785653 I verifed the performance of commit 83ce4f0 with inference of ResNet50, VGG16 and Inception-v3. It looks

[GitHub] haojin2 commented on issue #11319: Static alloc for hybridblock

2018-06-15 Thread GitBox
haojin2 commented on issue #11319: Static alloc for hybridblock URL: https://github.com/apache/incubator-mxnet/pull/11319#issuecomment-397786323 @marcoabreu Can we bring this commit back? I've got some ongoing work (#11179) that depends of part of this PR.

[incubator-mxnet] 03/04: Improve hybridblock doc (#11236)

2018-06-15 Thread anirudh2290
This is an automated email from the ASF dual-hosted git repository. anirudh2290 pushed a commit to branch v1.2.0 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit dfc17bb6ec2627e4ee7bb65c89cc16154c9fa2f9 Author: Eric Junyuan Xie AuthorDate: Thu Jun 14 14:02:48 2018

[GitHub] safrooze commented on issue #9881: Inconsistent weight decay logics in multiple optimizers

2018-06-15 Thread GitBox
safrooze commented on issue #9881: Inconsistent weight decay logics in multiple optimizers URL: https://github.com/apache/incubator-mxnet/issues/9881#issuecomment-397769492 Also there is this paper that discusses how weight_decay must be applied independently from optimizer:

[GitHub] tqchen commented on issue #11307: Memory Management

2018-06-15 Thread GitBox
tqchen commented on issue #11307: Memory Management URL: https://github.com/apache/incubator-mxnet/issues/11307#issuecomment-397774432 I think @yzhliu knows more details, the original design of scala was done in an implicit way by doing disposable at finalizer (like what you suggested).

[GitHub] zheng-da commented on issue #11313: Static alloc for hybridblock

2018-06-15 Thread GitBox
zheng-da commented on issue #11313: Static alloc for hybridblock URL: https://github.com/apache/incubator-mxnet/pull/11313#issuecomment-397779383 @marcoabreu I have been intensively using CachedOp with static memory allocation this week. I also read the code in the past week. Other than

[GitHub] yjcn commented on issue #11242: Same model with c_predict_api gets an incorrect result but it is right in python.

2018-06-15 Thread GitBox
yjcn commented on issue #11242: Same model with c_predict_api gets an incorrect result but it is right in python. URL: https://github.com/apache/incubator-mxnet/issues/11242#issuecomment-397784515 @kalyc this is python ssd 's log.

[GitHub] tqchen commented on issue #11307: Memory Management

2018-06-15 Thread GitBox
tqchen commented on issue #11307: Memory Management URL: https://github.com/apache/incubator-mxnet/issues/11307#issuecomment-397786640 Just putting some comment about our existing effort here so that we don't waste effort one things already tried. If there is really a solution out of

[GitHub] eric-haibin-lin commented on issue #11319: Static alloc for hybridblock

2018-06-15 Thread GitBox
eric-haibin-lin commented on issue #11319: Static alloc for hybridblock URL: https://github.com/apache/incubator-mxnet/pull/11319#issuecomment-397789580 @marcoabreu My work also depends on this PR. https://github.com/apache/incubator-mxnet/pull/11306

[incubator-mxnet] 01/01: Revert "Static alloc for hybridblock (#11313)"

2018-06-15 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a commit to branch revert-11313-static in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit 24f14f7fdbef427aab25738608267c57de645987 Author: Marco de Abreu AuthorDate: Fri Jun 15

[GitHub] marcoabreu opened a new pull request #11318: Revert "Static alloc for hybridblock"

2018-06-15 Thread GitBox
marcoabreu opened a new pull request #11318: Revert "Static alloc for hybridblock" URL: https://github.com/apache/incubator-mxnet/pull/11318 Reverts apache/incubator-mxnet#11313 My veto has been ignored and thus I'm allowed to revert this PR. See

[incubator-mxnet] branch revert-11313-static created (now 24f14f7)

2018-06-15 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a change to branch revert-11313-static in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. at 24f14f7 Revert "Static alloc for hybridblock (#11313)" This branch includes the

[GitHub] zheng-da commented on issue #11313: Static alloc for hybridblock

2018-06-15 Thread GitBox
zheng-da commented on issue #11313: Static alloc for hybridblock URL: https://github.com/apache/incubator-mxnet/pull/11313#issuecomment-397779855 I don't understand what the problem is. Because you veto, the PR should never be merged? We should open the PR and get proper reviews and

[GitHub] tqchen commented on issue #11313: Static alloc for hybridblock

2018-06-15 Thread GitBox
tqchen commented on issue #11313: Static alloc for hybridblock URL: https://github.com/apache/incubator-mxnet/pull/11313#issuecomment-397782646 just to be fair, I dismissed the your comment with specific comment that addresses your issue

[GitHub] tqchen commented on issue #11307: Memory Management

2018-06-15 Thread GitBox
tqchen commented on issue #11307: Memory Management URL: https://github.com/apache/incubator-mxnet/issues/11307#issuecomment-397774432 I think @yzhliu knows more details, the original design of scala was done in an implicit way by doing disposable at finalizer. The problem is

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2018-06-15 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 0070e1c Bump the publish

[GitHub] tqchen opened a new pull request #11319: Static alloc for hybridblock

2018-06-15 Thread GitBox
tqchen opened a new pull request #11319: Static alloc for hybridblock URL: https://github.com/apache/incubator-mxnet/pull/11319 Bring back the changes of hybrid-blocks. The test coverage issues has been addressed. This is an

[GitHub] marcoabreu commented on issue #11313: Static alloc for hybridblock

2018-06-15 Thread GitBox
marcoabreu commented on issue #11313: Static alloc for hybridblock URL: https://github.com/apache/incubator-mxnet/pull/11313#issuecomment-397780181 I was not the one who closed this PR, it was @tqchen. He was the one who dismissed my review and blocked other people from reviewing it. So

[GitHub] lanking520 commented on a change in pull request #11294: [MXNET-543][WIP]Scala Spark test

2018-06-15 Thread GitBox
lanking520 commented on a change in pull request #11294: [MXNET-543][WIP]Scala Spark test URL: https://github.com/apache/incubator-mxnet/pull/11294#discussion_r195884144 ## File path: scala-package/spark/src/test/scala/org/apache/mxnet/spark/MXNetGeneralSuite.scala ## @@

[GitHub] nswamy closed pull request #11256: [MXNET-539] Allow Scala users to specify data/label names for NDArrayIter

2018-06-15 Thread GitBox
nswamy closed pull request #11256: [MXNET-539] Allow Scala users to specify data/label names for NDArrayIter URL: https://github.com/apache/incubator-mxnet/pull/11256 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[incubator-mxnet] branch master updated: [MXNET-539] Allow Scala users to specify data/label names for NDArrayIter (#11256)

2018-06-15 Thread nswamy
This is an automated email from the ASF dual-hosted git repository. nswamy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 02e8a71 [MXNET-539] Allow Scala users

[GitHub] marcoabreu commented on issue #11318: Revert "Static alloc for hybridblock"

2018-06-15 Thread GitBox
marcoabreu commented on issue #11318: Revert "Static alloc for hybridblock" URL: https://github.com/apache/incubator-mxnet/pull/11318#issuecomment-39312 My as well as Thomas' concerns have not been addressed. This is an

[GitHub] tqchen opened a new pull request #11319: Static alloc for hybridblock

2018-06-15 Thread GitBox
tqchen opened a new pull request #11319: Static alloc for hybridblock URL: https://github.com/apache/incubator-mxnet/pull/11319 Bring back the changes of hybrid-blocks. The test coverage issues has been addressed. This is an

[GitHub] zheng-da commented on issue #11318: Revert "Static alloc for hybridblock"

2018-06-15 Thread GitBox
zheng-da commented on issue #11318: Revert "Static alloc for hybridblock" URL: https://github.com/apache/incubator-mxnet/pull/11318#issuecomment-397779615 @marcoabreu I have been intensively using CachedOp with static memory allocation this week. I also read the code this week. Other than

[GitHub] marcoabreu commented on issue #11313: Static alloc for hybridblock

2018-06-15 Thread GitBox
marcoabreu commented on issue #11313: Static alloc for hybridblock URL: https://github.com/apache/incubator-mxnet/pull/11313#issuecomment-397779609 Hi Da, thanks for your comments. I'm sure that CachedOp is behaving as expected. The problems are described at

[GitHub] TaoLv commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging

2018-06-15 Thread GitBox
TaoLv commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging URL: https://github.com/apache/incubator-mxnet/pull/11262#discussion_r195892008 ## File path: src/operator/nn/mkldnn/mkldnn_base-inl.h ## @@ -327,7

[GitHub] TaoLv commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging

2018-06-15 Thread GitBox
TaoLv commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging URL: https://github.com/apache/incubator-mxnet/pull/11262#discussion_r195891771 ## File path: src/operator/nn/mkldnn/mkldnn_base.cc ## @@ -77,26 +77,35

[GitHub] TaoLv commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging

2018-06-15 Thread GitBox
TaoLv commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging URL: https://github.com/apache/incubator-mxnet/pull/11262#discussion_r195891794 ## File path: src/operator/nn/mkldnn/mkldnn_base.cc ## @@ -77,26 +77,35

[GitHub] TaoLv commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging

2018-06-15 Thread GitBox
TaoLv commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging URL: https://github.com/apache/incubator-mxnet/pull/11262#discussion_r195891904 ## File path: src/operator/nn/mkldnn/mkldnn_base.cc ## @@ -77,26 +77,35

[GitHub] TaoLv commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging

2018-06-15 Thread GitBox
TaoLv commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging URL: https://github.com/apache/incubator-mxnet/pull/11262#discussion_r195891782 ## File path: src/operator/nn/mkldnn/mkldnn_base.cc ## @@ -77,26 +77,35

[GitHub] TaoLv commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging

2018-06-15 Thread GitBox
TaoLv commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging URL: https://github.com/apache/incubator-mxnet/pull/11262#discussion_r195891956 ## File path: src/operator/nn/mkldnn/mkldnn_base.cc ## @@ -77,26 +77,35

[GitHub] TaoLv commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging

2018-06-15 Thread GitBox
TaoLv commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging URL: https://github.com/apache/incubator-mxnet/pull/11262#discussion_r195891865 ## File path: src/operator/nn/mkldnn/mkldnn_base.cc ## @@ -77,26 +77,35

[GitHub] larroy commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

2018-06-15 Thread GitBox
larroy commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching URL: https://github.com/apache/incubator-mxnet/pull/11302#issuecomment-397782922 LGTM I can try what I asked myself as I'm not sure my question was well understood.

[GitHub] piiswrong opened a new pull request #11320: Static alloc for hybridblock

2018-06-15 Thread GitBox
piiswrong opened a new pull request #11320: Static alloc for hybridblock URL: https://github.com/apache/incubator-mxnet/pull/11320 This reverts commit 9b8eb567273d9521c639ea783e1117fe09cb3d64. ## Description ## (Brief description on what this PR is about) ## Checklist ##

[GitHub] lebeg commented on a change in pull request #11199: [MXNET-538] Add XUnit to python tests

2018-06-15 Thread GitBox
lebeg commented on a change in pull request #11199: [MXNET-538] Add XUnit to python tests URL: https://github.com/apache/incubator-mxnet/pull/11199#discussion_r195717612 ## File path: Jenkinsfile ## @@ -689,16 +764,21 @@ try { node('mxnetwindows-cpu') {

[GitHub] tvandergeer commented on issue #9507: Segmentation Fault

2018-06-15 Thread GitBox
tvandergeer commented on issue #9507: Segmentation Fault URL: https://github.com/apache/incubator-mxnet/issues/9507#issuecomment-397611793 I'm running into the same issue using MXNet v1.2.0 on a Raspberry Pi 3+. I've made a core dump and did a backtrace: ```

[GitHub] larroy closed pull request #11174: [MXNET-523] Fix build with OpenCV 2 (rpi)

2018-06-15 Thread GitBox
larroy closed pull request #11174: [MXNET-523] Fix build with OpenCV 2 (rpi) URL: https://github.com/apache/incubator-mxnet/pull/11174 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] larroy commented on issue #11174: [MXNET-523] Fix build with OpenCV 2 (rpi)

2018-06-15 Thread GitBox
larroy commented on issue #11174: [MXNET-523] Fix build with OpenCV 2 (rpi) URL: https://github.com/apache/incubator-mxnet/pull/11174#issuecomment-397618772 Changes merged as part of bigger PR. This is an automated message

[GitHub] matteosal commented on issue #11281: LRN operator doesn't comply with ONNX specification

2018-06-15 Thread GitBox
matteosal commented on issue #11281: LRN operator doesn't comply with ONNX specification URL: https://github.com/apache/incubator-mxnet/issues/11281#issuecomment-397582535 Why do you say that an even-sized window would lead to erroneous results? There is no fundamental reason why the

[GitHub] matteosal commented on issue #11281: LRN operator doesn't comply with ONNX specification

2018-06-15 Thread GitBox
matteosal commented on issue #11281: LRN operator doesn't comply with ONNX specification URL: https://github.com/apache/incubator-mxnet/issues/11281#issuecomment-397582535 @anirudhacharya why do you say that an even-sized window would lead to erroneous results? There is no fundamental

[GitHub] KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

2018-06-15 Thread GitBox
KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching URL: https://github.com/apache/incubator-mxnet/pull/11302#issuecomment-397598153 Would appreciate a review from @marcoabreu and @lebeg.

[GitHub] gigasquid commented on issue #11205: Clojure Contrib Package

2018-06-15 Thread GitBox
gigasquid commented on issue #11205: Clojure Contrib Package URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-397608840 @kovasb Thanks so much for taking the time to review and providing such insightful feedback and questions. As far as corner cases go, I feel

[GitHub] asmushetzel commented on issue #11271: nd.topk regression with nan values

2018-06-15 Thread GitBox
asmushetzel commented on issue #11271: nd.topk regression with nan values URL: https://github.com/apache/incubator-mxnet/issues/11271#issuecomment-397571518 Do we have ever documented in MXNet how NAN is supposed to work in comparisons? I'm not feeling confident to make code work against

[GitHub] lebeg commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

2018-06-15 Thread GitBox
lebeg commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching URL: https://github.com/apache/incubator-mxnet/pull/11302#issuecomment-397599472 Excellent work @KellenSunderland! Do you think there is any need to make the centos installations also robust to

[GitHub] Aman1994 opened a new issue #11303: MXNET Scala package build failed

2018-06-15 Thread GitBox
Aman1994 opened a new issue #11303: MXNET Scala package build failed URL: https://github.com/apache/incubator-mxnet/issues/11303 I tried these following steps while building: sudo apt-get update sudo apt-get install -y build-essential git sudo apt-get install -y libopencv-dev

[GitHub] jimm1973 opened a new issue #9507: Segmentation Fault

2018-06-15 Thread GitBox
jimm1973 opened a new issue #9507: Segmentation Fault URL: https://github.com/apache/incubator-mxnet/issues/9507 Hello everyone, Im following this post for my studies "https://mxnet.incubator.apache.org/tutorials/embedded/wine_detector.html; but whenever I run the python camera_test.py on

[GitHub] larroy commented on issue #9507: Segmentation Fault

2018-06-15 Thread GitBox
larroy commented on issue #9507: Segmentation Fault URL: https://github.com/apache/incubator-mxnet/issues/9507#issuecomment-397654033 Can you try with the naive engine? https://mxnet.incubator.apache.org/faq/env_var.html#engine-type @lebeg

[GitHub] larroy commented on issue #9507: Segmentation Fault

2018-06-15 Thread GitBox
larroy commented on issue #9507: Segmentation Fault URL: https://github.com/apache/incubator-mxnet/issues/9507#issuecomment-397654033 Can you try with the naive engine? https://mxnet.incubator.apache.org/faq/env_var.html#engine-type @lebeg

[GitHub] gigasquid commented on issue #11205: Clojure Contrib Package

2018-06-15 Thread GitBox
gigasquid commented on issue #11205: Clojure Contrib Package URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-397608840 @kovasb Thanks so much for taking the time to review and providing such insightful feedback and questions. As far as corner cases go, I feel

[GitHub] gigasquid commented on issue #11303: MXNET Scala package build failed

2018-06-15 Thread GitBox
gigasquid commented on issue #11303: MXNET Scala package build failed URL: https://github.com/apache/incubator-mxnet/issues/11303#issuecomment-397657151 You might want to try with the Scala jars on maven and see if you have the same problem when trying to run some examples

[GitHub] yzhliu commented on a change in pull request #11256: [MXNET-539] Allow Scala users to specify data/label names for NDArrayIter

2018-06-15 Thread GitBox
yzhliu commented on a change in pull request #11256: [MXNET-539] Allow Scala users to specify data/label names for NDArrayIter URL: https://github.com/apache/incubator-mxnet/pull/11256#discussion_r195782399 ## File path:

[GitHub] szha closed pull request #11300: [BUILD] Remove useless additional link opt

2018-06-15 Thread GitBox
szha closed pull request #11300: [BUILD] Remove useless additional link opt URL: https://github.com/apache/incubator-mxnet/pull/11300 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-mxnet] branch master updated (a7952f0 -> feef067)

2018-06-15 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from a7952f0 [MXNET-538] Add XUnit to python tests (#11199) add feef067 [BUILD] Remove useless

[GitHub] gigasquid commented on issue #11205: Clojure Contrib Package

2018-06-15 Thread GitBox
gigasquid commented on issue #11205: Clojure Contrib Package URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-397608840 @kovasb Thanks so much for taking the time to review and providing such insightful feedback and questions. As far as corner cases go, I feel

[GitHub] Roshrini commented on a change in pull request #11213: [MXNET-533] MXNet-ONNX export

2018-06-15 Thread GitBox
Roshrini commented on a change in pull request #11213: [MXNET-533] MXNet-ONNX export URL: https://github.com/apache/incubator-mxnet/pull/11213#discussion_r195808319 ## File path: python/mxnet/contrib/onnx/_export/export_model.py ## @@ -0,0 +1,89 @@ +# Licensed to the

[GitHub] Roshrini opened a new issue #11305: MXNet_ONNX export feature request

2018-06-15 Thread GitBox
Roshrini opened a new issue #11305: MXNet_ONNX export feature request URL: https://github.com/apache/incubator-mxnet/issues/11305 ## Description Right now MXNet_ONNX export feature supports converting symbol and params file to ONNX protobuf. Extend this functionality to export mxnet

[GitHub] marcoabreu closed pull request #11055: [MXNET-57] Added support android64

2018-06-15 Thread GitBox
marcoabreu closed pull request #11055: [MXNET-57] Added support android64 URL: https://github.com/apache/incubator-mxnet/pull/11055 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] piiswrong commented on a change in pull request #11293: Update cached_op.cc

2018-06-15 Thread GitBox
piiswrong commented on a change in pull request #11293: Update cached_op.cc URL: https://github.com/apache/incubator-mxnet/pull/11293#discussion_r195820139 ## File path: src/imperative/cached_op.cc ## @@ -674,7 +674,7 @@ OpStatePtr CachedOp::StaticForward(

[incubator-mxnet] branch piiswrong-patch-2 updated (12c73ae -> fcdca35)

2018-06-15 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a change to branch piiswrong-patch-2 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 12c73ae Update cached_op.cc add fcdca35 Update cached_op.cc No new revisions were added by

[GitHub] KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

2018-06-15 Thread GitBox
KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching URL: https://github.com/apache/incubator-mxnet/pull/11302#issuecomment-397676703 @lebeg I think calling the compiler with $CC should be sufficient for CentOS, at least for the time

[GitHub] azai91 commented on issue #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging

2018-06-15 Thread GitBox
azai91 commented on issue #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging URL: https://github.com/apache/incubator-mxnet/pull/11262#issuecomment-397681283 I have a separate PR where I write unit test for the CreateMKLDNNMem/CommitOutput coming.

[GitHub] Roshrini commented on a change in pull request #11213: [MXNET-533] MXNet-ONNX export

2018-06-15 Thread GitBox
Roshrini commented on a change in pull request #11213: [MXNET-533] MXNet-ONNX export URL: https://github.com/apache/incubator-mxnet/pull/11213#discussion_r195812549 ## File path: python/mxnet/contrib/onnx/_export/op_translations.py ## @@ -0,0 +1,1667 @@ +# Licensed to the

[GitHub] zheng-da commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging

2018-06-15 Thread GitBox
zheng-da commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging URL: https://github.com/apache/incubator-mxnet/pull/11262#discussion_r195814788 ## File path: tests/cpp/operator/mkldnn.cc ## @@ -722,6 +731,27 @@

[GitHub] zheng-da commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging

2018-06-15 Thread GitBox
zheng-da commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging URL: https://github.com/apache/incubator-mxnet/pull/11262#discussion_r195814182 ## File path: src/operator/nn/mkldnn/mkldnn_base.cc ## @@ -77,26

[GitHub] zheng-da commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging

2018-06-15 Thread GitBox
zheng-da commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging URL: https://github.com/apache/incubator-mxnet/pull/11262#discussion_r195814052 ## File path: src/operator/nn/mkldnn/mkldnn_base.cc ## @@ -77,26

[GitHub] zheng-da commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging

2018-06-15 Thread GitBox
zheng-da commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging URL: https://github.com/apache/incubator-mxnet/pull/11262#discussion_r195813001 ## File path: src/operator/nn/mkldnn/mkldnn_base-inl.h ## @@ -327,7

[GitHub] zheng-da commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging

2018-06-15 Thread GitBox
zheng-da commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging URL: https://github.com/apache/incubator-mxnet/pull/11262#discussion_r195814468 ## File path: src/operator/nn/mkldnn/mkldnn_sum.cc ## @@ -92,7 +92,7

  1   2   3   >