[GitHub] [incubator-mxnet] xidulu commented on a change in pull request #15858: [Numpy] Numpy behavior random.uniform()

2019-08-12 Thread GitBox
xidulu commented on a change in pull request #15858: [Numpy] Numpy behavior random.uniform() URL: https://github.com/apache/incubator-mxnet/pull/15858#discussion_r313204568 ## File path: src/operator/numpy/random/dist_common.h ## @@ -0,0 +1,180 @@ +/* + * Licensed to the

[GitHub] [incubator-mxnet] xidulu commented on a change in pull request #15858: [Numpy] Numpy behavior random.uniform()

2019-08-12 Thread GitBox
xidulu commented on a change in pull request #15858: [Numpy] Numpy behavior random.uniform() URL: https://github.com/apache/incubator-mxnet/pull/15858#discussion_r313204665 ## File path: src/operator/numpy/random/dist_common.h ## @@ -0,0 +1,180 @@ +/* + * Licensed to the

[GitHub] [incubator-mxnet] xidulu commented on a change in pull request #15858: [Numpy] Numpy behavior random.uniform()

2019-08-12 Thread GitBox
xidulu commented on a change in pull request #15858: [Numpy] Numpy behavior random.uniform() URL: https://github.com/apache/incubator-mxnet/pull/15858#discussion_r313204398 ## File path: src/operator/numpy/random/np_uniform_op.h ## @@ -0,0 +1,218 @@ +/* + * Licensed to

[GitHub] [incubator-mxnet] ElaineBao commented on a change in pull request #15870: update support MKLDNN BN conditions

2019-08-12 Thread GitBox
ElaineBao commented on a change in pull request #15870: update support MKLDNN BN conditions URL: https://github.com/apache/incubator-mxnet/pull/15870#discussion_r313210278 ## File path: src/operator/nn/batch_norm.cc ## @@ -420,8 +419,7 @@ void

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15593: Large Index Support for Slice

2019-08-12 Thread GitBox
apeforest commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r313212202 ## File path: src/c_api/c_api.cc ## @@ -562,6 +580,23 @@ int MXNDArrayGetShapeEx(NDArrayHandle handle,

[GitHub] [incubator-mxnet] KellenSunderland commented on issue #15613: [Discussion] 1.5.1 Patch Release

2019-08-12 Thread GitBox
KellenSunderland commented on issue #15613: [Discussion] 1.5.1 Patch Release URL: https://github.com/apache/incubator-mxnet/issues/15613#issuecomment-520688668 For some reason not able to edit the cwiki? Proposals for fixes are:

[GitHub] [incubator-mxnet] xidulu commented on a change in pull request #15858: [Numpy] Numpy behavior random.uniform()

2019-08-12 Thread GitBox
xidulu commented on a change in pull request #15858: [Numpy] Numpy behavior random.uniform() URL: https://github.com/apache/incubator-mxnet/pull/15858#discussion_r313222153 ## File path: src/operator/numpy/random/np_uniform_op.h ## @@ -0,0 +1,211 @@ +/* + * Licensed to

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15868: fixing problem with existing Singleton Caching

2019-08-12 Thread GitBox
larroy commented on a change in pull request #15868: fixing problem with existing Singleton Caching URL: https://github.com/apache/incubator-mxnet/pull/15868#discussion_r313176642 ## File path: python/mxnet/runtime.py ## @@ -77,11 +77,9 @@ class

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #15868: fixing problem with existing Singleton Caching

2019-08-12 Thread GitBox
access2rohit commented on a change in pull request #15868: fixing problem with existing Singleton Caching URL: https://github.com/apache/incubator-mxnet/pull/15868#discussion_r313178184 ## File path: python/mxnet/runtime.py ## @@ -77,11 +77,9 @@ class

[GitHub] [incubator-mxnet] xidulu commented on a change in pull request #15858: [Numpy] Numpy behavior random.uniform()

2019-08-12 Thread GitBox
xidulu commented on a change in pull request #15858: [Numpy] Numpy behavior random.uniform() URL: https://github.com/apache/incubator-mxnet/pull/15858#discussion_r313204348 ## File path: src/operator/numpy/random/np_uniform_op.h ## @@ -0,0 +1,218 @@ +/* + * Licensed to

[GitHub] [incubator-mxnet] xidulu commented on a change in pull request #15858: [Numpy] Numpy behavior random.uniform()

2019-08-12 Thread GitBox
xidulu commented on a change in pull request #15858: [Numpy] Numpy behavior random.uniform() URL: https://github.com/apache/incubator-mxnet/pull/15858#discussion_r313204152 ## File path: src/operator/numpy/random/np_uniform_op.h ## @@ -0,0 +1,218 @@ +/* + * Licensed to

[GitHub] [incubator-mxnet] ElaineBao opened a new pull request #15870: update support MKLDNN BN conditions

2019-08-12 Thread GitBox
ElaineBao opened a new pull request #15870: update support MKLDNN BN conditions URL: https://github.com/apache/incubator-mxnet/pull/15870 ## Description ## update BN conditions of when to run into MKLDNN. ## Changes ## - [ ] support BN with arbitrary channel size - [ ]

[GitHub] [incubator-mxnet] pengzhao-intel commented on a change in pull request #15870: update support MKLDNN BN conditions

2019-08-12 Thread GitBox
pengzhao-intel commented on a change in pull request #15870: update support MKLDNN BN conditions URL: https://github.com/apache/incubator-mxnet/pull/15870#discussion_r313207945 ## File path: src/operator/nn/batch_norm.cc ## @@ -420,8 +419,7 @@ void

[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #15870: update support MKLDNN BN conditions

2019-08-12 Thread GitBox
pengzhao-intel commented on issue #15870: update support MKLDNN BN conditions URL: https://github.com/apache/incubator-mxnet/pull/15870#issuecomment-520674942 Thanks for your contribution. Could you add a test case to cover the specific size of 8?

[incubator-mxnet] branch master updated: numpy linspace (#15852)

2019-08-12 Thread haoj
This is an automated email from the ASF dual-hosted git repository. haoj pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 795990b numpy linspace (#15852) 795990b

[GitHub] [incubator-mxnet] haojin2 merged pull request #15852: numpy linspace

2019-08-12 Thread GitBox
haojin2 merged pull request #15852: numpy linspace URL: https://github.com/apache/incubator-mxnet/pull/15852 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[incubator-mxnet] branch master updated (c3f5eea -> bd32de4)

2019-08-12 Thread apeforest
This is an automated email from the ASF dual-hosted git repository. apeforest pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from c3f5eea Numpy Tensordot and Dot Operator (#15820) add bd32de4 fixing problem with existing

[incubator-mxnet] branch master updated: Large Index Support for Slice (#15593)

2019-08-12 Thread apeforest
This is an automated email from the ASF dual-hosted git repository. apeforest pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 05f3ae1 Large Index Support for

[GitHub] [incubator-mxnet] apeforest merged pull request #15593: Large Index Support for Slice

2019-08-12 Thread GitBox
apeforest merged pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-mxnet] KellenSunderland commented on issue #15860: [v1.5.x] fix license issues (#15806)

2019-08-12 Thread GitBox
KellenSunderland commented on issue #15860: [v1.5.x] fix license issues (#15806) URL: https://github.com/apache/incubator-mxnet/pull/15860#issuecomment-520691501 I haven't run RAT, but fixes look good to me Tao. This is an

[GitHub] [incubator-mxnet] anirudh2290 commented on issue #15866: AMP tutorial does not work on 1.5.0

2019-08-12 Thread GitBox
anirudh2290 commented on issue #15866: AMP tutorial does not work on 1.5.0 URL: https://github.com/apache/incubator-mxnet/issues/15866#issuecomment-520603588 @bichu thanks for bringing this up. You are right, convert_hybrid_block isn't available in 1.5 but its in master. you can obtain it

[GitHub] [incubator-mxnet] blchu opened a new issue #15866: AMP tutorial does not work on 1.5.0

2019-08-12 Thread GitBox
blchu opened a new issue #15866: AMP tutorial does not work on 1.5.0 URL: https://github.com/apache/incubator-mxnet/issues/15866 The AMP tutorial offered in the iPython notebook at https://mxnet.incubator.apache.org/versions/master/tutorials/amp/amp_tutorial.html results on errors in

[GitHub] [incubator-mxnet] mxnet-label-bot commented on issue #15866: AMP tutorial does not work on 1.5.0

2019-08-12 Thread GitBox
mxnet-label-bot commented on issue #15866: AMP tutorial does not work on 1.5.0 URL: https://github.com/apache/incubator-mxnet/issues/15866#issuecomment-520572007 Hey, this is the MXNet Label Bot. Thank you for submitting the issue! I will try and suggest some labels so that the

[GitHub] [incubator-mxnet] reminisce commented on issue #15861: Numpy det and slogdet operator

2019-08-12 Thread GitBox
reminisce commented on issue #15861: Numpy det and slogdet operator URL: https://github.com/apache/incubator-mxnet/pull/15861#issuecomment-520576024 I think you will need to modify the `DetShape` function so that `np.linalg.det` returns a scalar tensor when `ndim=2`. You can just add a

[incubator-mxnet] 01/01: Update basic_layers.py

2019-08-12 Thread haibin
This is an automated email from the ASF dual-hosted git repository. haibin pushed a commit to branch doc-patch in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit ad0db62c5e6488a4a101f4ef64329269ee9dfb2f Author: Haibin Lin AuthorDate: Mon Aug 12 16:36:28 2019 -0700

[incubator-mxnet] branch doc-patch created (now ad0db62)

2019-08-12 Thread haibin
This is an automated email from the ASF dual-hosted git repository. haibin pushed a change to branch doc-patch in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. at ad0db62 Update basic_layers.py This branch includes the following new commits: new ad0db62

[GitHub] [incubator-mxnet] eric-haibin-lin opened a new pull request #15869: [DOC] Fix doc for nn.Embedding, nn.Dense and nd.Embedding

2019-08-12 Thread GitBox
eric-haibin-lin opened a new pull request #15869: [DOC] Fix doc for nn.Embedding, nn.Dense and nd.Embedding URL: https://github.com/apache/incubator-mxnet/pull/15869 ## Description ## As title ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-08-12 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new b1b5a8a Bump the publish

[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #15861: Numpy det and slogdet operator

2019-08-12 Thread GitBox
reminisce commented on a change in pull request #15861: Numpy det and slogdet operator URL: https://github.com/apache/incubator-mxnet/pull/15861#discussion_r313093498 ## File path: src/operator/tensor/la_op.cu ## @@ -100,15 +100,19 @@

[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #15861: Numpy det and slogdet operator

2019-08-12 Thread GitBox
reminisce commented on a change in pull request #15861: Numpy det and slogdet operator URL: https://github.com/apache/incubator-mxnet/pull/15861#discussion_r313093526 ## File path: src/operator/tensor/la_op.cu ## @@ -100,15 +100,19 @@

[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #15861: Numpy det and slogdet operator

2019-08-12 Thread GitBox
reminisce commented on a change in pull request #15861: Numpy det and slogdet operator URL: https://github.com/apache/incubator-mxnet/pull/15861#discussion_r313093332 ## File path: src/operator/tensor/la_op.cc ## @@ -983,6 +984,7 @@ Examples:: .add_argument("A",

[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #15861: Numpy det and slogdet operator

2019-08-12 Thread GitBox
reminisce commented on a change in pull request #15861: Numpy det and slogdet operator URL: https://github.com/apache/incubator-mxnet/pull/15861#discussion_r313093399 ## File path: src/operator/tensor/la_op.cc ## @@ -1038,6 +1041,7 @@ Examples:: .add_argument("A",

[GitHub] [incubator-mxnet] DickJC123 commented on a change in pull request #15812: cuDNN support cleanup

2019-08-12 Thread GitBox
DickJC123 commented on a change in pull request #15812: cuDNN support cleanup URL: https://github.com/apache/incubator-mxnet/pull/15812#discussion_r313140702 ## File path: src/operator/nn/cudnn/cudnn_algoreg-inl.h ## @@ -44,6 +44,10 @@ namespace op { */ template class

[incubator-mxnet] branch doc-patch updated: Update indexing_op.cc

2019-08-12 Thread haibin
This is an automated email from the ASF dual-hosted git repository. haibin pushed a commit to branch doc-patch in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/doc-patch by this push: new a811563 Update indexing_op.cc

[GitHub] [incubator-mxnet] larroy commented on issue #15777: Re-enable flaky test_prelu

2019-08-12 Thread GitBox
larroy commented on issue #15777: Re-enable flaky test_prelu URL: https://github.com/apache/incubator-mxnet/pull/15777#issuecomment-520604635 I run many times and it didn't fail with the flakyness checker. This is an

[GitHub] [incubator-mxnet] larroy edited a comment on issue #15777: Re-enable flaky test_prelu

2019-08-12 Thread GitBox
larroy edited a comment on issue #15777: Re-enable flaky test_prelu URL: https://github.com/apache/incubator-mxnet/pull/15777#issuecomment-520604635 I run many times and it didn't fail with the flakyness checker. Maybe there was a change that affected it not to be flaky anymore?

[GitHub] [incubator-mxnet] larroy commented on issue #15545: Softmax fwd optimization for GPU

2019-08-12 Thread GitBox
larroy commented on issue #15545: Softmax fwd optimization for GPU URL: https://github.com/apache/incubator-mxnet/pull/15545#issuecomment-520614156 https://developercommunity.visualstudio.com/content/problem/284930/error-c1002-compiler-is-out-of-heap-space-in-pass.html We should update to

[GitHub] [incubator-mxnet] larroy commented on issue #15545: Softmax fwd optimization for GPU

2019-08-12 Thread GitBox
larroy commented on issue #15545: Softmax fwd optimization for GPU URL: https://github.com/apache/incubator-mxnet/pull/15545#issuecomment-520614197 (or Newer) This is an automated message from the Apache Git Service. To

[GitHub] [incubator-mxnet] reminisce opened a new pull request #15867: Port several np ops to master

2019-08-12 Thread GitBox
reminisce opened a new pull request #15867: Port several np ops to master URL: https://github.com/apache/incubator-mxnet/pull/15867 ## Description ## Ports several numpy-like ops from the [numpy](https://github.com/apache/incubator-mxnet/tree/numpy) branch to master. ``` tile

[GitHub] [incubator-mxnet] access2rohit opened a new pull request #15868: fixing problem with existing Singleton Caching

2019-08-12 Thread GitBox
access2rohit opened a new pull request #15868: fixing problem with existing Singleton Caching URL: https://github.com/apache/incubator-mxnet/pull/15868 ## Description ## Same as title ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your

[GitHub] [incubator-mxnet] access2rohit commented on issue #15868: fixing problem with existing Singleton Caching

2019-08-12 Thread GitBox
access2rohit commented on issue #15868: fixing problem with existing Singleton Caching URL: https://github.com/apache/incubator-mxnet/pull/15868#issuecomment-520632876 @apeforest @ChaiBapchya @larroy please review This is

[GitHub] [incubator-mxnet] access2rohit commented on issue #15868: fixing problem with existing Singleton Caching

2019-08-12 Thread GitBox
access2rohit commented on issue #15868: fixing problem with existing Singleton Caching URL: https://github.com/apache/incubator-mxnet/pull/15868#issuecomment-520632912 @mxnet-label-bot add [pr-awaiting-review] This is an

[GitHub] [incubator-mxnet] haojin2 opened a new pull request #15843: Numpy-compatible concatenate upstream

2019-08-12 Thread GitBox
haojin2 opened a new pull request #15843: Numpy-compatible concatenate upstream URL: https://github.com/apache/incubator-mxnet/pull/15843 ## Description ## As title. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [ ] The PR

[GitHub] [incubator-mxnet] haojin2 opened a new pull request #15841: Numpy-compatible split upstream

2019-08-12 Thread GitBox
haojin2 opened a new pull request #15841: Numpy-compatible split upstream URL: https://github.com/apache/incubator-mxnet/pull/15841 ## Description ## As title. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [ ] The PR title

[GitHub] [incubator-mxnet] haojin2 closed pull request #15841: Numpy-compatible split upstream

2019-08-12 Thread GitBox
haojin2 closed pull request #15841: Numpy-compatible split upstream URL: https://github.com/apache/incubator-mxnet/pull/15841 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-mxnet] haojin2 closed pull request #15843: Numpy-compatible concatenate upstream

2019-08-12 Thread GitBox
haojin2 closed pull request #15843: Numpy-compatible concatenate upstream URL: https://github.com/apache/incubator-mxnet/pull/15843 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-mxnet] KellenSunderland commented on a change in pull request #15812: cuDNN support cleanup

2019-08-12 Thread GitBox
KellenSunderland commented on a change in pull request #15812: cuDNN support cleanup URL: https://github.com/apache/incubator-mxnet/pull/15812#discussion_r313127388 ## File path: src/operator/nn/cudnn/cudnn_convolution-inl.h ## @@ -577,29 +427,19 @@ class

[GitHub] [incubator-mxnet] iamthebot commented on issue #15721: Regression w/ Keras and MxNet 1.5.0: Error in operator batchnorm... Check failed: i >= 0 && i < ndim(): index = 1 must be in range [0, -

2019-08-12 Thread GitBox
iamthebot commented on issue #15721: Regression w/ Keras and MxNet 1.5.0: Error in operator batchnorm... Check failed: i >= 0 && i < ndim(): index = 1 must be in range [0, -1) URL: https://github.com/apache/incubator-mxnet/issues/15721#issuecomment-520618788 @roywei I have confirmed that

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15808: Add option to choose between OMP implementations

2019-08-12 Thread GitBox
apeforest commented on a change in pull request #15808: Add option to choose between OMP implementations URL: https://github.com/apache/incubator-mxnet/pull/15808#discussion_r313158054 ## File path: CMakeLists.txt ## @@ -24,6 +24,7 @@ mxnet_option(USE_OLDCMAKECUDA

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15808: Add option to choose between OMP implementations

2019-08-12 Thread GitBox
larroy commented on a change in pull request #15808: Add option to choose between OMP implementations URL: https://github.com/apache/incubator-mxnet/pull/15808#discussion_r313161483 ## File path: CMakeLists.txt ## @@ -24,6 +24,7 @@ mxnet_option(USE_OLDCMAKECUDA "Build

[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #14288: [Flaky] test_operator_gpu.test_dropout

2019-08-12 Thread GitBox
ChaiBapchya commented on issue #14288: [Flaky] test_operator_gpu.test_dropout URL: https://github.com/apache/incubator-mxnet/issues/14288#issuecomment-520625848 Was able to reproduce this issue. With `cudnn_off=True`, ``` check_dropout_ratio(1.0, shape) ``` Works

<    1   2