[GitHub] [incubator-mxnet] perdasilva commented on issue #16065: Fixes openblas static build

2019-09-01 Thread GitBox
perdasilva commented on issue #16065: Fixes openblas static build
URL: https://github.com/apache/incubator-mxnet/pull/16065#issuecomment-527012816
 
 
   @TaoLv ok, I've identified the problem. It should notify failures properly 
now. Let's see if it greens up with the new Fortran build flag. 
   
   Thanks for being thorough - and sorry for the mix up


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #16015: [numpy][tvm] rad2deg && deg2rad

2019-09-01 Thread GitBox
haojin2 commented on a change in pull request #16015: [numpy][tvm] rad2deg && 
deg2rad
URL: https://github.com/apache/incubator-mxnet/pull/16015#discussion_r319813788
 
 

 ##
 File path: tests/python/unittest/test_numpy_op.py
 ##
 @@ -1080,6 +1080,80 @@ def hybrid_forward(self, F, a, *args):
 assert same(mx_out.asnumpy(), np_out)
 
 
+@with_seed()
+@use_np
+def test_np_degandrad():
+class TestDeg2rad(HybridBlock):
+def __init__(self):
+super(TestDeg2rad, self).__init__()
+
+def hybrid_forward(self, F, x):
+return F.np.deg2rad(x)
+
+class TestRad2deg(HybridBlock):
+def __init__(self):
+super(TestRad2deg, self).__init__()
+
+def hybrid_forward(self, F, x):
+return F.np.rad2deg(x)
+
+types = ['float64', 'float32']
+for hybridize in [True, False]:
+for shape in [(),
+  (1,),
+  (1, 1),
+  (1, 2, 3),
+  (1, 0),
+  (2, 0, 3)
+  ]:
 
 Review comment:
   simply do
   ```Python
   for shape in [(), (1,), (1, 1), (1, 2, 3), (1, 0), (2, 0, 3)]:
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #16015: [numpy][tvm] rad2deg && deg2rad

2019-09-01 Thread GitBox
haojin2 commented on a change in pull request #16015: [numpy][tvm] rad2deg && 
deg2rad
URL: https://github.com/apache/incubator-mxnet/pull/16015#discussion_r319813621
 
 

 ##
 File path: python/mxnet/ndarray/numpy/_op.py
 ##
 @@ -32,7 +32,8 @@
'exp', 'expm1', 'arcsin', 'arccos', 'arctan', 'sign', 'log', 
'degrees', 'log2', 'log1p',
'rint', 'radians', 'reciprocal', 'square', 'negative', 'fix', 
'ceil', 'floor',
'trunc', 'logical_not', 'arcsinh', 'arccosh', 'arctanh', 
'tensordot',
-   'linspace', 'expand_dims', 'tile', 'arange', 'split', 
'concatenate', 'stack']
+   'linspace', 'expand_dims', 'tile', 'arange', 'split', 
'concatenate', 'stack', 'deg2rad',
+   'rad2deg']
 
 Review comment:
   Same for the func declarations within the file


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #16015: [numpy][tvm] rad2deg && deg2rad

2019-09-01 Thread GitBox
haojin2 commented on a change in pull request #16015: [numpy][tvm] rad2deg && 
deg2rad
URL: https://github.com/apache/incubator-mxnet/pull/16015#discussion_r319813665
 
 

 ##
 File path: python/mxnet/ndarray/numpy/_op.py
 ##
 @@ -32,7 +32,8 @@
'exp', 'expm1', 'arcsin', 'arccos', 'arctan', 'sign', 'log', 
'degrees', 'log2', 'log1p',
'rint', 'radians', 'reciprocal', 'square', 'negative', 'fix', 
'ceil', 'floor',
'trunc', 'logical_not', 'arcsinh', 'arccosh', 'arctanh', 
'tensordot',
-   'linspace', 'expand_dims', 'tile', 'arange', 'split', 
'concatenate', 'stack']
+   'linspace', 'expand_dims', 'tile', 'arange', 'split', 
'concatenate', 'stack', 'deg2rad',
+   'rad2deg']
 
 Review comment:
   In all files.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #16015: [numpy][tvm] rad2deg && deg2rad

2019-09-01 Thread GitBox
haojin2 commented on a change in pull request #16015: [numpy][tvm] rad2deg && 
deg2rad
URL: https://github.com/apache/incubator-mxnet/pull/16015#discussion_r319813576
 
 

 ##
 File path: python/mxnet/ndarray/numpy/_op.py
 ##
 @@ -32,7 +32,8 @@
'exp', 'expm1', 'arcsin', 'arccos', 'arctan', 'sign', 'log', 
'degrees', 'log2', 'log1p',
'rint', 'radians', 'reciprocal', 'square', 'negative', 'fix', 
'ceil', 'floor',
'trunc', 'logical_not', 'arcsinh', 'arccosh', 'arctanh', 
'tensordot',
-   'linspace', 'expand_dims', 'tile', 'arange', 'split', 
'concatenate', 'stack']
+   'linspace', 'expand_dims', 'tile', 'arange', 'split', 
'concatenate', 'stack', 'deg2rad',
+   'rad2deg']
 
 Review comment:
   move 'deg2rad' to after 'radians' and 'rad2deg' to after 'degrees'.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] perdasilva commented on issue #16065: Fixes openblas static build

2019-09-01 Thread GitBox
perdasilva commented on issue #16065: Fixes openblas static build
URL: https://github.com/apache/incubator-mxnet/pull/16065#issuecomment-527011478
 
 
   Right, I forgot to add a build flag. Still unhappy it's failing and marking 
it as a success. Let me see what I can do...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #16008: [Numpy] Trace

2019-09-01 Thread GitBox
haojin2 commented on a change in pull request #16008: [Numpy] Trace
URL: https://github.com/apache/incubator-mxnet/pull/16008#discussion_r319812976
 
 

 ##
 File path: src/operator/numpy/np_trace_op.cc
 ##
 @@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ *  Copyright (c) 2019 by Contributors
+ * \file np_trace_op.cc
+ * \brief CPU Implementation of numpy-compatible trace operator
+ */
+
+#include "./np_trace_op-inl.h"
+
+namespace mxnet {
+namespace op {
+
+inline bool NumpyTraceOpShape(const nnvm::NodeAttrs& attrs,
+  mxnet::ShapeVector* in_attrs,
+  mxnet::ShapeVector* out_attrs) {
+  CHECK_EQ(in_attrs->size(), 1);
+  CHECK_EQ(out_attrs->size(), 1);
+  const int ndim((*in_attrs)[0].ndim());
+  if (ndim < 2) {
+return false;
+  }
+  std::vector oshape(ndim - 2);
+  const NumpyTraceParam& param = nnvm::get(attrs.parsed);
+  int x1 = CheckAxis(param.axis1, (*in_attrs)[0].ndim());
+  int x2 = CheckAxis(param.axis2, (*in_attrs)[0].ndim());
+  CHECK_NE(x1, x2) << "axis1 and axis2 cannot refer to the the same axis " << 
x1;
+  for ( int i = 0, j = 0; i < ndim; ++i ) {
+if (i != x1 && i != x2) {
+  oshape[j++] = (*in_attrs)[0][i];
+}
+  }
+  mxnet::TShape tshape(oshape.begin(), oshape.end());
+  SHAPE_ASSIGN_CHECK(*out_attrs, 0, tshape);
+  return true;
+}
+
+DMLC_REGISTER_PARAMETER(NumpyTraceParam);
+
+NNVM_REGISTER_OP(_np_trace)
+.describe(R"code(Computes the sum of the diagonal elements of a matrix.
+Input is a tensor *A* of dimension *n >= 2*.
 
 Review comment:
   This description section could be skipped.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] nopattern commented on issue #15472: Failed to compile plugin warpctc

2019-09-01 Thread GitBox
nopattern commented on issue #15472: Failed to compile plugin warpctc
URL: 
https://github.com/apache/incubator-mxnet/issues/15472#issuecomment-527009800
 
 
   yes ,I think that worked.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #16025: Numpy add numpy op left_shift and right_shift

2019-09-01 Thread GitBox
haojin2 commented on a change in pull request #16025: Numpy add numpy op 
left_shift and right_shift
URL: https://github.com/apache/incubator-mxnet/pull/16025#discussion_r319812192
 
 

 ##
 File path: tests/python/unittest/test_numpy_op.py
 ##
 @@ -1126,6 +1126,62 @@ def test_np_randint():
 verify_generator(generator=generator_mx_same_seed, 
buckets=buckets, probs=probs, nrepeat=100)
 
 
+@with_seed()
+@use_np
+def test_np_left_shift():
+class TestLeftShift(HybridBlock):
+def __init__(self):
+super(TestLeftShift, self).__init__()
+
+def hybrid_forward(self, F, a, b):
+return F.np.left_shift(a, b)
+
+@use_np
+class TestRightShift(HybridBlock):
+def __init__(self):
+super(TestRightShift, self).__init__()
+
+def hybrid_forward(self, F, a, b):
+return F.np.right_shift(a, b)
+
+shapes = [
+((), ()),
+((), (2,)),
+((3,), ()),
+((3, 4), (3, 4)),
+((3, 4, 5, 6), (6,)),
+((2, 0, 3), (3,)),
+((2, 1, 3), (2, 3))
+]
+dtypes = ['uint8', 'int8', 'int32', 'int64']
+for shape in shapes:
+a, b = shape[0], shape[1]
+for dtype in dtypes:
+for hybridize in [True, False]:
+test_left_shift = TestLeftShift()
+test_right_shift = TestRightShift()
+x1 = mx.nd.random.uniform(-10.0, 10.0, 
a).astype(dtype).as_np_ndarray()
+x2 = mx.nd.random.uniform(0, 10.0, 
b).astype(dtype).as_np_ndarray()
+if hybridize:
+test_left_shift.hybridize()
+test_right_shift.hybridize()
+
+mx_out_left_shift = test_left_shift(x1, x2)
+mx_out_right_shift = test_right_shift(x1, x2)
+
+np_out_left_shift = _np.left_shift(x1.asnumpy(), x2.asnumpy())
+np_out_right_shift = _np.right_shift(x1.asnumpy(), 
x2.asnumpy())
 
 Review comment:
   ```Python
   np_shift_out = getattr(_np, func)(x1.asnumpy(), x2.asnumpy())
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #16025: Numpy add numpy op left_shift and right_shift

2019-09-01 Thread GitBox
haojin2 commented on a change in pull request #16025: Numpy add numpy op 
left_shift and right_shift
URL: https://github.com/apache/incubator-mxnet/pull/16025#discussion_r319812120
 
 

 ##
 File path: tests/python/unittest/test_numpy_op.py
 ##
 @@ -1126,6 +1126,62 @@ def test_np_randint():
 verify_generator(generator=generator_mx_same_seed, 
buckets=buckets, probs=probs, nrepeat=100)
 
 
+@with_seed()
+@use_np
+def test_np_left_shift():
+class TestLeftShift(HybridBlock):
+def __init__(self):
+super(TestLeftShift, self).__init__()
+
+def hybrid_forward(self, F, a, b):
+return F.np.left_shift(a, b)
+
+@use_np
+class TestRightShift(HybridBlock):
+def __init__(self):
+super(TestRightShift, self).__init__()
+
+def hybrid_forward(self, F, a, b):
+return F.np.right_shift(a, b)
+
+shapes = [
+((), ()),
+((), (2,)),
+((3,), ()),
+((3, 4), (3, 4)),
+((3, 4, 5, 6), (6,)),
+((2, 0, 3), (3,)),
+((2, 1, 3), (2, 3))
+]
+dtypes = ['uint8', 'int8', 'int32', 'int64']
+for shape in shapes:
+a, b = shape[0], shape[1]
+for dtype in dtypes:
+for hybridize in [True, False]:
+test_left_shift = TestLeftShift()
+test_right_shift = TestRightShift()
 
 Review comment:
   ```Python
   # other for-loops
   for func in ['left_shift', 'right_shift']:
   # other for-loops
   test_shift = TestShift(func)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #16025: Numpy add numpy op left_shift and right_shift

2019-09-01 Thread GitBox
haojin2 commented on a change in pull request #16025: Numpy add numpy op 
left_shift and right_shift
URL: https://github.com/apache/incubator-mxnet/pull/16025#discussion_r319811983
 
 

 ##
 File path: tests/python/unittest/test_numpy_op.py
 ##
 @@ -1126,6 +1126,62 @@ def test_np_randint():
 verify_generator(generator=generator_mx_same_seed, 
buckets=buckets, probs=probs, nrepeat=100)
 
 
+@with_seed()
+@use_np
+def test_np_left_shift():
+class TestLeftShift(HybridBlock):
+def __init__(self):
+super(TestLeftShift, self).__init__()
+
+def hybrid_forward(self, F, a, b):
+return F.np.left_shift(a, b)
+
+@use_np
+class TestRightShift(HybridBlock):
+def __init__(self):
+super(TestRightShift, self).__init__()
+
+def hybrid_forward(self, F, a, b):
+return F.np.right_shift(a, b)
 
 Review comment:
   ```Python
   class TestShift(HybridBlock):
   def __init__(self, func):
   super(TestShift, self).__init__()
   self._func = func
   
   def hybrid_forward(self, F, a, b):
   return getattr(F.np, self._func)(a, b)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #16016: [numpy] operator ravel, derive from reshape

2019-09-01 Thread GitBox
haojin2 commented on a change in pull request #16016: [numpy] operator ravel, 
derive from reshape
URL: https://github.com/apache/incubator-mxnet/pull/16016#discussion_r319810186
 
 

 ##
 File path: tests/python/unittest/test_numpy_op.py
 ##
 @@ -1082,6 +1082,45 @@ def hybrid_forward(self, F, a, *args):
 assert same(mx_out.asnumpy(), np_out)
 
 
+@with_seed()
+@use_np
+def test_np_ravel():
+class TestRavel(HybridBlock):
+def __init__(self):
+super(TestRavel, self).__init__()
+
+def hybrid_forward(self, F, a):
+return F.np.ravel(a)
+
+types = ['float64', 'float32', 'float16', 'int64', 'int32', 'int8']
+for oneType in types:
+for hybridize in [True, False]:
+for shape in [(),
+  (2,),
+  (2, 2),
+  (1, 2, 3),
+  (3, 0),
+  (1, 0, 2)
+  ]:
 
 Review comment:
   Simply do
   ```Python
   for shape in [(), (2,), (2, 2), (1, 2, 3), (3, 0), (1, 0, 2)]:
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] haojin2 commented on issue #15387: Add docs for 7 ops

2019-09-01 Thread GitBox
haojin2 commented on issue #15387: Add docs for 7 ops
URL: https://github.com/apache/incubator-mxnet/pull/15387#issuecomment-527006398
 
 
   Closing this PR now since the content is no longer needed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] haojin2 closed pull request #15387: Add docs for 7 ops

2019-09-01 Thread GitBox
haojin2 closed pull request #15387: Add docs for 7 ops
URL: https://github.com/apache/incubator-mxnet/pull/15387
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] haojin2 closed pull request #15907: Test numpy indexing on numpy branch(DO NOT MERGE)

2019-09-01 Thread GitBox
haojin2 closed pull request #15907: Test numpy indexing on numpy branch(DO NOT 
MERGE)
URL: https://github.com/apache/incubator-mxnet/pull/15907
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] haojin2 commented on issue #15763: Numpy indexing

2019-09-01 Thread GitBox
haojin2 commented on issue #15763: Numpy indexing
URL: https://github.com/apache/incubator-mxnet/pull/15763#issuecomment-527006020
 
 
   Closing this PR now since #15942 has been merged.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] haojin2 commented on issue #15907: Test numpy indexing on numpy branch(DO NOT MERGE)

2019-09-01 Thread GitBox
haojin2 commented on issue #15907: Test numpy indexing on numpy branch(DO NOT 
MERGE)
URL: https://github.com/apache/incubator-mxnet/pull/15907#issuecomment-527006140
 
 
   Closing this PR now since #15942 has been merged.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] haojin2 closed pull request #15763: Numpy indexing

2019-09-01 Thread GitBox
haojin2 closed pull request #15763: Numpy indexing
URL: https://github.com/apache/incubator-mxnet/pull/15763
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] eric-haibin-lin commented on issue #15918: Trainer.save_state does not work if update_on_kvstore=False

2019-09-01 Thread GitBox
eric-haibin-lin commented on issue #15918: Trainer.save_state does not work if 
update_on_kvstore=False
URL: 
https://github.com/apache/incubator-mxnet/issues/15918#issuecomment-527003793
 
 
   Yes. `load_states` only loads the state for context[0] if 
update_on_kvstore=False, which makes GPU memory explode..


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] gyshi commented on issue #16067: fix some test files test time is too long

2019-09-01 Thread GitBox
gyshi commented on issue #16067: fix some test files test time is too long
URL: https://github.com/apache/incubator-mxnet/pull/16067#issuecomment-527002182
 
 
   @haojin2 , thx for reviewing


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] gyshi opened a new pull request #16067: fix some test files test time is too long

2019-09-01 Thread GitBox
gyshi opened a new pull request #16067: fix some test files test time is too 
long
URL: https://github.com/apache/incubator-mxnet/pull/16067
 
 
   because test_norm and  test_elemwise_binary_ops use  rand_shape_2d()。 by 
default, rand_shape_2d generate shape(0,0) to (10, 10), so it will generate too 
large shape. for some operator, it will consume much time. so i  limit it .
   
   for test_laop_5, i modify for loop from (1, 10) to (1, 5), beacuse i it's 
ok!  so the test time from 71.902s to 16.569s. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] gyshi commented on issue #16066: fix test_pick test time is too long

2019-09-01 Thread GitBox
gyshi commented on issue #16066: fix test_pick test time  is too long
URL: https://github.com/apache/incubator-mxnet/pull/16066#issuecomment-52756
 
 
   @haojin2 , thx for reviewing


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] gyshi opened a new pull request #16066: fix test_pick test time is too long

2019-09-01 Thread GitBox
gyshi opened a new pull request #16066: fix test_pick test time  is too long
URL: https://github.com/apache/incubator-mxnet/pull/16066
 
 
   before remove for loop, 
   test time is too long  cpu:130.647s . gpu:188.873s
   after remove for loop, cpu:0.229s .  gpu:14.004s
   because i think  for loop is redundancy. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] Zheweiqiu commented on issue #15892: retinaface model to onnx

2019-09-01 Thread GitBox
Zheweiqiu commented on issue #15892: retinaface model to onnx
URL: 
https://github.com/apache/incubator-mxnet/issues/15892#issuecomment-526977705
 
 
   > > > > Thanks @vandanavk for trying out. I go this error at first. After I 
googled, according to this [answer](https://github.com/onnx/onnx/issues/1954) I 
replace all "SoftmaxActivation" with "softmax" in the *.json file. Then I got 
the error stated in the question. Do I need to re-train the model using op 
"softmax" instead of "SoftmaxActivation"?
   > > > > Thanks!
   > > > 
   > > > 
   > > > Retraining with softmax would be the best solution, since 
SoftmaxActivation has been deprecated.
   > > 
   > > 
   > > I tried remove the attribute mode for softmax operator but got the 
following error:
   > > AttributeError: No conversion function registered for op type UpSampling 
yet.
   > > I believe same problem will be encountered even if I retrain the model 
and I see this issue is still working in progress.
   > > Thanks for your reply!
   > 
   > Support for Upsampling operator is currently in review. Operator changes 
in #15811 and ONNX support in #15994. You could pull in these changes and build 
locally to try immediately. Else, you could watch out for these 2 PRs getting 
merged.
   
   The mxnet was installed using pip command. Do I need to uninstall it and 
rebuild it from source to reflect those changes?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] TaoLv commented on issue #16065: Fixes openblas static build

2019-09-01 Thread GitBox
TaoLv commented on issue #16065: Fixes openblas static build
URL: https://github.com/apache/incubator-mxnet/pull/16065#issuecomment-526973401
 
 
   Openblas build failed but the CI task reported success.
   
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-16065/1/pipeline/285
   
   ```
    make --quiet -j 72 PREFIX=/work/mxnet/staticdeps install
   make[1]: warning: -jN forced in submake: disabling jobserver mode.
   Generating openblas_config.h in /work/mxnet/staticdeps/include
   Generating f77blas.h in /work/mxnet/staticdeps/include
   Generating cblas.h in /work/mxnet/staticdeps/include
   Copying LAPACKE header files to /work/mxnet/staticdeps/include
   Copying the static library to /work/mxnet/staticdeps/lib
   Copying the shared library to /work/mxnet/staticdeps/lib
   install: cannot stat 'libopenblasp-r0.3.7.so': No such file or directory
   make[1]: *** [install] Error 1
   make: *** [install] Error 2
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] TaoLv commented on issue #15741: MKL-DNN LBR-GRU Inference Integration (FP32 LBR-GRU)

2019-09-01 Thread GitBox
TaoLv commented on issue #15741: MKL-DNN LBR-GRU Inference Integration (FP32 
LBR-GRU)
URL: https://github.com/apache/incubator-mxnet/pull/15741#issuecomment-526972782
 
 
   > What does Linear-Before-Reset mean?
   
   See the different definition of c(t) in GRU and LBR GRU: 
https://intel.github.io/mkl-dnn/dev_guide_rnn.html#Linear-before-reset-GRU


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-09-01 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository.

marcoabreu pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new 82ee250  Bump the publish timestamp.
82ee250 is described below

commit 82ee25004b2a111ee739cde564532e1c1468c4a8
Author: mxnet-ci 
AuthorDate: Mon Sep 2 01:30:38 2019 +

Bump the publish timestamp.
---
 date.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/date.txt b/date.txt
new file mode 100644
index 000..d5e0fb5
--- /dev/null
+++ b/date.txt
@@ -0,0 +1 @@
+Mon Sep  2 01:30:38 UTC 2019



[GitHub] [incubator-mxnet] eric-haibin-lin closed issue #16020: Is there any communication between parameter servers?

2019-09-01 Thread GitBox
eric-haibin-lin closed issue #16020: Is there any communication between 
parameter servers?
URL: https://github.com/apache/incubator-mxnet/issues/16020
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] eric-haibin-lin commented on issue #16020: Is there any communication between parameter servers?

2019-09-01 Thread GitBox
eric-haibin-lin commented on issue #16020: Is there any communication between 
parameter servers?
URL: 
https://github.com/apache/incubator-mxnet/issues/16020#issuecomment-526965259
 
 
   The code is at 
https://github.com/apache/incubator-mxnet/blob/master/src/kvstore/kvstore_dist.h
 
   and 
   
https://github.com/apache/incubator-mxnet/blob/master/src/kvstore/kvstore_dist_server.h
   Feel free to reopen for further questions 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] eric-haibin-lin commented on issue #15662: cudnn Dropout reproducibility

2019-09-01 Thread GitBox
eric-haibin-lin commented on issue #15662: cudnn Dropout reproducibility 
URL: 
https://github.com/apache/incubator-mxnet/issues/15662#issuecomment-526965194
 
 
   @ptrendx @DickJC123 just FYI 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] eric-haibin-lin commented on issue #15933: indexing op does not report out of bound indices

2019-09-01 Thread GitBox
eric-haibin-lin commented on issue #15933: indexing op does not report out of 
bound indices 
URL: 
https://github.com/apache/incubator-mxnet/issues/15933#issuecomment-526965060
 
 
   Raise mode added in #15887 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] eric-haibin-lin commented on issue #14434: could i set multi kv_store in distribute training program?

2019-09-01 Thread GitBox
eric-haibin-lin commented on issue #14434: could  i set multi kv_store in 
distribute training program?
URL: 
https://github.com/apache/incubator-mxnet/issues/14434#issuecomment-526964995
 
 
   you need to manually do kvstore.pull after kvstore.init to make sure all 
weights are initialized to the same value 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] eric-haibin-lin commented on issue #15741: MKL-DNN LBR-GRU Inference Integration (FP32 LBR-GRU)

2019-09-01 Thread GitBox
eric-haibin-lin commented on issue #15741: MKL-DNN LBR-GRU Inference 
Integration (FP32 LBR-GRU)
URL: https://github.com/apache/incubator-mxnet/pull/15741#issuecomment-526964321
 
 
   What does Linear-Before-Reset mean? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] wkcn commented on a change in pull request #16061: Allow loading from model files with empty weights.

2019-09-01 Thread GitBox
wkcn commented on a change in pull request #16061: Allow loading from model 
files with empty weights.
URL: https://github.com/apache/incubator-mxnet/pull/16061#discussion_r319778476
 
 

 ##
 File path: python/mxnet/model.py
 ##
 @@ -431,6 +431,7 @@ def load_params(prefix, epoch):
 aux_params = {}
 if not save_dict:
 logging.warning("Params file '%s' is empty", '%s-%04d.params' % 
(prefix, epoch))
+return (arg_params, aux_params)
 
 Review comment:
   Thanks for your contribution!
   In the original code, the function will return empty weights in the line 440 
when loading an empty file.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] wkcn commented on a change in pull request #16061: Allow loading from model files with empty weights.

2019-09-01 Thread GitBox
wkcn commented on a change in pull request #16061: Allow loading from model 
files with empty weights.
URL: https://github.com/apache/incubator-mxnet/pull/16061#discussion_r319778476
 
 

 ##
 File path: python/mxnet/model.py
 ##
 @@ -431,6 +431,7 @@ def load_params(prefix, epoch):
 aux_params = {}
 if not save_dict:
 logging.warning("Params file '%s' is empty", '%s-%04d.params' % 
(prefix, epoch))
+return (arg_params, aux_params)
 
 Review comment:
   Thanks for your contribution!
   In the original code, the function will return empty weights in the line 440 
when loading an empty file.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-09-01 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository.

marcoabreu pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new 2b870ac  Bump the publish timestamp.
2b870ac is described below

commit 2b870acfb6e4748990f7ab3ef8638d5e484552e2
Author: mxnet-ci 
AuthorDate: Sun Sep 1 21:11:04 2019 +

Bump the publish timestamp.
---
 date.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/date.txt b/date.txt
new file mode 100644
index 000..be1c739
--- /dev/null
+++ b/date.txt
@@ -0,0 +1 @@
+Sun Sep  1 21:11:04 UTC 2019



[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-09-01 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository.

marcoabreu pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new 70b60afa Bump the publish timestamp.
70b60afa is described below

commit 70b60afadcc748e3dae99dc1ad39ce7bd44c9810
Author: mxnet-ci 
AuthorDate: Sun Sep 1 19:33:48 2019 +

Bump the publish timestamp.
---
 date.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/date.txt b/date.txt
new file mode 100644
index 000..5adbb2f
--- /dev/null
+++ b/date.txt
@@ -0,0 +1 @@
+Sun Sep  1 19:33:48 UTC 2019



[incubator-mxnet] branch master updated (6997691 -> 36bab1c)

2019-09-01 Thread liuyizhi
This is an automated email from the ASF dual-hosted git repository.

liuyizhi pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.


from 6997691  [Dev] update ps-lite dependency (#15936)
 add 36bab1c  Fix flaky clojure profile test (#16058)

No new revisions were added by this update.

Summary of changes:
 .../examples/profiler/test/core_test.clj   |   3 +-
 .../profiler/test/profile-matmul-20iter.json.ref   | 271 -
 contrib/clojure-package/integration-tests.sh   |   2 +-
 3 files changed, 2 insertions(+), 274 deletions(-)
 delete mode 100644 
contrib/clojure-package/examples/profiler/test/profile-matmul-20iter.json.ref



[GitHub] [incubator-mxnet] yzhliu commented on issue #16058: Fix flaky clojure profile test

2019-09-01 Thread GitBox
yzhliu commented on issue #16058: Fix flaky clojure profile test
URL: https://github.com/apache/incubator-mxnet/pull/16058#issuecomment-526946324
 
 
   Thanks @gigasquid for quick response


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] yzhliu merged pull request #16058: Fix flaky clojure profile test

2019-09-01 Thread GitBox
yzhliu merged pull request #16058: Fix flaky clojure profile test
URL: https://github.com/apache/incubator-mxnet/pull/16058
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-mxnet] branch master updated (aab4ded -> 6997691)

2019-09-01 Thread haibin
This is an automated email from the ASF dual-hosted git repository.

haibin pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.


from aab4ded  Numpy compatible max min (#16046)
 add 6997691  [Dev] update ps-lite dependency (#15936)

No new revisions were added by this update.

Summary of changes:
 3rdparty/ps-lite | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



[GitHub] [incubator-mxnet] eric-haibin-lin merged pull request #15936: [Dev] update ps-lite dependency

2019-09-01 Thread GitBox
eric-haibin-lin merged pull request #15936: [Dev] update ps-lite dependency
URL: https://github.com/apache/incubator-mxnet/pull/15936
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] perdasilva commented on issue #16021: [CI] openblas build failed in static build

2019-09-01 Thread GitBox
perdasilva commented on issue #16021: [CI] openblas build failed in static build
URL: 
https://github.com/apache/incubator-mxnet/issues/16021#issuecomment-526936663
 
 
   @TaoLv I've just opened a PR, please review and merge if ok =D


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] perdasilva opened a new pull request #16065: Fixes openblas static build

2019-09-01 Thread GitBox
perdasilva opened a new pull request #16065: Fixes openblas static build
URL: https://github.com/apache/incubator-mxnet/pull/16065
 
 
   ## Description ##
   Fixes #16021. The static build fails with openblas v0.3.5, this PR bumps it 
to v0.3.7, which seems to work.
   This PR also updates CI to build the openblas-based static library to test 
the non-mkl build path.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to 
the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) 
created (except PRs with tiny changes)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding 
a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing 
distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a 
new build option with NCCL)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments 
are documented. 
   - For new examples, README.md is added to explain the what the example does, 
the source of the dataset, expected performance on test set and reference to 
the original paper if applicable
   - Check the API doc at 
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [x] To the my best knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] VoVAllen commented on issue #16054: [Bug] Error initialization with gluon when using mx.set_np_shape(True)

2019-09-01 Thread GitBox
VoVAllen commented on issue #16054: [Bug] Error initialization with gluon when 
using mx.set_np_shape(True)
URL: 
https://github.com/apache/incubator-mxnet/issues/16054#issuecomment-526923537
 
 
   @zheng-da Could you take a look at this and 
https://github.com/dmlc/dgl/issues/814? I'm not familiar with things behind 
`set_np_shape`. Currently dgl is incompatible with gluon due to this API. Do 
you think the solution above is fine?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] TaoLv opened a new pull request #16064: [mkldnn-v1.0] Enable base code with new APIs.

2019-09-01 Thread GitBox
TaoLv opened a new pull request #16064: [mkldnn-v1.0] Enable base code with new 
APIs.
URL: https://github.com/apache/incubator-mxnet/pull/16064
 
 
   ## Description ##
   Target the mkldnn-v1.0 feature branch, not the master branch.
   Enable base code in ndarray.cc/.h and mkldnn_base.cc/-inl.h with the new 
APIs in MKL-DNN v1.0.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to 
the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) 
created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding 
a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing 
distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a 
new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments 
are documented. 
   - For new examples, README.md is added to explain the what the example does, 
the source of the dataset, expected performance on test set and reference to 
the original paper if applicable
   - Check the API doc at 
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be 
made.
   - Interesting edge cases to note here
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-09-01 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository.

marcoabreu pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new 72f2bc3  Bump the publish timestamp.
72f2bc3 is described below

commit 72f2bc389b1e107d9b60bf3eb368483548f122dc
Author: mxnet-ci 
AuthorDate: Sun Sep 1 13:29:49 2019 +

Bump the publish timestamp.
---
 date.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/date.txt b/date.txt
new file mode 100644
index 000..2e62e10
--- /dev/null
+++ b/date.txt
@@ -0,0 +1 @@
+Sun Sep  1 13:29:49 UTC 2019



[GitHub] [incubator-mxnet] TaoLv commented on issue #16021: [CI] openblas build failed in static build

2019-09-01 Thread GitBox
TaoLv commented on issue #16021: [CI] openblas build failed in static build
URL: 
https://github.com/apache/incubator-mxnet/issues/16021#issuecomment-526917300
 
 
   Thank you @perdasilva. Do you have a fix for that? The mkldnn-v1.0 feature 
branch is also suffering from this issue.
   
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-16012/3/pipeline


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] mahmoodn commented on issue #16001: Low kernel performance

2019-09-01 Thread GitBox
mahmoodn commented on issue #16001: Low kernel performance
URL: 
https://github.com/apache/incubator-mxnet/issues/16001#issuecomment-526906691
 
 
   @sxjscience 
   Is `AddTakeGradLargeBatchKernel` correct? Should I see that in 1.2.0 with 
cuda-9.2?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] JiadingGai opened a new pull request #16063: Allow loading from model with empty weights.

2019-09-01 Thread GitBox
JiadingGai opened a new pull request #16063: Allow loading from model with 
empty weights.
URL: https://github.com/apache/incubator-mxnet/pull/16063
 
 
   ## Description ##
   (Brief description on what this PR is about)
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to 
the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) 
created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding 
a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing 
distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a 
new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments 
are documented. 
   - For new examples, README.md is added to explain the what the example does, 
the source of the dataset, expected performance on test set and reference to 
the original paper if applicable
   - Check the API doc at 
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be 
made.
   - Interesting edge cases to note here
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] JiadingGai opened a new pull request #16062: Allow loading from model with empty weights.

2019-09-01 Thread GitBox
JiadingGai opened a new pull request #16062: Allow loading from model with 
empty weights.
URL: https://github.com/apache/incubator-mxnet/pull/16062
 
 
   For example, when the model graph contains only NDArray operators.
   
   ## Description ##
   (Brief description on what this PR is about)
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to 
the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) 
created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding 
a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing 
distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a 
new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments 
are documented. 
   - For new examples, README.md is added to explain the what the example does, 
the source of the dataset, expected performance on test set and reference to 
the original paper if applicable
   - Check the API doc at 
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be 
made.
   - Interesting edge cases to note here
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] JiadingGai opened a new pull request #16061: Allow loading from model files with empty weights.

2019-09-01 Thread GitBox
JiadingGai opened a new pull request #16061: Allow loading from model files 
with empty weights.
URL: https://github.com/apache/incubator-mxnet/pull/16061
 
 
   ## Description ##
   (Brief description on what this PR is about)
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to 
the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) 
created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding 
a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing 
distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a 
new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments 
are documented. 
   - For new examples, README.md is added to explain the what the example does, 
the source of the dataset, expected performance on test set and reference to 
the original paper if applicable
   - Check the API doc at 
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be 
made.
   - Interesting edge cases to note here
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] canerturkmen commented on issue #16049: Gluon HybridBlock instantiation with params compares initializers

2019-09-01 Thread GitBox
canerturkmen commented on issue #16049: Gluon HybridBlock instantiation with 
params compares initializers
URL: 
https://github.com/apache/incubator-mxnet/issues/16049#issuecomment-526898974
 
 
   Indeed, that is a nice workaround.
   
   Ultimately I thought this was an issue since the two initializers are 
(logically) equivalent, and that the `Initializer` class does not implement 
`__eq__`. But if it's expected behavior that the parameter initialization 
compares initializers by reference, my question is answered.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] yifeim opened a new issue #16060: [bug] mxnet.ndarray.sparse.norm fallback regression in 1.5.0 and master

2019-09-01 Thread GitBox
yifeim opened a new issue #16060: [bug] mxnet.ndarray.sparse.norm fallback 
regression in 1.5.0 and master
URL: https://github.com/apache/incubator-mxnet/issues/16060
 
 
   ## Description
   mxnet.ndarray.sparse.norm causes sparse fallback in CSRNDArray in 1.5.0 and 
master. Additionally, that the regression passed unit tests suggests deeper 
issues. For example, all sparse regression fallbacks happen silently in the 
background, instead of being surfaced to the caller. This makes it difficult to 
id the root cause.
   
   ## Environment info (Required)
   
   ```
   --Python Info--
   ('Version  :', '2.7.15')
   ('Compiler :', 'GCC 7.3.0')
   ('Build:', ('default', 'Feb 28 2019 04:00:11'))
   ('Arch :', ('64bit', ''))
   Pip Info---
   ('Version  :', '10.0.1')
   ('Directory:', 
'/home/ec2-user/anaconda3/envs/mxnet_p27/lib/python2.7/site-packages/pip')
   --MXNet Info---
   ('Version  :', '1.6.0')
   ('Directory:', 
'/home/ec2-user/anaconda3/envs/mxnet_p27/lib/python2.7/site-packages/mxnet')
   ('Commit Hash   :', '3f7b6ee57865b79634c82a8f58e3551fc95e4dda')
   ('Library  :', 
['/home/ec2-user/anaconda3/envs/mxnet_p27/lib/python2.7/site-packages/mxnet/libmxnet.so'])
   Build features:
   ✔ CUDA
   ✔ CUDNN
   ✔ NCCL
   ✖ CUDA_RTC
   ✖ TENSORRT
   ✔ CPU_SSE
   ✔ CPU_SSE2
   ✔ CPU_SSE3
   ✔ CPU_SSE4_1
   ✔ CPU_SSE4_2
   ✖ CPU_SSE4A
   ✔ CPU_AVX
   ✖ CPU_AVX2
   ✔ OPENMP
   ✖ SSE
   ✔ F16C
   ✖ JEMALLOC
   ✔ BLAS_OPEN
   ✖ BLAS_ATLAS
   ✖ BLAS_MKL
   ✖ BLAS_APPLE
   ✔ LAPACK
   ✔ MKLDNN
   ✔ OPENCV
   ✖ CAFFE
   ✖ PROFILER
   ✔ DIST_KVSTORE
   ✖ CXX14
   ✖ INT64_TENSOR_SIZE
   ✔ SIGNAL_HANDLER
   ✖ DEBUG
   ✖ TVM_OP
   --System Info--
   ('Platform :', 
'Linux-4.14.133-88.112.amzn1.x86_64-x86_64-with-glibc2.2.5')
   ('system   :', 'Linux')
   ('node :', 'ip-172-16-12-219')
   ('release  :', '4.14.133-88.112.amzn1.x86_64')
   ('version  :', '#1 SMP Tue Jul 30 21:21:30 UTC 2019')
   --Hardware Info--
   ('machine  :', 'x86_64')
   ('processor:', 'x86_64')
   Architecture:  x86_64
   CPU op-mode(s):32-bit, 64-bit
   Byte Order:Little Endian
   CPU(s):32
   On-line CPU(s) list:   0-31
   Thread(s) per core:2
   Core(s) per socket:16
   Socket(s): 1
   NUMA node(s):  1
   Vendor ID: GenuineIntel
   CPU family:6
   Model: 79
   Model name:Intel(R) Xeon(R) CPU E5-2686 v4 @ 2.30GHz
   Stepping:  1
   CPU MHz:   2709.117
   BogoMIPS:  4600.14
   Hypervisor vendor: Xen
   Virtualization type:   full
   L1d cache: 32K
   L1i cache: 32K
   L2 cache:  256K
   L3 cache:  46080K
   NUMA node0 CPU(s): 0-31
   --Network Test--
   Setting timeout: 10
   Timing for MXNet: https://github.com/apache/incubator-mxnet, DNS: 0.0016 
sec, LOAD: 0.5764 sec.
   Timing for PYPI: https://pypi.python.org/pypi/pip, DNS: 0.0019 sec, LOAD: 
0.3843 sec.
   Timing for FashionMNIST: 
https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/gluon/dataset/fashion-mnist/train-labels-idx1-ubyte.gz,
 DNS: 0.0115 sec, LOAD: 0.1455 sec.
   Timing for Conda: https://repo.continuum.io/pkgs/free/, DNS: 0.0112 sec, 
LOAD: 0.1902 sec.
   Timing for Gluon Tutorial(en): http://gluon.mxnet.io, DNS: 0.1908 sec, LOAD: 
0.0881 sec.
   Timing for Gluon Tutorial(cn): https://zh.gluon.ai, DNS: 0.1898 sec, LOAD: 
0.0980 sec.
   --Environment--
   ```
   
   Package used (Python/R/Scala/Julia): Python27 and Python36
   
   ## Error Message:
   ```
   [08:08:56] src/operator/contrib/../tensor/./../../common/utils.h:463:
   Storage type fallback detected:
   operator = norm
   input storage types = [csr, ]
   output storage types = [default, ]
   params = {}
   context.dev_mask = gpu
   The operator with default storage type will be dispatched for execution. 
You're seeing this warning message because the operator above is unable to 
process the given ndarrays with specified storage types, context and parameter. 
Temporary dense ndarrays are generated in order to execute the operator. This 
does not affect the correctness of the programme. You can set environment 
variable MXNET_STORAGE_FALLBACK_LOG_VERBOSE to 0 to suppress this warning.
   Out[3]:
   
   [0.]
   
   ```
   
   ## Minimum reproducible example
   ```
   import mxnet as mx
   data = mx.nd.sparse.csr_matrix((3,4), ctx=mx.gpu())
   data.norm()
   ```
   
   ## Steps to reproduce
   (Paste the commands you ran that produced the error.)
   
   1. The function works in mxnet-cu100mkl==1.4.1 (no warning is generated)
   2. The function fails in mxnet-cu100mkl==1.5.0 and nightly build.
   
   ## What have you tried to solve it?
   Downgrade
   1.
   2.
   


[GitHub] [incubator-mxnet] mxnet-label-bot commented on issue #16060: [bug] mxnet.ndarray.sparse.norm fallback regression in 1.5.0 and master

2019-09-01 Thread GitBox
mxnet-label-bot commented on issue #16060: [bug] mxnet.ndarray.sparse.norm 
fallback regression in 1.5.0 and master
URL: 
https://github.com/apache/incubator-mxnet/issues/16060#issuecomment-526897834
 
 
   Hey, this is the MXNet Label Bot. 
Thank you for submitting the issue! I will try and suggest some labels so 
that the appropriate MXNet community members can help resolve it. 
Here are my recommended label(s): Bug


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-09-01 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository.

marcoabreu pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new e1cfcb3  Bump the publish timestamp.
e1cfcb3 is described below

commit e1cfcb3b88f1dc20e7ce5b6a65ce61001b30c386
Author: mxnet-ci 
AuthorDate: Sun Sep 1 07:34:26 2019 +

Bump the publish timestamp.
---
 date.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/date.txt b/date.txt
new file mode 100644
index 000..3585d0c
--- /dev/null
+++ b/date.txt
@@ -0,0 +1 @@
+Sun Sep  1 07:34:26 UTC 2019



[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #16037: LSTM with MKL-DNN produces wrong output after weights are changed

2019-09-01 Thread GitBox
pengzhao-intel commented on issue #16037: LSTM with MKL-DNN produces wrong 
output after weights are changed
URL: 
https://github.com/apache/incubator-mxnet/issues/16037#issuecomment-526891139
 
 
   @matteosal thanks to reporting the issues which are really helpful.
   Would you mind introducing some background of how your organizations are 
using MKL-DNN so that we can have better supports or more cooperations?
   My official email: patric.z...@intel.com


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services