[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17902: [mkldnn] optimize for mkldnn batchnorm backward
mxnet-bot commented on issue #17902: [mkldnn] optimize for mkldnn batchnorm backward URL: https://github.com/apache/incubator-mxnet/pull/17902#issuecomment-603655604 Jenkins CI successfully triggered : [clang, centos-gpu, unix-gpu, sanity, unix-cpu, website, centos-cpu, edge, miscellaneous, windows-cpu, windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] rongzha1 commented on issue #17902: [mkldnn] optimize for mkldnn batchnorm backward
rongzha1 commented on issue #17902: [mkldnn] optimize for mkldnn batchnorm backward URL: https://github.com/apache/incubator-mxnet/pull/17902#issuecomment-60366 @mxnet-bot run ci [all] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] wuxun-zhang commented on a change in pull request #17884: [MKL-DNN] Integrate Conv3d and Pool3d/1d
wuxun-zhang commented on a change in pull request #17884: [MKL-DNN] Integrate
Conv3d and Pool3d/1d
URL: https://github.com/apache/incubator-mxnet/pull/17884#discussion_r397620390
##
File path: src/operator/nn/mkldnn/mkldnn_base-inl.h
##
@@ -153,9 +153,8 @@ static inline bool SupportMKLDNN(int dtype, const
mxnet::TShape ) {
// MKLDNN currently does not support 0-dim Tensor and 0-size Tensor
return false;
}
-
return (dtype == mshadow::kFloat32 || dtype == mshadow::kBfloat16) &&
- (ndim == 1 || ndim == 2 || ndim == 4);
+(ndim >= 1 && ndim <= 5);
Review comment:
Maybe it's better not to touch this function. I will enable 5d layout in
`SupportPooling` instead.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] wuxun-zhang commented on a change in pull request #17884: [MKL-DNN] Integrate Conv3d and Pool3d/1d
wuxun-zhang commented on a change in pull request #17884: [MKL-DNN] Integrate
Conv3d and Pool3d/1d
URL: https://github.com/apache/incubator-mxnet/pull/17884#discussion_r397620361
##
File path: src/operator/nn/mkldnn/mkldnn_pooling-inl.h
##
@@ -114,15 +115,21 @@ inline bool SupportMKLDNNPooling(const PoolingParam
,
return true;
} else {
if (param.pool_type == pool_enum::kAvgPooling) {
- CHECK_EQ(dshape.ndim(), 4);
+ CHECK(dshape.ndim() == 3 || dshape.ndim() == 4 || dshape.ndim() == 5);
// mkldnn works differently when padding is asymmetric, so let's skip
this case.
- if (param.pad[0] == GetPaddingSizeFull(dshape[2], param.pad[0],
param.pad[0], param.kernel[0],
- param.stride[0]) &&
- param.pad[1] == GetPaddingSizeFull(dshape[3], param.pad[1],
param.pad[1], param.kernel[1],
- param.stride[1])) {
-return true;
+ bool is_symmetric = true;
+ switch (dshape.ndim()) {
+case 5:
+ is_symmetric = is_symmetric && (param.pad[2] ==
GetPaddingSizeFull(dshape[4],
+param.pad[2], param.pad[2], param.kernel[2],
param.stride[2]));
+case 4:
+ is_symmetric = is_symmetric && (param.pad[1] ==
GetPaddingSizeFull(dshape[3],
+param.pad[1], param.pad[1], param.kernel[1],
param.stride[1]));
Review comment:
Could you please show me where you saw these checks? Thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] wuxun-zhang commented on a change in pull request #17884: [MKL-DNN] Integrate Conv3d and Pool3d/1d
wuxun-zhang commented on a change in pull request #17884: [MKL-DNN] Integrate
Conv3d and Pool3d/1d
URL: https://github.com/apache/incubator-mxnet/pull/17884#discussion_r397620385
##
File path: src/operator/nn/mkldnn/mkldnn_base-inl.h
##
@@ -324,20 +323,27 @@ inline static mkldnn::memory::desc GetWeightDesc(const
NDArray ,
if (num_groups == 1) {
return GetMemDesc(arr, dtype);
} else {
-auto ndim = arr.shape().ndim();
-CHECK((ndim == 3) || (ndim == 4))
-<< "MKL-DNN weight currectly supports 3d and 4d layout";
+const auto ndim = arr.shape().ndim();
+CHECK((ndim == 3) || (ndim == 4) || (ndim == 5))
+<< "MKL-DNN weight currently supports 3d or 4d or 5d layout";
auto tz = mkldnn::memory::dims{0};
-const int N = 0, H = 2, W = 3, C = 1;
-if (ndim == 3) {
- tz = mkldnn::memory::dims{
- num_groups, static_cast(arr.shape()[N] / num_groups),
- static_cast(arr.shape()[C]), static_cast(arr.shape()[H])};
-} else {
- tz = mkldnn::memory::dims{
- num_groups, static_cast(arr.shape()[N] / num_groups),
- static_cast(arr.shape()[C]), static_cast(arr.shape()[H]),
- static_cast(arr.shape()[W])};
+const int D = (ndim == 5) ? 2 : 1;
+const int N = 0, C = 1, H = D + 1, W = D + 2;
Review comment:
Thanks. Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17711: [ONNX export] Fixing spatial export for batchnorm
mxnet-bot commented on issue #17711: [ONNX export] Fixing spatial export for batchnorm URL: https://github.com/apache/incubator-mxnet/pull/17711#issuecomment-603651502 Jenkins CI successfully triggered : [windows-gpu, unix-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on issue #17711: [ONNX export] Fixing spatial export for batchnorm
sandeep-krishnamurthy commented on issue #17711: [ONNX export] Fixing spatial export for batchnorm URL: https://github.com/apache/incubator-mxnet/pull/17711#issuecomment-603651478 @mxnet-bot run ci [unix-gpu, windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17869: [Numpy] FFI for einsum, dstack, unique
mxnet-bot commented on issue #17869: [Numpy] FFI for einsum, dstack, unique URL: https://github.com/apache/incubator-mxnet/pull/17869#issuecomment-603650101 Jenkins CI successfully triggered : [unix-cpu, unix-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] haojin2 commented on issue #17869: [Numpy] FFI for einsum, dstack, unique
haojin2 commented on issue #17869: [Numpy] FFI for einsum, dstack, unique URL: https://github.com/apache/incubator-mxnet/pull/17869#issuecomment-603650052 @mxnet-bot run ci [unix-cpu, unix-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] TaoLv commented on a change in pull request #17902: [mkldnn] optimize for mkldnn batchnorm backward
TaoLv commented on a change in pull request #17902: [mkldnn] optimize for mkldnn batchnorm backward URL: https://github.com/apache/incubator-mxnet/pull/17902#discussion_r397616691 ## File path: src/operator/nn/mkldnn/mkldnn_batch_norm-inl.h ## @@ -180,9 +180,10 @@ void MKLDNNBatchNormForward(const nnvm::NodeAttrs , const OpContext , CHECK(weight_mem.get_desc().get_size() == channels_ * sizeof(float) * 2); float* weight_ptr = gamma.data().dptr(); float* bias_ptr = beta.data().dptr(); +size_t copy_size = sizeof(weight_buf[0]) * channels_; Review comment: const? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] TaoLv commented on a change in pull request #17902: [mkldnn] optimize for mkldnn batchnorm backward
TaoLv commented on a change in pull request #17902: [mkldnn] optimize for
mkldnn batchnorm backward
URL: https://github.com/apache/incubator-mxnet/pull/17902#discussion_r397616952
##
File path: src/operator/nn/mkldnn/mkldnn_batch_norm-inl.h
##
@@ -381,15 +383,17 @@ void MKLDNNBatchNormBackward(const nnvm::NodeAttrs
, const OpContext ,
// copy data from gradw_mem to in_grad[1] and in_grad[2]
DType *gw_buf = reinterpret_cast(bwd.GetGradw().get_data_handle());
-for (int i = 0; i < channels_; i++) {
- if (!param.fix_gamma)
-(in_grad[1].data().dptr())[i] = gw_buf[i];
- else
-(in_grad[1].data().dptr())[i] = 0.0f;
-}
+DType *w_grad_1 = reinterpret_cast(in_grad[1].data().dptr());
+DType *w_grad_2 = reinterpret_cast(in_grad[2].data().dptr());
Review comment:
Same here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] TaoLv commented on a change in pull request #17902: [mkldnn] optimize for mkldnn batchnorm backward
TaoLv commented on a change in pull request #17902: [mkldnn] optimize for
mkldnn batchnorm backward
URL: https://github.com/apache/incubator-mxnet/pull/17902#discussion_r397616867
##
File path: src/operator/nn/mkldnn/mkldnn_batch_norm-inl.h
##
@@ -332,17 +333,18 @@ void MKLDNNBatchNormBackward(const nnvm::NodeAttrs
, const OpContext ,
const NDArray = in_data[batchnorm::kBeta];
DType *weight_buf = reinterpret_cast(bwd.GetWeight().get_data_handle());
nnvm::dim_t channels_ = data.shape()[1];
-for (int i = 0; i < channels_; i++) {
- if (!param.fix_gamma)
-weight_buf[i] = (gamma.data().dptr())[i]; // weight
- else
+DType *weight_ptr = reinterpret_cast(gamma.data().dptr());
+DType* bias_ptr = reinterpret_cast(beta.data().dptr());
Review comment:
It seems `reinterpret_cast` is not needed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17902: [mkldnn] optimize for mkldnn batchnorm backward
mxnet-bot commented on issue #17902: [mkldnn] optimize for mkldnn batchnorm backward URL: https://github.com/apache/incubator-mxnet/pull/17902#issuecomment-603646222 Undefined action detected. Permissible actions are : run ci [all], run ci [job1, job2] Example : @mxnet-bot run ci [all] Example : @mxnet-bot run ci [centos-cpu, clang] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] rongzha1 commented on issue #17902: [mkldnn] optimize for mkldnn batchnorm backward
rongzha1 commented on issue #17902: [mkldnn] optimize for mkldnn batchnorm backward URL: https://github.com/apache/incubator-mxnet/pull/17902#issuecomment-603646209 @mxnet-bot run ci windows-gpu This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] sjtuWangDing commented on issue #17795: [Numpy] FFI for linalg ops
sjtuWangDing commented on issue #17795: [Numpy] FFI for linalg ops URL: https://github.com/apache/incubator-mxnet/pull/17795#issuecomment-603640196 @mxnet-bot run ci [centos-cpu, windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17795: [Numpy] FFI for linalg ops
mxnet-bot commented on issue #17795: [Numpy] FFI for linalg ops URL: https://github.com/apache/incubator-mxnet/pull/17795#issuecomment-603640232 Jenkins CI successfully triggered : [windows-gpu, centos-cpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] sjtuWangDing removed a comment on issue #17795: [Numpy] FFI for linalg ops
sjtuWangDing removed a comment on issue #17795: [Numpy] FFI for linalg ops URL: https://github.com/apache/incubator-mxnet/pull/17795#issuecomment-603639967 run ci [centos-cpu, windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] sjtuWangDing commented on issue #17795: [Numpy] FFI for linalg ops
sjtuWangDing commented on issue #17795: [Numpy] FFI for linalg ops URL: https://github.com/apache/incubator-mxnet/pull/17795#issuecomment-603639967 run ci [centos-cpu, windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] Tommliu commented on issue #17897: [Numpy] FFI: atleast_1/2/3d
Tommliu commented on issue #17897: [Numpy] FFI: atleast_1/2/3d URL: https://github.com/apache/incubator-mxnet/pull/17897#issuecomment-603636058 @mxnet-bot run ci [windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17897: [Numpy] FFI: atleast_1/2/3d
mxnet-bot commented on issue #17897: [Numpy] FFI: atleast_1/2/3d URL: https://github.com/apache/incubator-mxnet/pull/17897#issuecomment-603636077 Jenkins CI successfully triggered : [windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17873: [Numpy] FFI: array_split, v/h/dsplit
mxnet-bot commented on issue #17873: [Numpy] FFI: array_split, v/h/dsplit URL: https://github.com/apache/incubator-mxnet/pull/17873#issuecomment-603635998 Jenkins CI successfully triggered : [windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] Tommliu commented on issue #17824: [Numpy] FFI: max/min/amax/amin
Tommliu commented on issue #17824: [Numpy] FFI: max/min/amax/amin URL: https://github.com/apache/incubator-mxnet/pull/17824#issuecomment-603635902 @mxnet-bot run ci [windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] Tommliu commented on issue #17793: [Numpy] OP_interp
Tommliu commented on issue #17793: [Numpy] OP_interp URL: https://github.com/apache/incubator-mxnet/pull/17793#issuecomment-603635809 @mxnet-bot run ci [windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17793: [Numpy] OP_interp
mxnet-bot commented on issue #17793: [Numpy] OP_interp URL: https://github.com/apache/incubator-mxnet/pull/17793#issuecomment-603635844 Jenkins CI successfully triggered : [windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] Tommliu commented on issue #17873: [Numpy] FFI: array_split, v/h/dsplit
Tommliu commented on issue #17873: [Numpy] FFI: array_split, v/h/dsplit URL: https://github.com/apache/incubator-mxnet/pull/17873#issuecomment-603635980 @mxnet-bot run ci [windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17824: [Numpy] FFI: max/min/amax/amin
mxnet-bot commented on issue #17824: [Numpy] FFI: max/min/amax/amin URL: https://github.com/apache/incubator-mxnet/pull/17824#issuecomment-603635923 Jenkins CI successfully triggered : [windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] hanke580 removed a comment on issue #17857: [Numpy] FFI: sort, argsort, vstack
hanke580 removed a comment on issue #17857: [Numpy] FFI: sort, argsort, vstack URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-603244907 @mxnet-bot run ci [windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17857: [Numpy] FFI: sort, argsort, vstack
mxnet-bot commented on issue #17857: [Numpy] FFI: sort, argsort, vstack URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-603627998 Jenkins CI successfully triggered : [windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] hanke580 commented on issue #17857: [Numpy] FFI: sort, argsort, vstack
hanke580 commented on issue #17857: [Numpy] FFI: sort, argsort, vstack URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-603627959 @mxnet-bot run ci [windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] vexilligera commented on a change in pull request #17808: [WIP] Windows dev environment configuration, update install instructions from source in the docs
vexilligera commented on a change in pull request #17808: [WIP] Windows dev
environment configuration, update install instructions from source in the docs
URL: https://github.com/apache/incubator-mxnet/pull/17808#discussion_r397595244
##
File path: ci/windows_dev_env/windows_deps_headless_installer.py
##
@@ -0,0 +1,429 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+"""Dependency installer for Windows"""
+
+__author__ = 'Pedro Larroy, Chance Bair'
+__version__ = '0.2'
+
+import argparse
+import errno
+import logging
+import os
+import psutil
+import shutil
+import subprocess
+import urllib
+import stat
+import tempfile
+import zipfile
+from time import sleep
+from urllib.error import HTTPError
+import logging
+from subprocess import check_output, check_call, call
+import re
+import sys
+import urllib.request
+import contextlib
+
+import ssl
+
+ssl._create_default_https_context = ssl._create_unverified_context
+
+log = logging.getLogger(__name__)
+
+
+DEPS = {
+'openblas':
'https://windows-post-install.s3-us-west-2.amazonaws.com/OpenBLAS-windows-v0_2_19.zip',
+'opencv':
'https://windows-post-install.s3-us-west-2.amazonaws.com/opencv-windows-4.1.2-vc14_vc15.zip',
+'cudnn':
'https://windows-post-install.s3-us-west-2.amazonaws.com/cudnn-9.2-windows10-x64-v7.4.2.24.zip',
+'nvdriver':
'https://windows-post-install.s3-us-west-2.amazonaws.com/nvidia_display_drivers_398.75_server2016.zip',
+'perl':
'http://strawberryperl.com/download/5.30.1.1/strawberry-perl-5.30.1.1-64bit.msi',
+'clang':
'https://github.com/llvm/llvm-project/releases/download/llvmorg-9.0.1/LLVM-9.0.1-win64.exe',
+# This installation of CMake breaks windows PATH when executing vcvars,
installing from
+# chocolatey from powershell instead.
+'cmake':
'https://github.com/Kitware/CMake/releases/download/v3.16.2/cmake-3.16.2-win64-x64.msi'
+}
+
+DEFAULT_SUBPROCESS_TIMEOUT = 3600
+
+
+@contextlib.contextmanager
+def remember_cwd():
+'''
+Restore current directory when exiting context
+'''
+curdir = os.getcwd()
+try:
+yield
+finally:
+os.chdir(curdir)
+
+
+def retry(target_exception, tries=4, delay_s=1, backoff=2):
+"""Retry calling the decorated function using an exponential backoff.
+
+http://www.saltycrane.com/blog/2009/11/trying-out-retry-decorator-python/
+original from: http://wiki.python.org/moin/PythonDecoratorLibrary#Retry
+
+:param target_exception: the exception to check. may be a tuple of
+exceptions to check
+:type target_exception: Exception or tuple
+:param tries: number of times to try (not retry) before giving up
+:type tries: int
+:param delay_s: initial delay between retries in seconds
+:type delay_s: int
+:param backoff: backoff multiplier e.g. value of 2 will double the delay
+each retry
+:type backoff: int
+"""
+import time
+from functools import wraps
+
+def decorated_retry(f):
+@wraps(f)
+def f_retry(*args, **kwargs):
+mtries, mdelay = tries, delay_s
+while mtries > 1:
+try:
+return f(*args, **kwargs)
+except target_exception as e:
+logging.warning("Exception: %s, Retrying in %d
seconds...", str(e), mdelay)
+time.sleep(mdelay)
+mtries -= 1
+mdelay *= backoff
+return f(*args, **kwargs)
+
+return f_retry # true decorator
+
+return decorated_retry
+
+
+@retry((ValueError, OSError, HTTPError), tries=5, delay_s=2, backoff=5)
+def download(url, dest=None, progress=False) -> str:
+from urllib.request import urlopen
+from urllib.parse import (urlparse, urlunparse)
+import progressbar
+import http.client
+
+class ProgressCB():
+def __init__(self):
+self.pbar = None
+
+def __call__(self, block_num, block_size, total_size):
+if not self.pbar and total_size > 0:
+self.pbar = progressbar.bar.ProgressBar(max_value=total_size)
+downloaded = block_num * block_size
+if self.pbar:
+if downloaded < total_size:
+
[GitHub] [incubator-mxnet] vexilligera commented on a change in pull request #17808: [WIP] Windows dev environment configuration, update install instructions from source in the docs
vexilligera commented on a change in pull request #17808: [WIP] Windows dev
environment configuration, update install instructions from source in the docs
URL: https://github.com/apache/incubator-mxnet/pull/17808#discussion_r397595136
##
File path: ci/windows_dev_env/windows_deps_headless_installer.py
##
@@ -0,0 +1,429 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+"""Dependency installer for Windows"""
+
+__author__ = 'Pedro Larroy, Chance Bair'
+__version__ = '0.2'
+
+import argparse
+import errno
+import logging
+import os
+import psutil
+import shutil
+import subprocess
+import urllib
+import stat
+import tempfile
+import zipfile
+from time import sleep
+from urllib.error import HTTPError
+import logging
+from subprocess import check_output, check_call, call
+import re
+import sys
+import urllib.request
+import contextlib
+
+import ssl
+
+ssl._create_default_https_context = ssl._create_unverified_context
+
+log = logging.getLogger(__name__)
+
+
+DEPS = {
+'openblas':
'https://windows-post-install.s3-us-west-2.amazonaws.com/OpenBLAS-windows-v0_2_19.zip',
+'opencv':
'https://windows-post-install.s3-us-west-2.amazonaws.com/opencv-windows-4.1.2-vc14_vc15.zip',
+'cudnn':
'https://windows-post-install.s3-us-west-2.amazonaws.com/cudnn-9.2-windows10-x64-v7.4.2.24.zip',
+'nvdriver':
'https://windows-post-install.s3-us-west-2.amazonaws.com/nvidia_display_drivers_398.75_server2016.zip',
+'perl':
'http://strawberryperl.com/download/5.30.1.1/strawberry-perl-5.30.1.1-64bit.msi',
+'clang':
'https://github.com/llvm/llvm-project/releases/download/llvmorg-9.0.1/LLVM-9.0.1-win64.exe',
+# This installation of CMake breaks windows PATH when executing vcvars,
installing from
+# chocolatey from powershell instead.
+'cmake':
'https://github.com/Kitware/CMake/releases/download/v3.16.2/cmake-3.16.2-win64-x64.msi'
+}
+
+DEFAULT_SUBPROCESS_TIMEOUT = 3600
+
+
+@contextlib.contextmanager
+def remember_cwd():
+'''
+Restore current directory when exiting context
+'''
+curdir = os.getcwd()
+try:
+yield
+finally:
+os.chdir(curdir)
+
+
+def retry(target_exception, tries=4, delay_s=1, backoff=2):
+"""Retry calling the decorated function using an exponential backoff.
+
+http://www.saltycrane.com/blog/2009/11/trying-out-retry-decorator-python/
+original from: http://wiki.python.org/moin/PythonDecoratorLibrary#Retry
+
+:param target_exception: the exception to check. may be a tuple of
+exceptions to check
+:type target_exception: Exception or tuple
+:param tries: number of times to try (not retry) before giving up
+:type tries: int
+:param delay_s: initial delay between retries in seconds
+:type delay_s: int
+:param backoff: backoff multiplier e.g. value of 2 will double the delay
+each retry
+:type backoff: int
+"""
+import time
+from functools import wraps
+
+def decorated_retry(f):
+@wraps(f)
+def f_retry(*args, **kwargs):
+mtries, mdelay = tries, delay_s
+while mtries > 1:
+try:
+return f(*args, **kwargs)
+except target_exception as e:
+logging.warning("Exception: %s, Retrying in %d
seconds...", str(e), mdelay)
+time.sleep(mdelay)
+mtries -= 1
+mdelay *= backoff
+return f(*args, **kwargs)
+
+return f_retry # true decorator
+
+return decorated_retry
+
+
+@retry((ValueError, OSError, HTTPError), tries=5, delay_s=2, backoff=5)
+def download(url, dest=None, progress=False) -> str:
+from urllib.request import urlopen
+from urllib.parse import (urlparse, urlunparse)
+import progressbar
+import http.client
+
+class ProgressCB():
+def __init__(self):
+self.pbar = None
+
+def __call__(self, block_num, block_size, total_size):
+if not self.pbar and total_size > 0:
+self.pbar = progressbar.bar.ProgressBar(max_value=total_size)
+downloaded = block_num * block_size
+if self.pbar:
+if downloaded < total_size:
+
[GitHub] [incubator-mxnet] vexilligera commented on a change in pull request #17808: [WIP] Windows dev environment configuration, update install instructions from source in the docs
vexilligera commented on a change in pull request #17808: [WIP] Windows dev
environment configuration, update install instructions from source in the docs
URL: https://github.com/apache/incubator-mxnet/pull/17808#discussion_r397595002
##
File path: ci/windows_dev_env/windows_deps_headless_installer.py
##
@@ -0,0 +1,429 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+"""Dependency installer for Windows"""
+
+__author__ = 'Pedro Larroy, Chance Bair'
+__version__ = '0.2'
+
+import argparse
+import errno
+import logging
+import os
+import psutil
+import shutil
+import subprocess
+import urllib
+import stat
+import tempfile
+import zipfile
+from time import sleep
+from urllib.error import HTTPError
+import logging
+from subprocess import check_output, check_call, call
+import re
+import sys
+import urllib.request
+import contextlib
+
+import ssl
+
+ssl._create_default_https_context = ssl._create_unverified_context
+
+log = logging.getLogger(__name__)
+
+
+DEPS = {
+'openblas':
'https://windows-post-install.s3-us-west-2.amazonaws.com/OpenBLAS-windows-v0_2_19.zip',
+'opencv':
'https://windows-post-install.s3-us-west-2.amazonaws.com/opencv-windows-4.1.2-vc14_vc15.zip',
+'cudnn':
'https://windows-post-install.s3-us-west-2.amazonaws.com/cudnn-9.2-windows10-x64-v7.4.2.24.zip',
+'nvdriver':
'https://windows-post-install.s3-us-west-2.amazonaws.com/nvidia_display_drivers_398.75_server2016.zip',
Review comment:
I currently don't have access to windows-post-install, so I opened another
bucket (mxnet-windows-build). It would be easy to merge them.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] vexilligera commented on a change in pull request #17808: [WIP] Windows dev environment configuration, update install instructions from source in the docs
vexilligera commented on a change in pull request #17808: [WIP] Windows dev environment configuration, update install instructions from source in the docs URL: https://github.com/apache/incubator-mxnet/pull/17808#discussion_r397594701 ## File path: docs/static_site/src/pages/get_started/windows_setup.md ## @@ -137,126 +137,37 @@ Check the chart below for other options or refer to [PyPI for other MXNet pip pa ## Build from Source -**IMPORTANT: It is recommended that you review the [build from source guide](build_from_source) first.** It describes many of the build options that come with MXNet in more detail. You may decide to install additional dependencies and modify your build flags after reviewing this material. -We provide two primary options to build and install MXNet yourself using [Microsoft Visual Studio 2017](https://www.visualstudio.com/downloads/) or [Microsoft Visual Studio 2015](https://www.visualstudio.com/vs/older-downloads/). +For automated setting up of developer environment in windows, use script bundle from the + +folder. Copy to a local directory and execute: -**NOTE:** Visual Studio 2017's compiler is `vc15`. This is not to be confused with Visual Studio 2015's compiler, `vc14`. - -You also have the option to install MXNet with MKL or MKL-DNN. In this case it is recommended that you refer to the [MKLDNN_README](https://mxnet.apache.org/api/python/docs/tutorials/performance/backend/mkldnn/mkldnn_readme.html). - -**Option 1: Build with Microsoft Visual Studio 2017 (VS2017)** - -To build and install MXNet yourself using [VS2017](https://www.visualstudio.com/downloads/), you need the following dependencies. You may try a newer version of a particular dependency, but please open a pull request or [issue](https://github.com/apache/incubator-mxnet/issues/new) to update this guide if a newer version is validated. - -1. Install or update VS2017. -- If [VS2017](https://www.visualstudio.com/downloads/) is not already installed, download and install it. You can download and install the free community edition. -- When prompted about installing Git, go ahead and install it. -- If VS2017 is already installed you will want to update it. Proceed to the next step to modify your installation. You will be given the opportunity to update VS2017 as well -1. Follow the [instructions for opening the Visual Studio Installer](https://docs.microsoft.com/en-us/visualstudio/install/modify-visual-studio) to modify `Individual components`. -1. Once in the Visual Studio Installer application, update as needed, then look for and check `VC++ 2017 version 15.4 v14.11 toolset`, and click `Modify`. -1. Change the version of the Visual studio 2017 to v14.11 using the following command (by default the VS2017 is installed in the following path): -``` -"C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\vcvars64.bat" -vcvars_ver=14.11 -``` -1. Download and install [CMake](https://cmake.org/download) if it is not already installed. [CMake v3.12.2](https://cmake.org/files/v3.12/cmake-3.12.2-win64-x64.msi) has been tested with MXNet. -1. Download and run the [OpenCV](https://sourceforge.net/projects/opencvlibrary/files/opencv-win/3.4.1/opencv-3.4.1-vc14_vc15.exe/download) package. There are more recent versions of OpenCV, so please create an issue/PR to update this info if you validate one of these later versions. -1. This will unzip several files. You can place them in another directory if you wish. We will use `C:\utils`(```mkdir C:\utils```) as our default path. -1. Set the environment variable `OpenCV_DIR` to point to the OpenCV build directory that you just unzipped. Start ```cmd``` and type `set OpenCV_DIR=C:\utils\opencv\build`. -1. If you don’t have the Intel Math Kernel Library (MKL) installed, you can install it and follow the [MKLDNN_README](https://mxnet.apache.org/api/python/docs/tutorials/performance/backend/mkldnn/mkldnn_readme.html) from here, or you can use OpenBLAS. These instructions will assume you're using OpenBLAS. -1. Download the [OpenBlas](https://sourceforge.net/projects/openblas/files/v0.2.19/OpenBLAS-v0.2.19-Win64-int32.zip/download) package. Later versions of OpenBLAS are available, but you would need to build from source. v0.2.19 is the most recent version that ships with binaries. Contributions of more recent binaries would be appreciated. -1. Unzip the file, rename it to ```OpenBLAS``` and put it under `C:\utils`. You can place the unzipped files and folders in another directory if you wish. -1. Set the environment variable `OpenBLAS_HOME` to point to the OpenBLAS directory that contains the `include` and `lib` directories and type `set OpenBLAS_HOME=C:\utils\OpenBLAS` on the command prompt(```cmd```). -1. Download and install
[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17896: [Numpy] FFI: random.shuffle, equal, not_equal, less_equal, greater_equal, less, maximum and minimum
hzfan commented on a change in pull request #17896: [Numpy] FFI:
random.shuffle, equal, not_equal, less_equal, greater_equal, less, maximum and
minimum
URL: https://github.com/apache/incubator-mxnet/pull/17896#discussion_r397589612
##
File path: src/api/operator/numpy/np_elemwise_broadcast_logic_op.cc
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file np_elemwise_broadcast_logic_op.cc
+ * \brief Implementation of the API of functions in
src/operator/numpy/np_elemwise_broadcast_logic_op.cc
+ */
+#include
+#include
+#include "../utils.h"
+#include "../ufunc_helper.h"
+
+namespace mxnet {
+
+MXNET_REGISTER_API("_npi.equal")
+.set_body([](runtime::MXNetArgs args, runtime::MXNetRetValue* ret) {
+ using namespace runtime;
+ const nnvm::Op* op = Op::Get("_npi_equal");
+ const nnvm::Op* op_scalar = Op::Get("_npi_equal_scalar");
+ UFuncHelper(args, ret, op, op_scalar, nullptr);
+});
+
+MXNET_REGISTER_API("_npi.not_equal")
+.set_body([](runtime::MXNetArgs args, runtime::MXNetRetValue* ret) {
+ using namespace runtime;
+ const nnvm::Op* op = Op::Get("_npi_not_equal");
+ const nnvm::Op* op_scalar = Op::Get("_npi_not_equal_scalar");
+ UFuncHelper(args, ret, op, op_scalar, nullptr);
+});
+
+MXNET_REGISTER_API("_npi.less")
+.set_body([](runtime::MXNetArgs args, runtime::MXNetRetValue* ret) {
+ using namespace runtime;
+ const nnvm::Op* op = Op::Get("_npi_less");
+ const nnvm::Op* op_scalar = Op::Get("_npi_less_scalar");
+ UFuncHelper(args, ret, op, op_scalar, nullptr);
+});
+
+MXNET_REGISTER_API("_npi.greater_equal")
+.set_body([](runtime::MXNetArgs args, runtime::MXNetRetValue* ret) {
+ using namespace runtime;
+ const nnvm::Op* op = Op::Get("_npi_greater_equal");
+ const nnvm::Op* op_scalar = Op::Get("_npi_greater_equal_scalar");
+ UFuncHelper(args, ret, op, op_scalar, nullptr);
Review comment:
Same.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17896: [Numpy] FFI: random.shuffle, equal, not_equal, less_equal, greater_equal, less, maximum and minimum
hzfan commented on a change in pull request #17896: [Numpy] FFI:
random.shuffle, equal, not_equal, less_equal, greater_equal, less, maximum and
minimum
URL: https://github.com/apache/incubator-mxnet/pull/17896#discussion_r397589628
##
File path: src/api/operator/numpy/np_elemwise_broadcast_logic_op.cc
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file np_elemwise_broadcast_logic_op.cc
+ * \brief Implementation of the API of functions in
src/operator/numpy/np_elemwise_broadcast_logic_op.cc
+ */
+#include
+#include
+#include "../utils.h"
+#include "../ufunc_helper.h"
+
+namespace mxnet {
+
+MXNET_REGISTER_API("_npi.equal")
+.set_body([](runtime::MXNetArgs args, runtime::MXNetRetValue* ret) {
+ using namespace runtime;
+ const nnvm::Op* op = Op::Get("_npi_equal");
+ const nnvm::Op* op_scalar = Op::Get("_npi_equal_scalar");
+ UFuncHelper(args, ret, op, op_scalar, nullptr);
+});
+
+MXNET_REGISTER_API("_npi.not_equal")
+.set_body([](runtime::MXNetArgs args, runtime::MXNetRetValue* ret) {
+ using namespace runtime;
+ const nnvm::Op* op = Op::Get("_npi_not_equal");
+ const nnvm::Op* op_scalar = Op::Get("_npi_not_equal_scalar");
+ UFuncHelper(args, ret, op, op_scalar, nullptr);
+});
+
+MXNET_REGISTER_API("_npi.less")
+.set_body([](runtime::MXNetArgs args, runtime::MXNetRetValue* ret) {
+ using namespace runtime;
+ const nnvm::Op* op = Op::Get("_npi_less");
+ const nnvm::Op* op_scalar = Op::Get("_npi_less_scalar");
+ UFuncHelper(args, ret, op, op_scalar, nullptr);
+});
+
+MXNET_REGISTER_API("_npi.greater_equal")
+.set_body([](runtime::MXNetArgs args, runtime::MXNetRetValue* ret) {
+ using namespace runtime;
+ const nnvm::Op* op = Op::Get("_npi_greater_equal");
+ const nnvm::Op* op_scalar = Op::Get("_npi_greater_equal_scalar");
+ UFuncHelper(args, ret, op, op_scalar, nullptr);
+});
+
+MXNET_REGISTER_API("_npi.less_equal")
+.set_body([](runtime::MXNetArgs args, runtime::MXNetRetValue* ret) {
+ using namespace runtime;
+ const nnvm::Op* op = Op::Get("_npi_less_equal");
+ const nnvm::Op* op_scalar = Op::Get("_npi_less_equal_scalar");
+ UFuncHelper(args, ret, op, op_scalar, nullptr);
Review comment:
Same
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17896: [Numpy] FFI: random.shuffle, equal, not_equal, less_equal, greater_equal, less, maximum and minimum
hzfan commented on a change in pull request #17896: [Numpy] FFI:
random.shuffle, equal, not_equal, less_equal, greater_equal, less, maximum and
minimum
URL: https://github.com/apache/incubator-mxnet/pull/17896#discussion_r397589565
##
File path: src/api/operator/numpy/np_elemwise_broadcast_logic_op.cc
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file np_elemwise_broadcast_logic_op.cc
+ * \brief Implementation of the API of functions in
src/operator/numpy/np_elemwise_broadcast_logic_op.cc
+ */
+#include
+#include
+#include "../utils.h"
+#include "../ufunc_helper.h"
+
+namespace mxnet {
+
+MXNET_REGISTER_API("_npi.equal")
+.set_body([](runtime::MXNetArgs args, runtime::MXNetRetValue* ret) {
+ using namespace runtime;
+ const nnvm::Op* op = Op::Get("_npi_equal");
+ const nnvm::Op* op_scalar = Op::Get("_npi_equal_scalar");
+ UFuncHelper(args, ret, op, op_scalar, nullptr);
+});
+
+MXNET_REGISTER_API("_npi.not_equal")
+.set_body([](runtime::MXNetArgs args, runtime::MXNetRetValue* ret) {
+ using namespace runtime;
+ const nnvm::Op* op = Op::Get("_npi_not_equal");
+ const nnvm::Op* op_scalar = Op::Get("_npi_not_equal_scalar");
+ UFuncHelper(args, ret, op, op_scalar, nullptr);
+});
+
+MXNET_REGISTER_API("_npi.less")
+.set_body([](runtime::MXNetArgs args, runtime::MXNetRetValue* ret) {
+ using namespace runtime;
+ const nnvm::Op* op = Op::Get("_npi_less");
+ const nnvm::Op* op_scalar = Op::Get("_npi_less_scalar");
+ UFuncHelper(args, ret, op, op_scalar, nullptr);
Review comment:
`less` is not commutative. Use the `op_rscalar` for the last argument
instead of `nullptr`
```
const nnvm::Op* op_rscalar = Op::Get("_npi_greater_equal_scalar");
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] hzfan commented on issue #17795: [Numpy] FFI for linalg ops
hzfan commented on issue #17795: [Numpy] FFI for linalg ops URL: https://github.com/apache/incubator-mxnet/pull/17795#issuecomment-603615012 @mxnet-bot run ci [centos-cpu, windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17795: [Numpy] FFI for linalg ops
mxnet-bot commented on issue #17795: [Numpy] FFI for linalg ops URL: https://github.com/apache/incubator-mxnet/pull/17795#issuecomment-603615030 Unauthorized access detected. Only following 3 categories can trigger CI : PR Author, MXNet Committer, Jenkins Admin. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] shimiaoli commented on issue #17867: Error C1002 encountered while building under windows
shimiaoli commented on issue #17867: Error C1002 encountered while building under windows URL: https://github.com/apache/incubator-mxnet/issues/17867#issuecomment-603609036 @yajiedesign Thank you. Yes. After changed to x64 native compiler, libmxnet.dll can be built. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] shimiaoli removed a comment on issue #17867: Error C1002 encountered while building under windows
shimiaoli removed a comment on issue #17867: Error C1002 encountered while building under windows URL: https://github.com/apache/incubator-mxnet/issues/17867#issuecomment-603608489 @yajiedesign Thank you. I found that VS Express 2015 does not have native x64 compiler. After I changed to VS Community 2015 and used the setting -T host=x64, libmxnet.dll can be built. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] shimiaoli commented on issue #17867: Error C1002 encountered while building under windows
shimiaoli commented on issue #17867: Error C1002 encountered while building under windows URL: https://github.com/apache/incubator-mxnet/issues/17867#issuecomment-603608489 @yajiedesign Thank you. I found that VS Express 2015 does not have native x64 compiler. After I changed to VS Community 2015 and used the setting -T host=x64, libmxnet.dll can be built. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17873: [Numpy] FFI: array_split, v/h/dsplit
mxnet-bot commented on issue #17873: [Numpy] FFI: array_split, v/h/dsplit URL: https://github.com/apache/incubator-mxnet/pull/17873#issuecomment-603602724 Jenkins CI successfully triggered : [windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] Tommliu commented on issue #17873: [Numpy] FFI: array_split, v/h/dsplit
Tommliu commented on issue #17873: [Numpy] FFI: array_split, v/h/dsplit URL: https://github.com/apache/incubator-mxnet/pull/17873#issuecomment-603602700 @mxnet-bot run ci [windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] Tommliu commented on issue #17897: [Numpy] FFI: atleast_1/2/3d
Tommliu commented on issue #17897: [Numpy] FFI: atleast_1/2/3d URL: https://github.com/apache/incubator-mxnet/pull/17897#issuecomment-603602797 @mxnet-bot run ci [windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17897: [Numpy] FFI: atleast_1/2/3d
mxnet-bot commented on issue #17897: [Numpy] FFI: atleast_1/2/3d URL: https://github.com/apache/incubator-mxnet/pull/17897#issuecomment-603602827 Jenkins CI successfully triggered : [windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17824: [Numpy] FFI: max/min/amax/amin
mxnet-bot commented on issue #17824: [Numpy] FFI: max/min/amax/amin URL: https://github.com/apache/incubator-mxnet/pull/17824#issuecomment-603602590 Jenkins CI successfully triggered : [windows-gpu, unix-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] Tommliu commented on issue #17824: [Numpy] FFI: max/min/amax/amin
Tommliu commented on issue #17824: [Numpy] FFI: max/min/amax/amin URL: https://github.com/apache/incubator-mxnet/pull/17824#issuecomment-603602555 @mxnet-bot run ci [unix-gpu, windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17793: [Numpy] OP_interp
mxnet-bot commented on issue #17793: [Numpy] OP_interp URL: https://github.com/apache/incubator-mxnet/pull/17793#issuecomment-603602219 Jenkins CI successfully triggered : [centos-gpu, windows-gpu, unix-cpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] Tommliu commented on issue #17793: [Numpy] OP_interp
Tommliu commented on issue #17793: [Numpy] OP_interp URL: https://github.com/apache/incubator-mxnet/pull/17793#issuecomment-603602177 @mxnet-bot run ci [centos-gpu, unix-cpu, windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] Tommliu removed a comment on issue #17793: [Numpy] OP_interp
Tommliu removed a comment on issue #17793: [Numpy] OP_interp URL: https://github.com/apache/incubator-mxnet/pull/17793#issuecomment-603601402 @mxnet-bot run ci [ci/jenkins/mxnet-validation/centos-gpu, ci/jenkins/mxnet-validation/unix-cpu, ci/jenkins/mxnet-validation/windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] Tommliu commented on issue #17793: [Numpy] OP_interp
Tommliu commented on issue #17793: [Numpy] OP_interp URL: https://github.com/apache/incubator-mxnet/pull/17793#issuecomment-603601402 @mxnet-bot run ci [ci/jenkins/mxnet-validation/centos-gpu, ci/jenkins/mxnet-validation/unix-cpu, ci/jenkins/mxnet-validation/windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17793: [Numpy] OP_interp
mxnet-bot commented on issue #17793: [Numpy] OP_interp URL: https://github.com/apache/incubator-mxnet/pull/17793#issuecomment-603601412 None of the jobs entered are supported. Jobs entered by user: [ci/jenkins/mxnet-validation/centos-gpu, ci/jenkins/mxnet-validation/unix-cpu, ci/jenkins/mxnet-validation/windows-gpu] CI supported Jobs: [clang, unix-cpu, sanity, edge, miscellaneous, windows-gpu, windows-cpu, unix-gpu, website, centos-gpu, centos-cpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ciyongch commented on issue #17872: Fix issue of zeros gradients w.r.t. RNN bias when num_layers > 1
ciyongch commented on issue #17872: Fix issue of zeros gradients w.r.t. RNN bias when num_layers > 1 URL: https://github.com/apache/incubator-mxnet/pull/17872#issuecomment-603599651 There's still some failure in fusedlstm tests. Please take a check. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] leezu opened a new issue #17903: CD pipeline broken
leezu opened a new issue #17903: CD pipeline broken URL: https://github.com/apache/incubator-mxnet/issues/17903 ## Description The CD pipeline may need to be updated based on the FFI work. Currently the CD fails with "AttributeError: module 'mxnet.ndarray.numpy._api_internal' has no attribute 'svd'" and other similar errors. http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/restricted-mxnet-cd%2Fmxnet-cd-release-job/detail/mxnet-cd-release-job/888/pipeline/#step-316-log-1271 cc @hzfan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] rongzha1 commented on a change in pull request #17902: [mkldnn] optimize for mkldnn batchnorm backward
rongzha1 commented on a change in pull request #17902: [mkldnn] optimize for
mkldnn batchnorm backward
URL: https://github.com/apache/incubator-mxnet/pull/17902#discussion_r397566437
##
File path: src/operator/nn/mkldnn/mkldnn_batch_norm-inl.h
##
@@ -381,15 +384,19 @@ void MKLDNNBatchNormBackward(const nnvm::NodeAttrs
, const OpContext ,
// copy data from gradw_mem to in_grad[1] and in_grad[2]
DType *gw_buf = reinterpret_cast(bwd.GetGradw().get_data_handle());
-for (int i = 0; i < channels_; i++) {
- if (!param.fix_gamma)
-(in_grad[1].data().dptr())[i] = gw_buf[i];
- else
-(in_grad[1].data().dptr())[i] = 0.0f;
-}
+DType *w_grad_1 = reinterpret_cast(in_grad[1].data().dptr());
+DType *w_grad_2 = reinterpret_cast(in_grad[2].data().dptr());
-for (int i = 0; i < channels_; i++) {
- (in_grad[2].data().dptr())[i] = gw_buf[i + channels_];
+if (!param.fix_gamma) {
+ memcpy(w_grad_1, gw_buf, copy_size);
+ memcpy(w_grad_2, _buf[channels_], copy_size);
+} else {
+ for (int i = 0; i < channels_; i++) {
+(in_grad[1].data().dptr())[i] = 0.0f;
+ }
+ for (int i = 0; i < channels_; i++) {
+(in_grad[2].data().dptr())[i] = gw_buf[i + channels_];
Review comment:
OK
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17902: [mkldnn] optimize for mkldnn batchnorm backward
mxnet-bot commented on issue #17902: [mkldnn] optimize for mkldnn batchnorm backward URL: https://github.com/apache/incubator-mxnet/pull/17902#issuecomment-603597133 Jenkins CI successfully triggered : [clang, unix-cpu, sanity, edge, miscellaneous, windows-gpu, windows-cpu, unix-gpu, website, centos-gpu, centos-cpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] rongzha1 commented on issue #17902: [mkldnn] optimize for mkldnn batchnorm backward
rongzha1 commented on issue #17902: [mkldnn] optimize for mkldnn batchnorm backward URL: https://github.com/apache/incubator-mxnet/pull/17902#issuecomment-603597051 @mxnet-bot run ci [all] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] rongzha1 commented on a change in pull request #17902: [mkldnn] optimize for mkldnn batchnorm backward
rongzha1 commented on a change in pull request #17902: [mkldnn] optimize for
mkldnn batchnorm backward
URL: https://github.com/apache/incubator-mxnet/pull/17902#discussion_r397566402
##
File path: src/operator/nn/mkldnn/mkldnn_batch_norm-inl.h
##
@@ -332,17 +332,20 @@ void MKLDNNBatchNormBackward(const nnvm::NodeAttrs
, const OpContext ,
const NDArray = in_data[batchnorm::kBeta];
DType *weight_buf = reinterpret_cast(bwd.GetWeight().get_data_handle());
nnvm::dim_t channels_ = data.shape()[1];
-for (int i = 0; i < channels_; i++) {
- if (!param.fix_gamma)
-weight_buf[i] = (gamma.data().dptr())[i]; // weight
- else
+DType *weight_ptr = reinterpret_cast(gamma.data().dptr());
+DType* bias_ptr = reinterpret_cast(beta.data().dptr());
+size_t copy_size = sizeof(DType) * channels_;
+if (!param.fix_gamma) {
+ memcpy(weight_buf, weight_ptr, copy_size);
+ memcpy(_buf[channels_], bias_ptr, copy_size);
+} else {
+ for (int i = 0; i < channels_; i++) {
weight_buf[i] = static_cast(1.0f);
+ }
+ for (int i = 0; i < channels_; i++) {
+weight_buf[channels_ + i] = (beta.data().dptr())[i]; // bias
Review comment:
OK
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ElaineBao commented on a change in pull request #17902: [mkldnn] optimize for mkldnn batchnorm backward
ElaineBao commented on a change in pull request #17902: [mkldnn] optimize for
mkldnn batchnorm backward
URL: https://github.com/apache/incubator-mxnet/pull/17902#discussion_r397558809
##
File path: src/operator/nn/mkldnn/mkldnn_batch_norm-inl.h
##
@@ -381,15 +384,19 @@ void MKLDNNBatchNormBackward(const nnvm::NodeAttrs
, const OpContext ,
// copy data from gradw_mem to in_grad[1] and in_grad[2]
DType *gw_buf = reinterpret_cast(bwd.GetGradw().get_data_handle());
-for (int i = 0; i < channels_; i++) {
- if (!param.fix_gamma)
-(in_grad[1].data().dptr())[i] = gw_buf[i];
- else
-(in_grad[1].data().dptr())[i] = 0.0f;
-}
+DType *w_grad_1 = reinterpret_cast(in_grad[1].data().dptr());
+DType *w_grad_2 = reinterpret_cast(in_grad[2].data().dptr());
-for (int i = 0; i < channels_; i++) {
- (in_grad[2].data().dptr())[i] = gw_buf[i + channels_];
+if (!param.fix_gamma) {
+ memcpy(w_grad_1, gw_buf, copy_size);
+ memcpy(w_grad_2, _buf[channels_], copy_size);
+} else {
+ for (int i = 0; i < channels_; i++) {
+(in_grad[1].data().dptr())[i] = 0.0f;
+ }
+ for (int i = 0; i < channels_; i++) {
+(in_grad[2].data().dptr())[i] = gw_buf[i + channels_];
Review comment:
Using `memcpy` as above.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ElaineBao commented on a change in pull request #17902: [mkldnn] optimize for mkldnn batchnorm backward
ElaineBao commented on a change in pull request #17902: [mkldnn] optimize for
mkldnn batchnorm backward
URL: https://github.com/apache/incubator-mxnet/pull/17902#discussion_r397558594
##
File path: src/operator/nn/mkldnn/mkldnn_batch_norm-inl.h
##
@@ -332,17 +332,20 @@ void MKLDNNBatchNormBackward(const nnvm::NodeAttrs
, const OpContext ,
const NDArray = in_data[batchnorm::kBeta];
DType *weight_buf = reinterpret_cast(bwd.GetWeight().get_data_handle());
nnvm::dim_t channels_ = data.shape()[1];
-for (int i = 0; i < channels_; i++) {
- if (!param.fix_gamma)
-weight_buf[i] = (gamma.data().dptr())[i]; // weight
- else
+DType *weight_ptr = reinterpret_cast(gamma.data().dptr());
+DType* bias_ptr = reinterpret_cast(beta.data().dptr());
+size_t copy_size = sizeof(DType) * channels_;
+if (!param.fix_gamma) {
+ memcpy(weight_buf, weight_ptr, copy_size);
+ memcpy(_buf[channels_], bias_ptr, copy_size);
+} else {
+ for (int i = 0; i < channels_; i++) {
weight_buf[i] = static_cast(1.0f);
+ }
+ for (int i = 0; i < channels_; i++) {
+weight_buf[channels_ + i] = (beta.data().dptr())[i]; // bias
Review comment:
Using `memcpy` as above
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17902: [mkldnn] optimize for mkldnn batchnorm backward
mxnet-bot commented on issue #17902: [mkldnn] optimize for mkldnn batchnorm backward URL: https://github.com/apache/incubator-mxnet/pull/17902#issuecomment-603585631 Jenkins CI successfully triggered : [centos-gpu, miscellaneous, sanity, edge, centos-cpu, windows-gpu, unix-gpu, clang, windows-cpu, unix-cpu, website] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] rongzha1 commented on issue #17902: [mkldnn] optimize for mkldnn batchnorm backward
rongzha1 commented on issue #17902: [mkldnn] optimize for mkldnn batchnorm backward URL: https://github.com/apache/incubator-mxnet/pull/17902#issuecomment-603585564 @mxnet-bot run ci [all] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] rongzha1 opened a new pull request #17902: [mkldnn] optimize for mkldnn batchnorm backward
rongzha1 opened a new pull request #17902: [mkldnn] optimize for mkldnn batchnorm backward URL: https://github.com/apache/incubator-mxnet/pull/17902 ## Description ## optimized for mkldnn bwd bn primitive. (time in mkldnn verbose)/OP_profile enhanced from 83% to 96%, image/s from 65.2 to 66.5 in resnet50 @TaoLv @ElaineBao @PatricZhao ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes) - [x] Changes are complete (i.e. I finished coding on this PR) - [ ] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [ ] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - [ ] Feature1, tests, (and when applicable, API doc) - [ ] Feature2, tests, (and when applicable, API doc) ## Comments ## - If this change is a backward incompatible change, why must this change be made. - Interesting edge cases to note here This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17902: [mkldnn] optimize for mkldnn batchnorm backward
mxnet-bot commented on issue #17902: [mkldnn] optimize for mkldnn batchnorm backward URL: https://github.com/apache/incubator-mxnet/pull/17902#issuecomment-603584969 Hey @rongzha1 , Thanks for submitting the PR Once your PR is ready for CI checks, invoke the following commands: - To trigger all jobs: @mxnet-bot run ci [all] - To trigger specific jobs: @mxnet-bot run ci [job1, job2] *** **CI supported jobs**: [centos-gpu, miscellaneous, sanity, edge, centos-cpu, windows-gpu, unix-gpu, clang, windows-cpu, unix-cpu, website] *** _Note_: Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. All CI tests must pass before the PR can be merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17796: Fix npx.softmax for 0-sized inputs
mxnet-bot commented on issue #17796: Fix npx.softmax for 0-sized inputs URL: https://github.com/apache/incubator-mxnet/pull/17796#issuecomment-603581715 Jenkins CI successfully triggered : [windows-gpu, unix-cpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] haojin2 commented on issue #17796: Fix npx.softmax for 0-sized inputs
haojin2 commented on issue #17796: Fix npx.softmax for 0-sized inputs URL: https://github.com/apache/incubator-mxnet/pull/17796#issuecomment-603581684 @mxnet-bot run ci [unix-cpu, windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17801: Add a bot to manually trigger CI builds for PR
ChaiBapchya commented on issue #17801: Add a bot to manually trigger CI builds for PR URL: https://github.com/apache/incubator-mxnet/issues/17801#issuecomment-603580793 Lol doesn't work with issues! Will filter for those :p This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] marcoabreu commented on issue #17801: Add a bot to manually trigger CI builds for PR
marcoabreu commented on issue #17801: Add a bot to manually trigger CI builds for PR URL: https://github.com/apache/incubator-mxnet/issues/17801#issuecomment-603580327 @mxnet-blt run ci all This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] marcoabreu commented on issue #17801: Add a bot to manually trigger CI builds for PR
marcoabreu commented on issue #17801: Add a bot to manually trigger CI builds for PR URL: https://github.com/apache/incubator-mxnet/issues/17801#issuecomment-603580457 @mxnet-bot run ci [all] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] marcoabreu edited a comment on issue #17801: Add a bot to manually trigger CI builds for PR
marcoabreu edited a comment on issue #17801: Add a bot to manually trigger CI builds for PR URL: https://github.com/apache/incubator-mxnet/issues/17801#issuecomment-603580327 @mxnet-bot run ci all This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17801: Add a bot to manually trigger CI builds for PR
mxnet-bot commented on issue #17801: Add a bot to manually trigger CI builds for PR URL: https://github.com/apache/incubator-mxnet/issues/17801#issuecomment-603580386 Undefined action detected. Permissible actions are : run ci [all], run ci [job1, job2] Example : @mxnet-bot run ci [all] Example : @mxnet-bot run ci [centos-cpu, clang] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.
This is an automated email from the ASF dual-hosted git repository. aaronmarkham pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 2dc33b5 Bump the publish timestamp. 2dc33b5 is described below commit 2dc33b573953147b3d746a37d560419267311707 Author: mxnet-ci AuthorDate: Wed Mar 25 00:45:39 2020 + Bump the publish timestamp. --- date.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/date.txt b/date.txt new file mode 100644 index 000..a06e814 --- /dev/null +++ b/date.txt @@ -0,0 +1 @@ +Wed Mar 25 00:45:39 UTC 2020
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17801: Add a bot to manually trigger CI builds for PR
ChaiBapchya commented on issue #17801: Add a bot to manually trigger CI builds for PR URL: https://github.com/apache/incubator-mxnet/issues/17801#issuecomment-603572522 Ofcourse! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17801: Add a bot to manually trigger CI builds for PR
ChaiBapchya commented on issue #17801: Add a bot to manually trigger CI builds for PR URL: https://github.com/apache/incubator-mxnet/issues/17801#issuecomment-603572442 @mxnet-bot is deployed!! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17801: Add a bot to manually trigger CI builds for PR
mxnet-bot commented on issue #17801: Add a bot to manually trigger CI builds for PR URL: https://github.com/apache/incubator-mxnet/issues/17801#issuecomment-603572450 Undefined action detected. Permissible actions are : run ci [all], run ci [job1, job2] Example : @mxnet-bot run ci [all] Example : @mxnet-bot run ci [centos-cpu, clang] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17748: support multiple-dim input for unravel_index
mxnet-bot commented on issue #17748: support multiple-dim input for unravel_index URL: https://github.com/apache/incubator-mxnet/pull/17748#issuecomment-603571511 Jenkins CI successfully triggered : [unix-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] wkcn commented on issue #17748: support multiple-dim input for unravel_index
wkcn commented on issue #17748: support multiple-dim input for unravel_index URL: https://github.com/apache/incubator-mxnet/pull/17748#issuecomment-603571487 @mxnet-bot run ci [unix-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17759: [numpy] FFI for insert \ delete \ matmul etc.
mxnet-bot commented on issue #17759: [numpy] FFI for insert \ delete \ matmul etc. URL: https://github.com/apache/incubator-mxnet/pull/17759#issuecomment-603571019 Jenkins CI successfully triggered : [windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] haojin2 commented on issue #17759: [numpy] FFI for insert \ delete \ matmul etc.
haojin2 commented on issue #17759: [numpy] FFI for insert \ delete \ matmul etc. URL: https://github.com/apache/incubator-mxnet/pull/17759#issuecomment-603570981 @mxnet-bot run ci [windows-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya removed a comment on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS
ChaiBapchya removed a comment on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS URL: https://github.com/apache/incubator-mxnet/pull/17894#issuecomment-603562603 @mxnet-bot run ci [sanity] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya removed a comment on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS
ChaiBapchya removed a comment on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS URL: https://github.com/apache/incubator-mxnet/pull/17894#issuecomment-603563746 @mxnet-bot run ci [sanity] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya removed a comment on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS
ChaiBapchya removed a comment on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS URL: https://github.com/apache/incubator-mxnet/pull/17894#issuecomment-603561216 @mxnet-bot run ci [sanity] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya removed a comment on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS
ChaiBapchya removed a comment on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS URL: https://github.com/apache/incubator-mxnet/pull/17894#issuecomment-603502575 @mxnet-bot run ci [sanity] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS
ChaiBapchya commented on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS URL: https://github.com/apache/incubator-mxnet/pull/17894#issuecomment-603565244 @mxnet-bot run ci [sanity] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya removed a comment on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS
ChaiBapchya removed a comment on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS URL: https://github.com/apache/incubator-mxnet/pull/17894#issuecomment-603498183 @mxnet-bot run ci [sanity] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS
mxnet-bot commented on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS URL: https://github.com/apache/incubator-mxnet/pull/17894#issuecomment-603565267 Jenkins CI successfully triggered : [sanity] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS
ChaiBapchya commented on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS URL: https://github.com/apache/incubator-mxnet/pull/17894#issuecomment-603563746 @mxnet-bot run ci [sanity] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS
ChaiBapchya commented on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS URL: https://github.com/apache/incubator-mxnet/pull/17894#issuecomment-603562603 @mxnet-bot run ci [sanity] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS
ChaiBapchya commented on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS URL: https://github.com/apache/incubator-mxnet/pull/17894#issuecomment-603561216 @mxnet-bot run ci [sanity] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] austinmw edited a comment on issue #11872: "socket.error: [Errno 111] Connection refused" while training with multiple workers
austinmw edited a comment on issue #11872: "socket.error: [Errno 111] Connection refused" while training with multiple workers URL: https://github.com/apache/incubator-mxnet/issues/11872#issuecomment-603281308 @djaym7 This is probably related to https://github.com/aws/sagemaker-python-sdk/issues/937 on a SM hosted notebook. Still trying to figure out how to modify the way sagemaker sdk writes the docker compose file in order to increase shared memory. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] vinitra commented on issue #17711: [ONNX export] Fixing spatial export for batchnorm
vinitra commented on issue #17711: [ONNX export] Fixing spatial export for batchnorm URL: https://github.com/apache/incubator-mxnet/pull/17711#issuecomment-603554560 > @vinitra - Thanks for your contributions. can you please sync to master? Just updated! Thanks for the review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on issue #17711: [ONNX export] Fixing spatial export for batchnorm
sandeep-krishnamurthy commented on issue #17711: [ONNX export] Fixing spatial export for batchnorm URL: https://github.com/apache/incubator-mxnet/pull/17711#issuecomment-603553873 @vinitra - Thanks for your contributions. can you please sync to master? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] D-Roberts removed a comment on issue #17851: [WIP] [Numpy] np.linalg.qr forward implementation
D-Roberts removed a comment on issue #17851: [WIP] [Numpy] np.linalg.qr forward implementation URL: https://github.com/apache/incubator-mxnet/pull/17851#issuecomment-603484610 @mxnet-bot run ci [unix-cpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] sxjscience opened a new issue #17901: [Numpy Extension] Move stop_gradient to npx
sxjscience opened a new issue #17901: [Numpy Extension] Move stop_gradient to npx URL: https://github.com/apache/incubator-mxnet/issues/17901 ## Description `stop_gradient` is very essential for building the network. Currently, there is no `stop_gradient` functionality in the numpy interface. The workaround I used is: ```python @use_np def stop_gradient(F, x): return F.stop_gradient(x.as_nd_ndarray()).as_np_ndarray() ``` I think it should be safe to directly register `stop_gradient` in npx. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS
ChaiBapchya commented on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS URL: https://github.com/apache/incubator-mxnet/pull/17894#issuecomment-603502575 @mxnet-bot run ci [sanity] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on issue #17711: [ONNX export] Fixing spatial export for batchnorm
sandeep-krishnamurthy commented on issue #17711: [ONNX export] Fixing spatial export for batchnorm URL: https://github.com/apache/incubator-mxnet/pull/17711#issuecomment-603500869 @vandanavk - Can you please help review this changes? Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS
ChaiBapchya commented on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS URL: https://github.com/apache/incubator-mxnet/pull/17894#issuecomment-603498183 @mxnet-bot run ci [sanity] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya removed a comment on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS
ChaiBapchya removed a comment on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS URL: https://github.com/apache/incubator-mxnet/pull/17894#issuecomment-603488169 @mxnet-bot run ci [sanity] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya removed a comment on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS
ChaiBapchya removed a comment on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS URL: https://github.com/apache/incubator-mxnet/pull/17894#issuecomment-603483040 @mxnet-bot run ci [sanity] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS
ChaiBapchya commented on issue #17894: [OpPerf] Fix axis_shape and function mismatch for LTS URL: https://github.com/apache/incubator-mxnet/pull/17894#issuecomment-603488169 @mxnet-bot run ci [sanity] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
