[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18277: Fix binary scalar dtype and add bool support

2020-05-21 Thread GitBox


mxnet-bot commented on pull request #18277:
URL: https://github.com/apache/incubator-mxnet/pull/18277#issuecomment-632500574


   Jenkins CI successfully triggered : [windows-gpu]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] Tommliu commented on pull request #18277: Fix binary scalar dtype and add bool support

2020-05-21 Thread GitBox


Tommliu commented on pull request #18277:
URL: https://github.com/apache/incubator-mxnet/pull/18277#issuecomment-632500542


   @mxnet-bot run ci [windows-gpu]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] sxjscience commented on pull request #18089: Add npx op 'index_add'

2020-05-21 Thread GitBox


sxjscience commented on pull request #18089:
URL: https://github.com/apache/incubator-mxnet/pull/18089#issuecomment-632499329


   LGTM overall. Needs to fix the CudaMalloc + cudaFree.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] sxjscience commented on a change in pull request #18089: Add npx op 'index_add'

2020-05-21 Thread GitBox


sxjscience commented on a change in pull request #18089:
URL: https://github.com/apache/incubator-mxnet/pull/18089#discussion_r429055166



##
File path: src/operator/tensor/index_add_backward.cu
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file index_add.cu
+ * \brief GPU implementation of index_add operator
+ */
+
+#include 
+#include "./index_add-inl.h"
+#include "../tensor/util/tensor_util-inl.cuh"
+#include "../tensor/util/tensor_util-inl.h"
+
+namespace mxnet {
+namespace op {
+
+template
+void IndexAddOpBackwardACalc(mshadow::Stream *s,
+ DType* grad_a, const DType* ograd,
+ const size_t* stride,
+ const size_t tail_size, const int ind_num,
+ const int ind_ndim, const int32_t* ind_vec,
+ const int req, const int out_ndim) {
+  using namespace mxnet_op;
+  using namespace mshadow;
+  size_t* d_stride;
+  size_t shape_size = sizeof(size_t) * out_ndim;
+  cudaMalloc(reinterpret_cast(_stride), shape_size);
+  cudaMemcpy(d_stride, stride, shape_size, cudaMemcpyHostToDevice);
+  Kernel, xpu>::Launch(
+ s, ind_num, grad_a, ograd,
+ d_stride, tail_size,
+ ind_num, ind_ndim, ind_vec, req);
+  cudaFree(d_stride);

Review comment:
   Instead of cudaMalloc + cudaFree. Use the memory management system to 
allocate temporary memory.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] sxjscience commented on a change in pull request #18089: Add npx op 'index_add'

2020-05-21 Thread GitBox


sxjscience commented on a change in pull request #18089:
URL: https://github.com/apache/incubator-mxnet/pull/18089#discussion_r429054854



##
File path: src/operator/tensor/index_add_backward.cu
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file index_add.cu
+ * \brief GPU implementation of index_add operator
+ */
+
+#include 
+#include "./index_add-inl.h"
+#include "../tensor/util/tensor_util-inl.cuh"
+#include "../tensor/util/tensor_util-inl.h"
+
+namespace mxnet {
+namespace op {
+
+template
+void IndexAddOpBackwardACalc(mshadow::Stream *s,
+ DType* grad_a, const DType* ograd,
+ const size_t* stride,
+ const size_t tail_size, const int ind_num,
+ const int ind_ndim, const int32_t* ind_vec,
+ const int req, const int out_ndim) {
+  using namespace mxnet_op;
+  using namespace mshadow;
+  size_t* d_stride;
+  size_t shape_size = sizeof(size_t) * out_ndim;
+  cudaMalloc(reinterpret_cast(_stride), shape_size);

Review comment:
   We may not use cudaMalloc here. Allocate additional temporary storage to 
do this.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] TriLoo closed issue #18386: the metric.py is missed in the latest master branch

2020-05-21 Thread GitBox


TriLoo closed issue #18386:
URL: https://github.com/apache/incubator-mxnet/issues/18386


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] TriLoo commented on issue #18386: the metric.py is missed in the latest master branch

2020-05-21 Thread GitBox


TriLoo commented on issue #18386:
URL: 
https://github.com/apache/incubator-mxnet/issues/18386#issuecomment-632493182


   It was indeed moved to `mx.gluon.metrix` ...



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] TriLoo opened a new issue #18386: the metric.py is missed in the latest master branch

2020-05-21 Thread GitBox


TriLoo opened a new issue #18386:
URL: https://github.com/apache/incubator-mxnet/issues/18386


   mxnet installed using latest source code from master branch complains: 
`AttributeError: module 'mxnet' has no attribute 'metric'`
   
   looks like the `metric.py` is missed or moved to another package ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18371: [numpy] fix op repeat with list input

2020-05-21 Thread GitBox


mxnet-bot commented on pull request #18371:
URL: https://github.com/apache/incubator-mxnet/pull/18371#issuecomment-632486123


   Jenkins CI successfully triggered : [windows-gpu]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] Yiyan66 commented on pull request #18371: [numpy] fix op repeat with list input

2020-05-21 Thread GitBox


Yiyan66 commented on pull request #18371:
URL: https://github.com/apache/incubator-mxnet/pull/18371#issuecomment-632486091


   @mxnet-bot run ci [windows-gpu]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[incubator-mxnet] branch master updated (b0315f8 -> 2cb6153)

2020-05-21 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository.

zhasheng pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.


from b0315f8  [R] Fix incorrect website title for Symbol API in R (#18326)
 add 2cb6153  Fix test_subgraph skipif (#18361)

No new revisions were added by this update.

Summary of changes:
 tests/python/unittest/test_extensions.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



[GitHub] [incubator-mxnet] szha merged pull request #18361: Fix test_subgraph skipif

2020-05-21 Thread GitBox


szha merged pull request #18361:
URL: https://github.com/apache/incubator-mxnet/pull/18361


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] mseth10 commented on pull request #18361: Fix test_subgraph skipif

2020-05-21 Thread GitBox


mseth10 commented on pull request #18361:
URL: https://github.com/apache/incubator-mxnet/pull/18361#issuecomment-632479856


   @leezu can we merge this?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18385: Safe accumulation for computing gradient in Embedding & Take

2020-05-21 Thread GitBox


mxnet-bot commented on pull request #18385:
URL: https://github.com/apache/incubator-mxnet/pull/18385#issuecomment-632476192


   Hey @MoisesHer , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one 
or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [centos-cpu, miscellaneous, website, sanity, 
windows-gpu, windows-cpu, unix-gpu, centos-gpu, clang, edge, unix-cpu]
   *** 
   _Note_: 
Only following 3 categories can trigger CI :PR Author, MXNet Committer, 
Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] MoisesHer opened a new pull request #18385: Safe accumulation for computing gradient in Embedding & Take

2020-05-21 Thread GitBox


MoisesHer opened a new pull request #18385:
URL: https://github.com/apache/incubator-mxnet/pull/18385


   ## Description ##
   This PR adds the option to compute gradient of Embedding and Take with safe 
accumulation,
   i.e. when dtype is FP16, accumulation will be done in FP32.
   It fixes the underflow problem that was causing issue 
[https://github.com/apache/incubator-mxnet/issues/17703](https://github.com/apache/incubator-mxnet/issues/17703)
   This was happening when number of indices is very large, and vocabulary/data 
small
   For activating it user can set: MXNET_SAFE_ACCUMULATION=1
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - Unit tests are added for both Take and Embedding using a 
   - [x] Code is well-documented: 
   - [x] To the best of my knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   SAFE_ACCUMULATION was added in the following operators
   - [x] _backward_Embedding (required modification within mshadow)
   - [x]  _backward_Embedding
   - [x]  _backward_take  for any axis (required modification within 
mshadow for axis=0)
   - [x]  _backward_take  for any axis (required modification within 
mshadow for axis=0)
   ## Comments ##
   TODO:
   - [x] _backward_take unit test (cpu / gpu) failing. Non deterministic error, 
which happens after re-running _backward_take. Looks like 
deallocation/allocation mem issue.
   - [x] Performance review
   - [x] Include this option into Automatic Mixed Precision to avoid issues 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] liuzh91 commented on issue #18372: Question about testing weight sharing of two resnets in test_gluon_estimator.py

2020-05-21 Thread GitBox


liuzh91 commented on issue #18372:
URL: 
https://github.com/apache/incubator-mxnet/issues/18372#issuecomment-632473275


   > @liuzh91 these appear to be two separate parameters, as their prefixes 
differ: **resnetv10**_weight vs **dense0**_weight
   
   It should be `val_net.output = gluon.nn.Dense(10, 
params=net.output.collect_params())`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] leezu commented on issue #18372: Question about testing weight sharing of two resnets in test_gluon_estimator.py

2020-05-21 Thread GitBox


leezu commented on issue #18372:
URL: 
https://github.com/apache/incubator-mxnet/issues/18372#issuecomment-632470583


   @liuzh91 these appear to be two separate parameters, as their prefixes 
differ: **resnetv10**_weight vs **dense0**_weight



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18384: Move nightly tests to PR tests

2020-05-21 Thread GitBox


mxnet-bot commented on pull request #18384:
URL: https://github.com/apache/incubator-mxnet/pull/18384#issuecomment-632469994


   Hey @leezu , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one 
or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [unix-gpu, clang, edge, miscellaneous, sanity, 
website, windows-cpu, centos-gpu, windows-gpu, unix-cpu, centos-cpu]
   *** 
   _Note_: 
Only following 3 categories can trigger CI :PR Author, MXNet Committer, 
Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] leezu opened a new pull request #18384: Move nightly tests to PR tests

2020-05-21 Thread GitBox


leezu opened a new pull request #18384:
URL: https://github.com/apache/incubator-mxnet/pull/18384


   Nightly tests are frequently broken and not fixed. Based on the staggered 
build pipeline it should be acceptable to run them on every PR.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[incubator-mxnet] branch leezu-patch-2 created (now 1a7d8c3)

2020-05-21 Thread lausen
This is an automated email from the ASF dual-hosted git repository.

lausen pushed a change to branch leezu-patch-2
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.


  at 1a7d8c3  Disable test_composite_embedding_with_one_embedding

No new revisions were added by this update.



[incubator-mxnet] branch leezu-patch-2 created (now 1a7d8c3)

2020-05-21 Thread lausen
This is an automated email from the ASF dual-hosted git repository.

lausen pushed a change to branch leezu-patch-2
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.


  at 1a7d8c3  Disable test_composite_embedding_with_one_embedding

This branch includes the following new commits:

 new 1a7d8c3  Disable test_composite_embedding_with_one_embedding

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




[GitHub] [incubator-mxnet] leezu opened a new pull request #18383: Disable test_composite_embedding_with_one_embedding

2020-05-21 Thread GitBox


leezu opened a new pull request #18383:
URL: https://github.com/apache/incubator-mxnet/pull/18383


   https://github.com/apache/incubator-mxnet/issues/18282



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[incubator-mxnet] 01/01: Disable test_composite_embedding_with_one_embedding

2020-05-21 Thread lausen
This is an automated email from the ASF dual-hosted git repository.

lausen pushed a commit to branch leezu-patch-2
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git

commit 1a7d8c36a1ed1077156cefa91013c3d0f4e2e7e1
Author: Leonard Lausen 
AuthorDate: Thu May 21 21:14:42 2020 -0700

Disable test_composite_embedding_with_one_embedding
---
 tests/python/unittest/test_contrib_text.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/python/unittest/test_contrib_text.py 
b/tests/python/unittest/test_contrib_text.py
index 0778e5a..44d4422 100644
--- a/tests/python/unittest/test_contrib_text.py
+++ b/tests/python/unittest/test_contrib_text.py
@@ -17,9 +17,6 @@
 
 # coding: utf-8
 
-from __future__ import absolute_import
-from __future__ import print_function
-
 from collections import Counter
 
 from common import assertRaises
@@ -27,6 +24,8 @@ from mxnet import ndarray as nd
 from mxnet.test_utils import *
 from mxnet.contrib import text
 
+import pytest
+
 
 def _get_test_str_of_tokens(token_delim, seq_delim):
 seq1 = token_delim + token_delim.join(['Life', 'is', 'great', '!']) + 
token_delim + seq_delim
@@ -518,6 +517,7 @@ def test_custom_embedding_with_vocabulary():
 )
 
 
+@pytest.mark.skip(reason='https://github.com/apache/incubator-mxnet/issues/18282')
 def test_composite_embedding_with_one_embedding():
 embed_root = 'embeddings'
 embed_name = 'my_embed'



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18383: Disable test_composite_embedding_with_one_embedding

2020-05-21 Thread GitBox


mxnet-bot commented on pull request #18383:
URL: https://github.com/apache/incubator-mxnet/pull/18383#issuecomment-632469356


   Hey @leezu , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one 
or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [unix-gpu, clang, edge, miscellaneous, sanity, 
website, windows-cpu, centos-gpu, windows-gpu, unix-cpu, centos-cpu]
   *** 
   _Note_: 
Only following 3 categories can trigger CI :PR Author, MXNet Committer, 
Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] leezu commented on issue #18282: test_composite_embedding_with_one_embedding

2020-05-21 Thread GitBox


leezu commented on issue #18282:
URL: 
https://github.com/apache/incubator-mxnet/issues/18282#issuecomment-632469389


   
http://jenkins.mxnet-ci.amazon-ml.com/blue/rest/organizations/jenkins/pipelines/mxnet-validation/pipelines/windows-gpu/branches/PR-18365/runs/10/nodes/109/steps/155/log/?start=0



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] liuzh91 commented on issue #18372: Question about testing weight sharing of two resnets in test_gluon_estimator.py

2020-05-21 Thread GitBox


liuzh91 commented on issue #18372:
URL: 
https://github.com/apache/incubator-mxnet/issues/18372#issuecomment-632467681


   I think as of the time of testing, you have not initialized network weights. 
Would you mind testing `net.output.weight.data==val_net.output.weight.data` 
after both `net` and `val_net` are both initialized?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] yajiedesign commented on pull request #18379: change _Pragma to #pragma

2020-05-21 Thread GitBox


yajiedesign commented on pull request #18379:
URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632461418


   Cannot be resolved by upgrade vs.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x

2020-05-21 Thread GitBox


mxnet-bot commented on pull request #18351:
URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632455510


   Jenkins CI successfully triggered : [edge]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x

2020-05-21 Thread GitBox


Alicia1529 commented on pull request #18351:
URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632455492


   @mxnet-bot run ci [edge]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x

2020-05-21 Thread GitBox


Alicia1529 commented on pull request #18352:
URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632455459


   @mxnet-bot run ci [edge]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x

2020-05-21 Thread GitBox


mxnet-bot commented on pull request #18352:
URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632455496


   Jenkins CI successfully triggered : [edge]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] acphile commented on issue #18372: Question about testing weight sharing of two resnets in test_gluon_estimator.py

2020-05-21 Thread GitBox


acphile commented on issue #18372:
URL: 
https://github.com/apache/incubator-mxnet/issues/18372#issuecomment-63245


   So is Line 420-423 meant to share the same parameters between net.output and 
val_net.output (other parts are different)? If so, actually Line 420-423 fails 
to share parameters:
   ```
   net = gluon.model_zoo.vision.resnet18_v1(pretrained=False, ctx=ctx)
   net.output = gluon.nn.Dense(10)
   val_net = gluon.model_zoo.vision.resnet18_v1(pretrained=False, ctx=ctx)
   val_net.output = gluon.nn.Dense(10, params=net.collect_params())
   >>> print(val_net.output.weight)
   Parameter resnetv10_weight (shape=(10, 0), dtype=float32)
   >>> print(net.output.weight)
   Parameter dense0_weight (shape=(10, 0), dtype=float32)
   >>> print(net.output.weight.data==val_net.output.weight.data)
   False
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] leezu opened a new issue #18382: test_CSVIter

2020-05-21 Thread GitBox


leezu opened a new issue #18382:
URL: https://github.com/apache/incubator-mxnet/issues/18382


   ```
   [2020-05-22T01:08:46.081Z] _ test_CSVIter 
_
   
   [2020-05-22T01:08:46.081Z] [gw0] linux -- Python 3.6.9 /usr/bin/python3
   
   [2020-05-22T01:08:46.081Z] 
   
   [2020-05-22T01:08:46.081Z] def test_CSVIter():
   
   [2020-05-22T01:08:46.081Z] def 
check_CSVIter_synthetic(dtype='float32'):
   
   [2020-05-22T01:08:46.081Z] cwd = os.getcwd()
   
   [2020-05-22T01:08:46.081Z] data_path = os.path.join(cwd, 
'data.t')
   
   [2020-05-22T01:08:46.081Z] label_path = os.path.join(cwd, 
'label.t')
   
   [2020-05-22T01:08:46.081Z] entry_str = '1'
   
   [2020-05-22T01:08:46.081Z] if dtype is 'int32':
   
   [2020-05-22T01:08:46.081Z] entry_str = '20001'
   
   [2020-05-22T01:08:46.081Z] if dtype is 'int64':
   
   [2020-05-22T01:08:46.081Z] entry_str = '2147483648'
   
   [2020-05-22T01:08:46.081Z] with open(data_path, 'w') as fout:
   
   [2020-05-22T01:08:46.081Z] for i in range(1000):
   
   [2020-05-22T01:08:46.081Z] 
fout.write(','.join([entry_str for _ in range(8*8)]) + '\n')
   
   [2020-05-22T01:08:46.081Z] with open(label_path, 'w') as fout:
   
   [2020-05-22T01:08:46.081Z] for i in range(1000):
   
   [2020-05-22T01:08:46.081Z] fout.write('0\n')
   
   [2020-05-22T01:08:46.081Z] 
   
   [2020-05-22T01:08:46.081Z] data_train = 
mx.io.CSVIter(data_csv=data_path, data_shape=(8, 8),
   
   [2020-05-22T01:08:46.081Z]
label_csv=label_path, batch_size=100, dtype=dtype)
   
   [2020-05-22T01:08:46.081Z] expected = mx.nd.ones((100, 8, 8), 
dtype=dtype) * int(entry_str)
   
   [2020-05-22T01:08:46.081Z] for batch in iter(data_train):
   
   [2020-05-22T01:08:46.081Z] data_batch = data_train.getdata()
   
   [2020-05-22T01:08:46.081Z] 
assert_almost_equal(data_batch.asnumpy(), expected.asnumpy())
   
   [2020-05-22T01:08:46.081Z] assert data_batch.asnumpy().dtype 
== expected.asnumpy().dtype
   
   [2020-05-22T01:08:46.081Z] 
   
   [2020-05-22T01:08:46.081Z] for dtype in ['int32', 'int64', 
'float32']:
   
   [2020-05-22T01:08:46.081Z] >   check_CSVIter_synthetic(dtype=dtype)
   
   [2020-05-22T01:08:46.081Z] 
   
   [2020-05-22T01:08:46.081Z] tests/python/unittest/test_io.py:455: 
   
   [2020-05-22T01:08:46.081Z] _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
   
   [2020-05-22T01:08:46.081Z] tests/python/unittest/test_io.py:447: in 
check_CSVIter_synthetic
   
   [2020-05-22T01:08:46.081Z] label_csv=label_path, batch_size=100, 
dtype=dtype)
   
   [2020-05-22T01:08:46.081Z] python/mxnet/io/io.py:1004: in creator
   
   [2020-05-22T01:08:46.081Z] return MXDataIter(iter_handle, **kwargs)
   
   [2020-05-22T01:08:46.081Z] python/mxnet/io/io.py:837: in __init__
   
   [2020-05-22T01:08:46.081Z] self.first_batch = self.next()
   
   [2020-05-22T01:08:46.081Z] python/mxnet/io/io.py:871: in next
   
   [2020-05-22T01:08:46.081Z] check_call(_LIB.MXDataIterNext(self.handle, 
ctypes.byref(next_res)))
   
   [2020-05-22T01:08:46.081Z] _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
   
   [2020-05-22T01:08:46.081Z] 
   
   [2020-05-22T01:08:46.081Z] ret = -1
   
   [2020-05-22T01:08:46.081Z] 
   
   [2020-05-22T01:08:46.081Z] def check_call(ret):
   
   [2020-05-22T01:08:46.081Z] """Check the return value of C API call.
   
   [2020-05-22T01:08:46.081Z] 
   
   [2020-05-22T01:08:46.081Z] This function will raise an exception 
when an error occurs.
   
   [2020-05-22T01:08:46.081Z] Wrap every API call with this function.
   
   [2020-05-22T01:08:46.081Z] 
   
   [2020-05-22T01:08:46.081Z] Parameters
   
   [2020-05-22T01:08:46.081Z] --
   
   [2020-05-22T01:08:46.081Z] ret : int
   
   [2020-05-22T01:08:46.081Z] return value from API calls.
   
   [2020-05-22T01:08:46.081Z] """
   
   [2020-05-22T01:08:46.081Z] if ret != 0:
   
   [2020-05-22T01:08:46.081Z] >   raise get_last_ffi_error()
   
   [2020-05-22T01:08:46.081Z] E   mxnet.base.MXNetError: Traceback 
(most recent call last):
   
   [2020-05-22T01:08:46.081Z] E [bt] (4) 
/work/mxnet/python/mxnet/../../build/libmxnet.so(MXDataIterNext+0x31) 
[0x7f36a8936ca1]
   
   [2020-05-22T01:08:46.081Z] E [bt] (3) 
/work/mxnet/python/mxnet/../../build/libmxnet.so(mxnet::io::PrefetcherIter::Next()+0x186)
 [0x7f36a8c7c896]
   
   [2020-05-22T01:08:46.081Z] E [bt] (2) 

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x

2020-05-21 Thread GitBox


mxnet-bot commented on pull request #18351:
URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632445595


   Jenkins CI successfully triggered : [edge]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x

2020-05-21 Thread GitBox


Alicia1529 commented on pull request #18351:
URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632445584


   @mxnet-bot run ci [edge]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x

2020-05-21 Thread GitBox


mxnet-bot commented on pull request #18352:
URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632445504


   Jenkins CI successfully triggered : [edge]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x

2020-05-21 Thread GitBox


Alicia1529 commented on pull request #18352:
URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632445478


   @mxnet-bot run ci [edge]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] yajiedesign commented on pull request #18379: change _Pragma to #pragma

2020-05-21 Thread GitBox


yajiedesign commented on pull request #18379:
URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632430692


   I'll try upgrading vs



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] wkcn commented on a change in pull request #18379: change _Pragma to #pragma

2020-05-21 Thread GitBox


wkcn commented on a change in pull request #18379:
URL: https://github.com/apache/incubator-mxnet/pull/18379#discussion_r428988397



##
File path: src/io/batchify.cc
##
@@ -150,7 +150,7 @@ class StackBatchify : public BatchifyFunction {
 }
 int sbs = static_cast(bs);
 MSHADOW_TYPE_SWITCH_WITH_BOOL(dtype, DType, {
-  _Pragma("omp parallel for num_threads(bs)")
+  #pragma omp parallel for num_threads(bs)

Review comment:
   We can unify the macro like
   ```c++
   #ifndef _MSC_VER
   #define __pragma(id) _Pragma(#id)
   #endif
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2020-05-21 Thread aaronmarkham
This is an automated email from the ASF dual-hosted git repository.

aaronmarkham pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new d322d20  Bump the publish timestamp.
d322d20 is described below

commit d322d202cee59e725619808275dea345e10ac012
Author: mxnet-ci 
AuthorDate: Fri May 22 00:48:02 2020 +

Bump the publish timestamp.
---
 date.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/date.txt b/date.txt
new file mode 100644
index 000..2deee4b
--- /dev/null
+++ b/date.txt
@@ -0,0 +1 @@
+Fri May 22 00:48:02 UTC 2020



[GitHub] [incubator-mxnet] wkcn commented on a change in pull request #17975: [Bug Fix] Fix the wrong result of `mx.np.mean` and `mx.np.sum` when the input contains np.inf

2020-05-21 Thread GitBox


wkcn commented on a change in pull request #17975:
URL: https://github.com/apache/incubator-mxnet/pull/17975#discussion_r428987267



##
File path: tests/python/unittest/test_numpy_op.py
##
@@ -9557,3 +9557,67 @@ def hybrid_forward(self, F, a):
 elif grad_req == 'add':
 assert_almost_equal(new_grad, old_grad + 1)
 
+
+@with_seed()
+@use_np
+def test_np_reduce():
+from numpy.testing import assert_array_equal, assert_array_almost_equal
+# a list of (dtype, decimal)
+# The decimal of an integer is 0
+dtypes = [('float16', 1),
+  ('float32', 4),
+  (np.int8, 0),
+  (np.uint8, 0),
+  (np.int32, 0),
+  (np.int64, 0),
+  (np.float16, 1),
+  (np.float32, 4),
+  (np.float64, 6)]
+shapes = [
+(),
+(1,),
+(5,),
+(4, 3),
+(3, 5),
+(4, 4),
+(4, 5),
+(5, 5),
+(5, 6),
+(6, 6),
+(6, 5, 6),
+(2, 3, 3, 4),
+(4, 2, 1, 2),
+]
+
+def _get_data(case, dtype, shape):
+data = _np.random.uniform(-1.0, 1.0, shape).astype(dtype)
+assert data.size > 0
+for v in case:
+i = _np.random.randint(0, data.size)
+data.ravel()[i] = v
+return data
+
+def _get_cases(decimal):
+if decimal == 0:
+# integer
+return [()]
+options = [_np.inf, -_np.inf, np.nan]

Review comment:
   options = [_np.inf, -_np.inf, _np.nan]





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] wkcn commented on pull request #17975: [Bug Fix] Fix the wrong result of `mx.np.mean` and `mx.np.sum` when the input contains np.inf

2020-05-21 Thread GitBox


wkcn commented on pull request #17975:
URL: https://github.com/apache/incubator-mxnet/pull/17975#issuecomment-632415615


   Hi @sxjscience , could you please help take a review? Thank you!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] leezu commented on pull request #18365: Consider BUILD_SHARED_LIBS flag

2020-05-21 Thread GitBox


leezu commented on pull request #18365:
URL: https://github.com/apache/incubator-mxnet/pull/18365#issuecomment-632403523


   Adopting the standard `BUILD_SHARED_LIBS` may take additional work to make 
sure all dependencies + the CI logic correctly handle the result. It would 
however result into a more "distro-friendly" build you quote, as the 
dependencies will also be built dynamically.
   
   But to keep things simple in this PR, it's fine to use an MXNet specific 
setting for now. I modified your PR slightly to reintroduce the MXNet specific 
option.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18277: Fix binary scalar dtype and add bool support

2020-05-21 Thread GitBox


mxnet-bot commented on pull request #18277:
URL: https://github.com/apache/incubator-mxnet/pull/18277#issuecomment-632399069


   Jenkins CI successfully triggered : [centos-cpu]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] Tommliu commented on pull request #18277: Fix binary scalar dtype and add bool support

2020-05-21 Thread GitBox


Tommliu commented on pull request #18277:
URL: https://github.com/apache/incubator-mxnet/pull/18277#issuecomment-632399039


   @mxnet-bot run ci [centos-cpu]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet-ci] mseth10 commented on pull request #26: Update latest build selection and log when one build fails

2020-05-21 Thread GitBox


mseth10 commented on pull request #26:
URL: https://github.com/apache/incubator-mxnet-ci/pull/26#issuecomment-632395929


   
   > When the initial 2 stages of the mxnet-release-cd pipeline fail, it 
doesn't trigger the subsequent 2 stages ['mxnet_lib/static', 'python/pypi']
   
   @ChaiBapchya More precisely, 'mxnet_lib/static' is followed by 
'python/pypi'. As it currently stands, 'mxnet_lib/static' is failing for all 
variants and 'python/pypi' is not running at all. So, we should have failure 
logs for both builds. Our current logic will log only one of them.
   
   We should modify the logic to check for both builds separately, log success 
only if the build exists and is in success state, else log failure. Does that 
make sense?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet-ci] mseth10 commented on a change in pull request #26: Update latest build selection and log when one build fails

2020-05-21 Thread GitBox


mseth10 commented on a change in pull request #26:
URL: https://github.com/apache/incubator-mxnet-ci/pull/26#discussion_r428961116



##
File path: services/jenkins-pipeline-monitor/handler.py
##
@@ -87,11 +95,21 @@ def filter_by_desired_release_job_type(latest_day_builds, 
desired_release_job_ty
 
 
 def status_check(builds):
-for build in builds:
-if build.get_status() == 'SUCCESS':
-logging.info(f'Successful build {get_release_job_type(build)} 
{build.get_number()}')
-else:
-logging.info(f'Failure build {get_release_job_type(build)} 
{build.get_number()}')
+"""
+Check the status of the filtered builds
+If there is not a single build belong to desired release job type, log the 
failures
+else check the status via Jenkins API and report accordingly
+:param builds
+"""
+if not builds:

Review comment:
   we are missing the case when `builds` have only one out of the two 
builds. In that case we should log one of the failure messages.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet-ci] mseth10 commented on a change in pull request #26: Update latest build selection and log when one build fails

2020-05-21 Thread GitBox


mseth10 commented on a change in pull request #26:
URL: https://github.com/apache/incubator-mxnet-ci/pull/26#discussion_r428941459



##
File path: services/jenkins-pipeline-monitor/handler.py
##
@@ -123,8 +141,6 @@ def jenkins_pipeline_monitor():
 latest_day_builds = get_latest_day_builds(job, latest_build_number)
 logging.info(f'latest builds {latest_day_builds}')
 # filter latest day builds by desired build type a.k.a release job type
-desired_release_job_type = ['mxnet_lib/static', 'python/pypi']
-
 filtered_builds = filter_by_desired_release_job_type(latest_day_builds, 
desired_release_job_type)

Review comment:
   we don't need to pass `desired_release_job_type` as an argument now that 
it is global





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] leezu edited a comment on pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox


leezu edited a comment on pull request #18365:
URL: https://github.com/apache/incubator-mxnet/pull/18365#issuecomment-632276816


   @szha sure. In that case just set BUILD_SHARED_LIBS=0.
   
   This is only about simplifying the cmake file to follow standard practice, 
reducing the amount of codes and hacks used by mxnet build system. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] leezu opened a new issue #18381: gelu_test disabled and flaky upon enabling

2020-05-21 Thread GitBox


leezu opened a new issue #18381:
URL: https://github.com/apache/incubator-mxnet/issues/18381


   ## Description
   
https://github.com/apache/incubator-mxnet/blob/0210ce2c136afaa0f57666e5e1c659cab353f5f3/tests/python/unittest/test_gluon.py#L1423-L1434
   
   is actually a no-op by mistake. Upon enabling the test as follows:
   
   ```
   gelu = mx.gluon.nn.GELU()
   def gelu_test(x):
   CUBE_CONSTANT = 0.044715
   ROOT_TWO_OVER_PI = 0.7978845608028654
   def g(x):
   return ROOT_TWO_OVER_PI * (x + CUBE_CONSTANT * x * x * x)
   def f(x):
   return 1.0 + mx.nd.tanh(g(x))
   def gelu(x):
   return 0.5 * x * f(x)
   return [gelu(x_i) for x_i in x]
   
   for test_point, ref_point in zip(gelu_test(point_to_validate), 
gelu(point_to_validate)):
   assert test_point == ref_point
   ```
   
   the tests fails frequently
   
   ```
   [2020-05-21T19:13:03.252Z] for test_point, ref_point in 
zip(gelu_test(point_to_validate), gelu(point_to_validate)):
   [2020-05-21T19:13:03.252Z] >   assert test_point == ref_point
   [2020-05-21T19:13:03.252Z] E   assert \n[-0.04601725...ray 1 
@cpu(0)> == \n[-0.04601722...ray 1 @cpu(0)>
   [2020-05-21T19:13:03.252Z] E -\n
   [2020-05-21T19:13:03.252Z] E -[-0.04601725]\n
   [2020-05-21T19:13:03.252Z] E -
   [2020-05-21T19:13:03.252Z] E +\n
   [2020-05-21T19:13:03.252Z] E +[-0.04601722]\n
   [2020-05-21T19:13:03.252Z] E +
   [2020-05-21T19:13:03.252Z] E Full diff:
   [2020-05-21T19:13:03.252Z] E 
   [2020-05-21T19:13:03.252Z] E - [-0.04601725]
   [2020-05-21T19:13:03.252Z] E ?^
   [2020-05-21T19:13:03.252Z] E + [-0.04601722]
   [2020-05-21T19:13:03.252Z] E ?^
   [2020-05-21T19:13:03.252Z] E   
   ```
   
   
http://jenkins.mxnet-ci.amazon-ml.com/blue/rest/organizations/jenkins/pipelines/mxnet-validation/pipelines/unix-cpu/branches/PR-18376/runs/5/nodes/363/steps/738/log/?start=0
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] cbalint13 commented on pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox


cbalint13 commented on pull request #18365:
URL: https://github.com/apache/incubator-mxnet/pull/18365#issuecomment-632297892


   @leezu ,
   
   * Proposed leap is big, someone need to adjust CI (out of my scope).
   * I can re-propose PR it in earlier form (agree not elegant) and see that 
single one MacOS-CI issue.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] leezu edited a comment on pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox


leezu edited a comment on pull request #18365:
URL: https://github.com/apache/incubator-mxnet/pull/18365#issuecomment-632276816


   @szha sure. In that case just set CMAKE_BUILD_SHARED=0.
   
   This is only about simplifying the cmake file to follow standard practice, 
reducing the amount of codes and hacks used by mxnet build system. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2020-05-21 Thread aaronmarkham
This is an automated email from the ASF dual-hosted git repository.

aaronmarkham pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new 852dbaf  Bump the publish timestamp.
852dbaf is described below

commit 852dbaf436293edd6c605636494bd7f35f00931e
Author: mxnet-ci 
AuthorDate: Thu May 21 18:55:42 2020 +

Bump the publish timestamp.
---
 date.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/date.txt b/date.txt
new file mode 100644
index 000..526340d
--- /dev/null
+++ b/date.txt
@@ -0,0 +1 @@
+Thu May 21 18:55:42 UTC 2020



[GitHub] [incubator-mxnet] cbalint13 commented on pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox


cbalint13 commented on pull request #18365:
URL: https://github.com/apache/incubator-mxnet/pull/18365#issuecomment-632278035


   > @leezu static object should be useful in building standalone C++ inference 
programs. If the size of test is a problem, we can strip the binary after 
compilation.
   
   - we did't get rid, still can build static objects if one desire
   - in my opinion, too big for normal releng purposes (even stripped).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] szha commented on a change in pull request #18376: Fix reference leak in Block._children and enable reference leak tests universally

2020-05-21 Thread GitBox


szha commented on a change in pull request #18376:
URL: https://github.com/apache/incubator-mxnet/pull/18376#discussion_r428843534



##
File path: pytest.ini
##
@@ -23,6 +23,7 @@ markers =
 gpu: mark a test that requires GPU.
 integration: mark an integration test
 onnx_coverage: ONNX coverage test
+garbage_expected: this teast leaks ndarray references. The tested 
functionality is broken.

Review comment:
   ```suggestion
   garbage_expected: this test leaks ndarray references. The tested 
functionality is broken.
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] leezu commented on pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox


leezu commented on pull request #18365:
URL: https://github.com/apache/incubator-mxnet/pull/18365#issuecomment-632276816


   @szha sure. In that case just set CMAKE_BUILD_SHARED=0



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] szha commented on pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox


szha commented on pull request #18365:
URL: https://github.com/apache/incubator-mxnet/pull/18365#issuecomment-632276050


   @leezu static object should be useful in building standalone C++ inference 
programs. If the size of test is a problem, we can strip the binary after 
compilation.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] zhreshold commented on a change in pull request #18379: change _Pragma to #pragma

2020-05-21 Thread GitBox


zhreshold commented on a change in pull request #18379:
URL: https://github.com/apache/incubator-mxnet/pull/18379#discussion_r428841505



##
File path: src/io/batchify.cc
##
@@ -150,7 +150,7 @@ class StackBatchify : public BatchifyFunction {
 }
 int sbs = static_cast(bs);
 MSHADOW_TYPE_SWITCH_WITH_BOOL(dtype, DType, {
-  _Pragma("omp parallel for num_threads(bs)")
+  #pragma omp parallel for num_threads(bs)

Review comment:
   use `__pragma` for msvc if it does not support `_Pragma`





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] zhreshold commented on pull request #18379: change _Pragma to #pragma

2020-05-21 Thread GitBox


zhreshold commented on pull request #18379:
URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632274216


   `#pragma` won't work in a macro, what's the version of msvc? At least 2019 
supports `_Pragma`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] leezu opened a new issue #18380: Various issues on Python 3.8

2020-05-21 Thread GitBox


leezu opened a new issue #18380:
URL: https://github.com/apache/incubator-mxnet/issues/18380


   CI doesn't test Python 3.8 and in fact some things are broken. What I 
noticed:
   
   - Use of `time.clock()` which is deprecated since Python 3.3 and not 
available in 3.8 in some files breaks those functionalities on 3.8
   
   To prevent such issues, suggest to test Python 3.8 on the unix pipelines 
(and test the minimum supported Python version on centos).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[incubator-mxnet] branch master updated (4827de8 -> b0315f8)

2020-05-21 Thread lausen
This is an automated email from the ASF dual-hosted git repository.

lausen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.


from 4827de8  Improve the backward mirroring implementation (#18228)
 add b0315f8  [R] Fix incorrect website title for Symbol API in R (#18326)

No new revisions were added by this update.

Summary of changes:
 docs/static_site/src/pages/api/r/docs/tutorials/symbol.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



[incubator-mxnet] branch master updated (4827de8 -> b0315f8)

2020-05-21 Thread lausen
This is an automated email from the ASF dual-hosted git repository.

lausen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.


from 4827de8  Improve the backward mirroring implementation (#18228)
 add b0315f8  [R] Fix incorrect website title for Symbol API in R (#18326)

No new revisions were added by this update.

Summary of changes:
 docs/static_site/src/pages/api/r/docs/tutorials/symbol.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



[incubator-mxnet] branch master updated (4827de8 -> b0315f8)

2020-05-21 Thread lausen
This is an automated email from the ASF dual-hosted git repository.

lausen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.


from 4827de8  Improve the backward mirroring implementation (#18228)
 add b0315f8  [R] Fix incorrect website title for Symbol API in R (#18326)

No new revisions were added by this update.

Summary of changes:
 docs/static_site/src/pages/api/r/docs/tutorials/symbol.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



[incubator-mxnet] branch master updated (4827de8 -> b0315f8)

2020-05-21 Thread lausen
This is an automated email from the ASF dual-hosted git repository.

lausen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.


from 4827de8  Improve the backward mirroring implementation (#18228)
 add b0315f8  [R] Fix incorrect website title for Symbol API in R (#18326)

No new revisions were added by this update.

Summary of changes:
 docs/static_site/src/pages/api/r/docs/tutorials/symbol.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



[GitHub] [incubator-mxnet] leezu commented on pull request #17749: Fix races in block scope

2020-05-21 Thread GitBox


leezu commented on pull request #17749:
URL: https://github.com/apache/incubator-mxnet/pull/17749#issuecomment-632262724


   @chinakook gluoncv does not support MXNet 2 development version at this 
point. You can use MXNet 1



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] leezu merged pull request #18326: [R] Fix incorrect website title for Symbol API in R

2020-05-21 Thread GitBox


leezu merged pull request #18326:
URL: https://github.com/apache/incubator-mxnet/pull/18326


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18326: [R] Fix incorrect website title for Symbol API in R

2020-05-21 Thread GitBox


ChaiBapchya commented on pull request #18326:
URL: https://github.com/apache/incubator-mxnet/pull/18326#issuecomment-632259139


   @mxnet-label-bot update [pr-awaiting-merge]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] leezu commented on pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox


leezu commented on pull request #18365:
URL: https://github.com/apache/incubator-mxnet/pull/18365#issuecomment-632252702


   > It seems, had the impression that all test units links libmxnet.a
   
   That's part of the problem. It comes with huge link, disk space and CI 
network traffic overheads due to the number of unittests.
   
   > `E   AttributeError: dlsym(0x7fdb866c3810, MXGetLastError): symbol not 
found`
   
   I'm not yet sure about this error. Could you address above comments first 
(or state that you disagree) and then let's look more closely into this issue.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox


leezu commented on a change in pull request #18365:
URL: https://github.com/apache/incubator-mxnet/pull/18365#discussion_r428813870



##
File path: CMakeLists.txt
##
@@ -663,29 +663,46 @@ if(UNIX)
   # Create dummy file since we want an empty shared library before linking
   set(DUMMY_SOURCE ${CMAKE_BINARY_DIR}/dummy.c)
   file(WRITE ${DUMMY_SOURCE} "")
-  list(APPEND MXNET_INSTALL_TARGETS mxnet_static)
-  add_library(mxnet_static STATIC ${SOURCE})
-  target_link_libraries(mxnet_static PUBLIC mshadow)
-  target_compile_definitions(mxnet_static PUBLIC 
DMLC_LOG_FATAL_THROW=$)
-  add_library(mxnet SHARED ${DUMMY_SOURCE})
-  target_link_libraries(mxnet PRIVATE ${BEGIN_WHOLE_ARCHIVE} 
$ ${END_WHOLE_ARCHIVE})
-  target_link_libraries(mxnet PRIVATE mxnet_static)
-  target_link_libraries(mxnet_static PUBLIC ${CMAKE_DL_LIBS})
-  set_target_properties(mxnet_static PROPERTIES OUTPUT_NAME mxnet)
+  if(CMAKE_BUILD_SHARED)
+add_library(mxnet SHARED ${SOURCE})
+list(APPEND MXNET_INSTALL_TARGETS mxnet)
+  else()
+add_library(mxnet_static STATIC ${SOURCE})

Review comment:
   In particular we should get rid of the separate `mxnet_static` target





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox


leezu commented on a change in pull request #18365:
URL: https://github.com/apache/incubator-mxnet/pull/18365#discussion_r428813539



##
File path: example/image-classification/predict-cpp/CMakeLists.txt
##
@@ -5,11 +5,11 @@ OpenCV version >= 3 should be enabled and found to build 
image classification ex
   return()
 endif()
 
-if(NOT MSVC)
+if(NOT MSVC AND NOT CMAKE_BUILD_SHARED)
   set(IMG_CLASSIFICATION_EXAMPLE_STATIC_LINK ON CACHE BOOL "\
 Link mxnet library statically in the c++ image classification example")
 else()
-  # disable static linking on Windows
+  # disable static linking on Windows & CMAKE_BUILD_SHARED
   set(IMG_CLASSIFICATION_EXAMPLE_STATIC_LINK OFF)
 endif()

Review comment:
   Let's delete this too and let cmake handle things automatically based on 
`CMAKE_BUILD_SHARED`





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox


leezu commented on a change in pull request #18365:
URL: https://github.com/apache/incubator-mxnet/pull/18365#discussion_r428813091



##
File path: tests/CMakeLists.txt
##
@@ -16,7 +16,7 @@ if(NOT GTEST_ROOT)
   endif()
 endif()
 
-if(NOT MSVC)
+if(NOT MSVC AND NOT CMAKE_BUILD_SHARED)
   set(UNITTEST_STATIC_LINK ON)
 endif()

Review comment:
   These 3 lines can be deleted





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox


leezu commented on a change in pull request #18365:
URL: https://github.com/apache/incubator-mxnet/pull/18365#discussion_r428812794



##
File path: CMakeLists.txt
##
@@ -663,29 +663,46 @@ if(UNIX)
   # Create dummy file since we want an empty shared library before linking
   set(DUMMY_SOURCE ${CMAKE_BINARY_DIR}/dummy.c)
   file(WRITE ${DUMMY_SOURCE} "")
-  list(APPEND MXNET_INSTALL_TARGETS mxnet_static)
-  add_library(mxnet_static STATIC ${SOURCE})
-  target_link_libraries(mxnet_static PUBLIC mshadow)
-  target_compile_definitions(mxnet_static PUBLIC 
DMLC_LOG_FATAL_THROW=$)
-  add_library(mxnet SHARED ${DUMMY_SOURCE})
-  target_link_libraries(mxnet PRIVATE ${BEGIN_WHOLE_ARCHIVE} 
$ ${END_WHOLE_ARCHIVE})
-  target_link_libraries(mxnet PRIVATE mxnet_static)
-  target_link_libraries(mxnet_static PUBLIC ${CMAKE_DL_LIBS})
-  set_target_properties(mxnet_static PROPERTIES OUTPUT_NAME mxnet)
+  if(CMAKE_BUILD_SHARED)
+add_library(mxnet SHARED ${SOURCE})

Review comment:
   You can remove `SHARED` here and delete the `else` clause below. cmake 
will use the correct library type based on `CMAKE_BUILD_SHARED`





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] samskalicky commented on pull request #18236: [1.7] Pass args fix2 + Fix pylint with unpinned astroid causing CI issues

2020-05-21 Thread GitBox


samskalicky commented on pull request #18236:
URL: https://github.com/apache/incubator-mxnet/pull/18236#issuecomment-632239843


   @ciyongch thanks for the reminder, I merged



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] D-Roberts commented on pull request #18197: [Numpy] Add qr backward part 2 for wide matrices with m < n

2020-05-21 Thread GitBox


D-Roberts commented on pull request #18197:
URL: https://github.com/apache/incubator-mxnet/pull/18197#issuecomment-632237899


   Hi @yzhliu - is there anything else you'd like me to do on this? tnx



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] sxjscience commented on pull request #18228: [MXNET-1450] Improve the backward mirroring implementation

2020-05-21 Thread GitBox


sxjscience commented on pull request #18228:
URL: https://github.com/apache/incubator-mxnet/pull/18228#issuecomment-632219485


   Is there a way to use it for Gluon?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[incubator-mxnet] branch master updated (5343aef -> 4827de8)

2020-05-21 Thread haibin
This is an automated email from the ASF dual-hosted git repository.

haibin pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.


from 5343aef  [Numpy] Fix gluon activations (#18370)
 add 4827de8  Improve the backward mirroring implementation (#18228)

No new revisions were added by this update.

Summary of changes:
 ci/windows/test_py3_cpu.ps1   |   6 +
 ci/windows/test_py3_gpu.ps1   |   7 +
 docs/static_site/src/pages/api/faq/env_var.md |   6 +-
 example/image-classification/README.md|  11 +-
 python/mxnet/rnn/rnn_cell.py  |   5 +
 src/executor/exec_pass.h  |  37 +-
 src/executor/graph_executor.cc| 128 +++--
 src/executor/graph_executor.h |   8 +-
 src/imperative/cached_op.h|   2 +-
 src/imperative/imperative.cc  |   2 +-
 src/nnvm/gradient.cc  | 709 +-
 src/nnvm/plan_memory.cc   |  15 +-
 src/operator/nn/activation-inl.h  |   9 +-
 src/operator/nn/activation.cc |  50 +-
 src/operator/nn/activation.cu |  46 +-
 src/operator/nn/cudnn/cudnn_batch_norm-inl.h  |  16 +-
 tests/python/unittest/test_memory_opt.py  | 202 
 17 files changed, 1009 insertions(+), 250 deletions(-)
 create mode 100644 tests/python/unittest/test_memory_opt.py



[incubator-mxnet] branch master updated (67b5d31 -> 5343aef)

2020-05-21 Thread sxjscience
This is an automated email from the ASF dual-hosted git repository.

sxjscience pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.


from 67b5d31  Fix race condition in unittest by pytest temp_dir fixtures 
(#18323)
 add 5343aef  [Numpy] Fix gluon activations (#18370)

No new revisions were added by this update.

Summary of changes:
 python/mxnet/gluon/nn/activations.py  | 18 +++
 tests/python/unittest/test_numpy_gluon.py | 50 +++
 2 files changed, 63 insertions(+), 5 deletions(-)



[GitHub] [incubator-mxnet] eric-haibin-lin merged pull request #18228: [MXNET-1450] Improve the backward mirroring implementation

2020-05-21 Thread GitBox


eric-haibin-lin merged pull request #18228:
URL: https://github.com/apache/incubator-mxnet/pull/18228


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[incubator-mxnet] branch master updated (67b5d31 -> 5343aef)

2020-05-21 Thread sxjscience
This is an automated email from the ASF dual-hosted git repository.

sxjscience pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.


from 67b5d31  Fix race condition in unittest by pytest temp_dir fixtures 
(#18323)
 add 5343aef  [Numpy] Fix gluon activations (#18370)

No new revisions were added by this update.

Summary of changes:
 python/mxnet/gluon/nn/activations.py  | 18 +++
 tests/python/unittest/test_numpy_gluon.py | 50 +++
 2 files changed, 63 insertions(+), 5 deletions(-)



[incubator-mxnet] branch master updated (67b5d31 -> 5343aef)

2020-05-21 Thread sxjscience
This is an automated email from the ASF dual-hosted git repository.

sxjscience pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.


from 67b5d31  Fix race condition in unittest by pytest temp_dir fixtures 
(#18323)
 add 5343aef  [Numpy] Fix gluon activations (#18370)

No new revisions were added by this update.

Summary of changes:
 python/mxnet/gluon/nn/activations.py  | 18 +++
 tests/python/unittest/test_numpy_gluon.py | 50 +++
 2 files changed, 63 insertions(+), 5 deletions(-)



[GitHub] [incubator-mxnet] yajiedesign commented on pull request #18379: change _Pragma to #pragma

2020-05-21 Thread GitBox


yajiedesign commented on pull request #18379:
URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632181662


   https://github.com/apache/incubator-mxnet/issues/18374



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] yajiedesign opened a new pull request #18379: change _Pragma to #pragma

2020-05-21 Thread GitBox


yajiedesign opened a new pull request #18379:
URL: https://github.com/apache/incubator-mxnet/pull/18379


   ## Description ##
   change _Pragma to #pragma
   _Pragma not work with msvc
   
   ## Checklist ##
   ### Essentials ###
   - [x] Changes are complete (i.e. I finished coding on this PR)
   ### Changes ###
   ## Comments ##
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18379: change _Pragma to #pragma

2020-05-21 Thread GitBox


mxnet-bot commented on pull request #18379:
URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632181495


   Hey @yajiedesign , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one 
or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [windows-gpu, edge, clang, miscellaneous, 
windows-cpu, centos-cpu, centos-gpu, unix-cpu, website, sanity, unix-gpu]
   *** 
   _Note_: 
Only following 3 categories can trigger CI :PR Author, MXNet Committer, 
Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[incubator-mxnet] branch master updated (67b5d31 -> 5343aef)

2020-05-21 Thread sxjscience
This is an automated email from the ASF dual-hosted git repository.

sxjscience pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.


from 67b5d31  Fix race condition in unittest by pytest temp_dir fixtures 
(#18323)
 add 5343aef  [Numpy] Fix gluon activations (#18370)

No new revisions were added by this update.

Summary of changes:
 python/mxnet/gluon/nn/activations.py  | 18 +++
 tests/python/unittest/test_numpy_gluon.py | 50 +++
 2 files changed, 63 insertions(+), 5 deletions(-)



[GitHub] [incubator-mxnet] sxjscience merged pull request #18370: [Numpy] Fix gluon activations

2020-05-21 Thread GitBox


sxjscience merged pull request #18370:
URL: https://github.com/apache/incubator-mxnet/pull/18370


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] yajiedesign commented on issue #18374: Windows nightly builds broken

2020-05-21 Thread GitBox


yajiedesign commented on issue #18374:
URL: 
https://github.com/apache/incubator-mxnet/issues/18374#issuecomment-632174279


   I already know. Now there are some compilation errors.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x

2020-05-21 Thread GitBox


mxnet-bot commented on pull request #18352:
URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632107674


   Jenkins CI successfully triggered : [edge]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x

2020-05-21 Thread GitBox


Alicia1529 commented on pull request #18351:
URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632107730


   @mxnet-bot run ci [edge]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x

2020-05-21 Thread GitBox


mxnet-bot commented on pull request #18351:
URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632107782


   Jenkins CI successfully triggered : [edge]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x

2020-05-21 Thread GitBox


Alicia1529 commented on pull request #18352:
URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632107625


   @mxnet-bot run ci [edge]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] bgawrych commented on issue #18244: unix-cpu MKL/MKL-DNN Test Time

2020-05-21 Thread GitBox


bgawrych commented on issue #18244:
URL: 
https://github.com/apache/incubator-mxnet/issues/18244#issuecomment-632106623


   @szha I've done some testing in docker for parallel tests and have some 
overview. For testing I've used about 35 long tests.
   pytest -n 4 spawns much more threads for MKL/MKLDNN built and all the time 
during test CPU usage is 100% (24 cores used out of 24). So it's probably 
starvation problem. 
   Threads spawned:
   MKL/MKLDNN build: most of the time it was about 250, but pick was before end 
and it was 265
   CPU build : 140 (pick 150)
   
   I've tested time for MKLDNN built with set OMP_NUM_THREADS=n/4 (n - number 
of cores)
   and it was significat faster (about 1.7x)
   
   I'm gonna do some testing with MKL and OMP flags and point the best 
configuration and also figure out 'serial' case
   
   cc: @TaoLv 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2020-05-21 Thread aaronmarkham
This is an automated email from the ASF dual-hosted git repository.

aaronmarkham pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new b7795cc  Bump the publish timestamp.
b7795cc is described below

commit b7795cc8ad0067076d0fca960141d1e11a50b44a
Author: mxnet-ci 
AuthorDate: Thu May 21 12:48:19 2020 +

Bump the publish timestamp.
---
 date.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/date.txt b/date.txt
new file mode 100644
index 000..bf3adec
--- /dev/null
+++ b/date.txt
@@ -0,0 +1 @@
+Thu May 21 12:48:19 UTC 2020



[GitHub] [incubator-mxnet] chinakook commented on pull request #17749: Fix races in block scope

2020-05-21 Thread GitBox


chinakook commented on pull request #17749:
URL: https://github.com/apache/incubator-mxnet/pull/17749#issuecomment-632050382


   This commit may cause rcnn/mask-rcnn cannot be trained.
   
https://github.com/dmlc/gluon-cv/blob/3c4150a964c776e4f7da0eb30b55ab05b7554c8d/gluoncv/data/transforms/presets/rcnn.py#L162



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18378: Add backward Type inference to main NN operators

2020-05-21 Thread GitBox


mxnet-bot commented on pull request #18378:
URL: https://github.com/apache/incubator-mxnet/pull/18378#issuecomment-632031459


   Hey @Kh4L , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one 
or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [windows-cpu, sanity, unix-cpu, centos-gpu, unix-gpu, 
centos-cpu, clang, windows-gpu, edge, website, miscellaneous]
   *** 
   _Note_: 
Only following 3 categories can trigger CI :PR Author, MXNet Committer, 
Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] Kh4L opened a new pull request #18378: Add backward Type inference to main NN operators

2020-05-21 Thread GitBox


Kh4L opened a new pull request #18378:
URL: https://github.com/apache/incubator-mxnet/pull/18378


   ## Description ##
   As described in #16757 , a list of operators have their FInferType functions 
were throwing an exception if the input type is not defined (dtype=-1).
   
   This was preventing us from running a partial or backward type inference 
where some not (yet) defined input dtypes would trigger an exception.
   
   
   This PR fixes it by making the FInferType functions do backward inference 
when input is `none` but output is known and return false when both input and 
output dtype is `none`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] Kh4L closed pull request #18332: Fix FInferType of ops to support partial type inference

2020-05-21 Thread GitBox


Kh4L closed pull request #18332:
URL: https://github.com/apache/incubator-mxnet/pull/18332


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x

2020-05-21 Thread GitBox


mxnet-bot commented on pull request #18351:
URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632024263


   Jenkins CI successfully triggered : [unix-cpu, edge]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x

2020-05-21 Thread GitBox


Alicia1529 commented on pull request #18351:
URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632024231


   @mxnet-bot run ci [edge, unix-cpu]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x

2020-05-21 Thread GitBox


Alicia1529 commented on pull request #18352:
URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632024094


   @mxnet-bot run ci [edge, unix-gpu]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x

2020-05-21 Thread GitBox


mxnet-bot commented on pull request #18352:
URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632024146


   Jenkins CI successfully triggered : [unix-gpu, edge]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




  1   2   >