cjolivier01 commented on issue #15167: Pointwise fusion for GPU
URL: https://github.com/apache/incubator-mxnet/pull/15167#issuecomment-529008979
I am removing my block on this PR and letting in this "auto-abuse" in since
I am in a similar industry to NVidia and don't wish to make it look
cjolivier01 commented on issue #15167: Pointwise fusion for GPU
URL: https://github.com/apache/incubator-mxnet/pull/15167#issuecomment-516698343
Google c++ style guide says basically the same thing as what I’m encouraging:
https://google.github.io/styleguide/cppguide.html#auto
cjolivier01 commented on issue #15167: Pointwise fusion for GPU
URL: https://github.com/apache/incubator-mxnet/pull/15167#issuecomment-514835143
1) i randomly picked that line as representative of auto used for pretty
much everything
2) pointing out this or that line is “already in
cjolivier01 commented on issue #15167: Pointwise fusion for GPU
URL: https://github.com/apache/incubator-mxnet/pull/15167#issuecomment-514832116
mxnet doesn’t yet have a c# interface — are you volunteering? The
functionality would be welcomed :)
cjolivier01 commented on issue #15167: Pointwise fusion for GPU
URL: https://github.com/apache/incubator-mxnet/pull/15167#issuecomment-514792263
We apparently have very different interpretation of those guidelines. I
don’t see anything in that which implies “use it everywhere for
cjolivier01 commented on issue #15167: Pointwise fusion for GPU
URL: https://github.com/apache/incubator-mxnet/pull/15167#issuecomment-514768835
I looked at those “core guildelines” and it’s basically what I was saying —
stuff like ::iterator and repetition or obvious type on same line.
