[GitHub] anirudhacharya commented on a change in pull request #10472: [MXNET-106] [ONNX_MXNet] Change parameter names in imported model
anirudhacharya commented on a change in pull request #10472: [MXNET-106]
[ONNX_MXNet] Change parameter names in imported model
URL: https://github.com/apache/incubator-mxnet/pull/10472#discussion_r180509166
##
File path: tests/python-pytest/onnx/backend_rep.py
##
@@ -64,9 +64,16 @@ def run(self, inputs, **kwargs):
else:
raise NotImplementedError("Only CPU context is supported for now")
-mod = mx.mod.Module(symbol=self.symbol, data_names=['input_0'],
context=ctx,
+data_names = [graph_input for graph_input in self.symbol.list_inputs()
+ if graph_input not in self.arg_params and graph_input
not in self.aux_params]
Review comment:
I will put in a comment.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] anirudhacharya commented on a change in pull request #10472: [MXNET-106] [ONNX_MXNet] Change parameter names in imported model
anirudhacharya commented on a change in pull request #10472: [MXNET-106]
[ONNX_MXNet] Change parameter names in imported model
URL: https://github.com/apache/incubator-mxnet/pull/10472#discussion_r180505396
##
File path: tests/python-pytest/onnx/backend_rep.py
##
@@ -64,9 +64,16 @@ def run(self, inputs, **kwargs):
else:
raise NotImplementedError("Only CPU context is supported for now")
-mod = mx.mod.Module(symbol=self.symbol, data_names=['input_0'],
context=ctx,
+data_names = [graph_input for graph_input in self.symbol.list_inputs()
+ if graph_input not in self.arg_params and graph_input
not in self.aux_params]
Review comment:
This will eventually be an API call to the onnx module like
'get_model_metadata' along with other information like shape of the input and
so on. For now I thought this one-liner will be neat and concise.
Do you suggest I make a method call to make it more readable? Adding
parentheses will break the syntax.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
