[GitHub] marcoabreu commented on a change in pull request #9965: Fix R build crash in CI

2018-03-02 Thread GitBox 
marcoabreu commented on a change in pull request #9965: Fix R build crash in CI
URL: https://github.com/apache/incubator-mxnet/pull/9965#discussion_r171984279
 
 

 ##
 File path: R-package/R/viz.graph.R
 ##
 @@ -143,7 +142,7 @@ graph.viz <- function(symbol, shape=NULL, direction="TD", 
type="graph", graph.wi
   }
   
   graph<- create_graph(nodes_df = nodes_df_new, edges_df = edge_df_new, 
directed = TRUE) %>% 
-set_global_graph_attrs("layout", value = "dot", attr_type = "graph") %>% 
+add_global_graph_attrs("layout", value = "dot", attr_type = "graph") %>% 
 
 Review comment:
   Or what do you think, @jeremiedb ? 0.9 sounds like an unstable beta version, 
so maybe it would make sense to tell users to upgrade? But we would also have 
to consider SemVer, so this might be difficult. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] marcoabreu commented on a change in pull request #9965: Fix R build crash in CI

2018-03-02 Thread GitBox 
marcoabreu commented on a change in pull request #9965: Fix R build crash in CI
URL: https://github.com/apache/incubator-mxnet/pull/9965#discussion_r171983600
 
 

 ##
 File path: R-package/R/viz.graph.R
 ##
 @@ -143,7 +142,7 @@ graph.viz <- function(symbol, shape=NULL, direction="TD", 
type="graph", graph.wi
   }
   
   graph<- create_graph(nodes_df = nodes_df_new, edges_df = edge_df_new, 
directed = TRUE) %>% 
-set_global_graph_attrs("layout", value = "dot", attr_type = "graph") %>% 
+add_global_graph_attrs("layout", value = "dot", attr_type = "graph") %>% 
 
 Review comment:
   Wouldn't it rather make sense to pin the version to 0.9.0 - 0.9.2? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services