[GitHub] safrooze commented on issue #9705: Added unittest for benchmarking metric performance

2018-02-28 Thread GitBox
safrooze commented on issue #9705: Added unittest for benchmarking metric performance URL: https://github.com/apache/incubator-mxnet/pull/9705#issuecomment-369331546 I'll move this to nightly tests then. This is an automated

[GitHub] safrooze commented on issue #9705: Added unittest for benchmarking metric performance

2018-02-09 Thread GitBox
safrooze commented on issue #9705: Added unittest for benchmarking metric performance URL: https://github.com/apache/incubator-mxnet/pull/9705#issuecomment-364517332 @eric-haibin-lin You're correct that nightly would be a more suitable place. One concern with nightly was that community

[GitHub] safrooze commented on issue #9705: Added unittest for benchmarking metric performance

2018-02-07 Thread GitBox
safrooze commented on issue #9705: Added unittest for benchmarking metric performance URL: https://github.com/apache/incubator-mxnet/pull/9705#issuecomment-363977854 OK I think I addressed all the feedback: * random is seeded * nd.wait_all() used before starting timing and before

[GitHub] safrooze commented on issue #9705: Added unittest for benchmarking metric performance

2018-02-07 Thread GitBox
safrooze commented on issue #9705: Added unittest for benchmarking metric performance URL: https://github.com/apache/incubator-mxnet/pull/9705#issuecomment-363977854 OK I think I addressed all the feedback: * random is seeded * nd.wait_all() used before starting timing and before

[GitHub] safrooze commented on issue #9705: Added unittest for benchmarking metric performance

2018-02-05 Thread GitBox
safrooze commented on issue #9705: Added unittest for benchmarking metric performance URL: https://github.com/apache/incubator-mxnet/pull/9705#issuecomment-363328924 The intention is to observe a measurable elapsed time (hence large data size) and amplify the difference between CPU and

[GitHub] safrooze commented on issue #9705: Added unittest for benchmarking metric performance

2018-02-05 Thread GitBox
safrooze commented on issue #9705: Added unittest for benchmarking metric performance URL: https://github.com/apache/incubator-mxnet/pull/9705#issuecomment-363302529 @szha Please review. This is an automated message from the