[GitHub] zheng-da commented on issue #11664: Fall back when sparse arrays are passed to MKLDNN-enabled operators
zheng-da commented on issue #11664: Fall back when sparse arrays are passed to MKLDNN-enabled operators URL: https://github.com/apache/incubator-mxnet/pull/11664#issuecomment-415642640 @azai91 could you please review the code? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zheng-da commented on issue #11664: Fall back when sparse arrays are passed to MKLDNN-enabled operators
zheng-da commented on issue #11664: Fall back when sparse arrays are passed to MKLDNN-enabled operators URL: https://github.com/apache/incubator-mxnet/pull/11664#issuecomment-412706348 thanks for providing the performance results. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zheng-da commented on issue #11664: Fall back when sparse arrays are passed to MKLDNN-enabled operators
zheng-da commented on issue #11664: Fall back when sparse arrays are passed to MKLDNN-enabled operators URL: https://github.com/apache/incubator-mxnet/pull/11664#issuecomment-408488135 Please benchmark the performance with this modification to make sure there isn't performance regression. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zheng-da commented on issue #11664: Fall back when sparse arrays are passed to MKLDNN-enabled operators
zheng-da commented on issue #11664: Fall back when sparse arrays are passed to MKLDNN-enabled operators URL: https://github.com/apache/incubator-mxnet/pull/11664#issuecomment-404652395 I have the same comment. Why not call `MKLDNNStorageType`? https://github.com/apache/incubator-mxnet/blob/master/src/operator/nn/mkldnn/mkldnn_base.cc#L521 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
