[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #16155: set fixed seed for profiler
ChaiBapchya commented on a change in pull request #16155: set fixed seed for profiler URL: https://github.com/apache/incubator-mxnet/pull/16155#discussion_r324912567 ## File path: benchmark/opperf/README.md ## @@ -173,6 +173,22 @@ This utility queries MXNet operator registry to fetch all operators registered w However, fully automated tests are enabled only for simpler operators such as - broadcast operators, element_wise operators etc... For the purpose of readability and giving more control to the users, complex operators such as convolution (2D, 3D), Pooling, Recurrent are not fully automated but expressed as default rules. See `utils/op_registry_utils.py` for more details. +## Use nativa python timer Review comment: nitpick: native (also acc to our naming convention we have 2 parameters `native` and `python` where (`native` resembles MXNet's CPP pased profiler) and `python` indicates the python's time function. So I hope people don't get confused between native and native python This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #16155: set fixed seed for profiler
ChaiBapchya commented on a change in pull request #16155: set fixed seed for profiler URL: https://github.com/apache/incubator-mxnet/pull/16155#discussion_r324912567 ## File path: benchmark/opperf/README.md ## @@ -173,6 +173,22 @@ This utility queries MXNet operator registry to fetch all operators registered w However, fully automated tests are enabled only for simpler operators such as - broadcast operators, element_wise operators etc... For the purpose of readability and giving more control to the users, complex operators such as convolution (2D, 3D), Pooling, Recurrent are not fully automated but expressed as default rules. See `utils/op_registry_utils.py` for more details. +## Use nativa python timer Review comment: nitpick: native (also acc to our naming convention we have 2 parameters `native` and `python` where (`native` resembles MXNet's CPP pased profiler) and `python` indicates the python's time function This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
