[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18446: Remove out-dated examples using mx.module

2020-06-04 Thread GitBox
ChaiBapchya commented on pull request #18446: URL: https://github.com/apache/incubator-mxnet/pull/18446#issuecomment-639145005 Testing all these examples in CI is - big task in itself - quite expensive [as currently we don't have a smart way of testing in CI [selective testing based

[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18446: Remove out-dated examples using mx.module

2020-05-31 Thread GitBox
ChaiBapchya commented on pull request #18446: URL: https://github.com/apache/incubator-mxnet/pull/18446#issuecomment-636516226 Right. One issue MXNet users face is the lack of examples & documentation around it. Removing existing examples without substituting with working equivalent

[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18446: Remove out-dated examples using mx.module

2020-05-30 Thread GitBox
ChaiBapchya commented on pull request #18446: URL: https://github.com/apache/incubator-mxnet/pull/18446#issuecomment-636418052 While we remove the outdated examples [as module api is no longer supported], would it be a good idea to update these examples to use the correct API [replacement