[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18608: Cherry-pick #18310 #18355
ChaiBapchya commented on pull request #18608: URL: https://github.com/apache/incubator-mxnet/pull/18608#issuecomment-660611884 @MoisesHer sorry about hitting that flaky test. Please retrigger unix-cpu pipeline. Hopefully that should be the last retrigger for this PR. > We might consider to include this patch in 1.7.0 release if there's rc2, otherwise, this patch will be in v1.7.x branch and the binary release @ciyongch sounds good to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18608: Cherry-pick #18310 #18355
ChaiBapchya commented on pull request #18608: URL: https://github.com/apache/incubator-mxnet/pull/18608#issuecomment-660573558 @sandeep-krishnamurthy @leezu @ciyongch This one fixes MKLDNN missing headers. Please help review/merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18608: Cherry-pick #18310 #18355
ChaiBapchya commented on pull request #18608: URL: https://github.com/apache/incubator-mxnet/pull/18608#issuecomment-660554703 @MoisesHer no point in retriggering edge pipeline. It's not a flaky issue. I saw the same issue in my cherrypick PR: https://github.com/apache/incubator-mxnet/pull/18742 Please update the cmakevar: @leezu https://github.com/apache/incubator-mxnet/pull/18713 That should resolve the edge issue. I cherry-picked it in 1.x You should do that for 1.7.x Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18608: Cherry-pick #18310 #18355
ChaiBapchya commented on pull request #18608: URL: https://github.com/apache/incubator-mxnet/pull/18608#issuecomment-659591292 @leezu @TaoLv @ciyongch gentle ping.. for help.. unix-gpu: Any idea why specifically python3 GPU tests are failing while trying to add mkl headers? edge: Jetson build failure: `libmxnet.a(random_generator.cu.o): error adding symbols: File in wrong format` I haven't seen this before.. maybe you guys have some idea? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18608: Cherry-pick #18310 #18355
ChaiBapchya commented on pull request #18608: URL: https://github.com/apache/incubator-mxnet/pull/18608#issuecomment-658875437 Can we rebase this cherry-pick? 1.7.x seems to regularly get commits merged so CI shouldn't be an issue.. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org