[GitHub] [incubator-mxnet] TaoLv commented on issue #15849: [mkldnn-v1.0] Rebase the feature branch to the latest master

2019-08-13 Thread GitBox
TaoLv commented on issue #15849: [mkldnn-v1.0] Rebase the feature branch to the latest master URL: https://github.com/apache/incubator-mxnet/pull/15849#issuecomment-520870857 @pengzhao-intel Please review and approve if possible. Thanks!

[GitHub] [incubator-mxnet] TaoLv commented on issue #15849: [mkldnn-v1.0] Rebase the feature branch to the latest master

2019-08-12 Thread GitBox
TaoLv commented on issue #15849: [mkldnn-v1.0] Rebase the feature branch to the latest master URL: https://github.com/apache/incubator-mxnet/pull/15849#issuecomment-520666233 > Either rebase and merge or merge commit. I'd recommend you to make a copy of the target branch and try out both

[GitHub] [incubator-mxnet] TaoLv commented on issue #15849: [mkldnn-v1.0] Rebase the feature branch to the latest master

2019-08-11 Thread GitBox
TaoLv commented on issue #15849: [mkldnn-v1.0] Rebase the feature branch to the latest master URL: https://github.com/apache/incubator-mxnet/pull/15849#issuecomment-520242245 BTW, which option is preferred when merging this PR to the feature branch, "squash and merge" or "rebase and

[GitHub] [incubator-mxnet] TaoLv commented on issue #15849: [mkldnn-v1.0] Rebase the feature branch to the latest master

2019-08-11 Thread GitBox
TaoLv commented on issue #15849: [mkldnn-v1.0] Rebase the feature branch to the latest master URL: https://github.com/apache/incubator-mxnet/pull/15849#issuecomment-520242089 @marcoabreu, just force pushed to the PR branch. Hope it looks good to you now. :)

[GitHub] [incubator-mxnet] TaoLv commented on issue #15849: [mkldnn-v1.0] Rebase the feature branch to the latest master

2019-08-11 Thread GitBox
TaoLv commented on issue #15849: [mkldnn-v1.0] Rebase the feature branch to the latest master URL: https://github.com/apache/incubator-mxnet/pull/15849#issuecomment-520241377 Thank you @marcoabreu. I didn't know which one is a better practice. But I see the commit ids in the PR are