[GitHub] [incubator-mxnet] TaoLv commented on pull request #18827: Fix gelu to use erf based algorithm

2020-07-31 Thread GitBox 


TaoLv commented on pull request #18827:
URL: https://github.com/apache/incubator-mxnet/pull/18827#issuecomment-667154138


   > is erf based implementation slower?
   
   They should be similar.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-mxnet] TaoLv commented on pull request #18827: Fix gelu to use erf based algorithm

2020-07-30 Thread GitBox 


TaoLv commented on pull request #18827:
URL: https://github.com/apache/incubator-mxnet/pull/18827#issuecomment-666119655


   FYI, @sxjscience @ZheyuYe .



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org