anjishnu commented on issue #17298: [MXNET-1438] Adding SDML loss function
URL: https://github.com/apache/incubator-mxnet/pull/17298#issuecomment-575768941
@haojin2 ok, thanks! sounds good!
This is an automated message
anjishnu commented on issue #17298: [MXNET-1438] Adding SDML loss function
URL: https://github.com/apache/incubator-mxnet/pull/17298#issuecomment-575756538
@haojin2 could you take a look at the latest version - the new unit test
(which looks at loss reduction) is passing
anjishnu commented on issue #17298: [MXNET-1438] Adding SDML loss function
URL: https://github.com/apache/incubator-mxnet/pull/17298#issuecomment-575405571
@haojin2
With the original confirguration I was getting around 1 in 100 or 1 in 200
failures, which is not acceptable for a unit
anjishnu commented on issue #17298: [MXNET-1438] Adding SDML loss function
URL: https://github.com/apache/incubator-mxnet/pull/17298#issuecomment-575347534
@haojin2 Are there any serious concerns with the new unit test?
This
anjishnu commented on issue #17298: [MXNET-1438] Adding SDML loss function
URL: https://github.com/apache/incubator-mxnet/pull/17298#issuecomment-574927315
Verifying that mention of this PR in #17292 is a typo - author meant to
refer to #17208 - we are not breaking horovod
anjishnu commented on issue #17298: [MXNET-1438] Adding SDML loss function
URL: https://github.com/apache/incubator-mxnet/pull/17298#issuecomment-574802286
@haojin2 if I randomized the input data in the original test code the losses
would would have different values during each run (SDML
anjishnu commented on issue #17298: [MXNET-1438] Adding SDML loss function
URL: https://github.com/apache/incubator-mxnet/pull/17298#issuecomment-574458020
It looks a little tricky to port this into the 'fit' and 'score' paradigm
since this is a retrieval specific loss function which uses
anjishnu commented on issue #17298: [MXNET-1438] Adding SDML loss function
URL: https://github.com/apache/incubator-mxnet/pull/17298#issuecomment-574415884
Sure will address the sanity cases -
Can you give an example of a unit test that is appropriately randomized so I
can base it
