[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r323370300 ## File path: docs/install/osx_setup.md ## @@ -77,6 +77,10 @@ Install the dependencies, required for MXNet, with the following commands: ```bash brew update +brew install python3 + brew install cmake + brew install ninja Review comment: The best install instruction is for users to build mxnet out of box. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r323365460 ## File path: docs/install/osx_setup.md ## @@ -89,25 +92,31 @@ Install the dependencies, required for MXNet, with the following commands: # Get pip easy_install pip # For visualization of network graphs - pip install graphviz + pip3 install graphviz # Jupyter notebook - pip install jupyter + pip3 install jupyter ``` ### Build MXNet Shared Library After you have installed the dependencies, pull the MXNet source code from Git and build MXNet to produce an MXNet library called ```libmxnet.so```. You can clone the repository as described in the following code block, or you may try the download links for your desired MXNet version. -The file called ```osx.mk``` has the configuration required for building MXNet on OS X. First copy ```make/osx.mk``` into ```config.mk```, which is used by the ```make``` command: - ```bash -git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet -cd ~/mxnet -cp make/osx.mk ./config.mk -echo "USE_BLAS = openblas" >> ./config.mk -echo "ADD_CFLAGS += -I/usr/local/opt/openblas/include" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/opt/openblas/lib" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/lib/graphviz/" >> ./config.mk -make -j$(sysctl -n hw.ncpu) +git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet +cd ~/mxnet && pushd . +mkdir build && cd build +cmake \ +-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ +-DCMAKE_C_COMPILER_LAUNCHER=ccache \ +-DUSE_MKL_IF_AVAILABLE=OFF \ Review comment: A build process should be as simple as possible. Ideally, after a few times a user can build it without having to find this page and do copy-paste. I've found it difficult to remember all these flags and it's really frustrating to developers to open this page every time when they want to build mxnet from source. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r323364575 ## File path: cmake/cmake_options_osx.yml ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: We should probably follow what pytorch builds: https://github.com/pytorch/pytorch with a proper setup.py The current way of dev_menu.py seems like a hacky solution. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r322032045 ## File path: cmake/cmake_options_osx.yml ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: That's interesting: https://preshing.com/20170511/how-to-build-a-cmake-based-project/ I have successfully configured CMakeList.txt with switching on/off in this project to build. I have found it much simpler and clear. To build mxnet for any platforms/configurations, I only need the following four lines: ``` mkdir -p build cd build cmake .. make ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r322032045 ## File path: cmake/cmake_options_osx.yml ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: That's interesting: https://preshing.com/20170511/how-to-build-a-cmake-based-project/ I have successfully configured CMakeList.txt to switch on/off different flags. I have found it much simpler and clear. To build mxnet for any platforms/configurations, I only need the following four lines: ``` mkdir -p build cd build cmake .. make ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r322032045 ## File path: cmake/cmake_options_osx.yml ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: That's interesting: https://preshing.com/20170511/how-to-build-a-cmake-based-project/ I have successfully configured CMakeList.txt with switching on/off in this project to build. I have found it much simpler and clear. To build mxnet for any platforms/configurations, I only need the following three lines: ``` mkdir -p build cd build cmake .. make ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r322032045 ## File path: cmake/cmake_options_osx.yml ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: That's interesting: https://preshing.com/20170511/how-to-build-a-cmake-based-project/ I have successfully configured CMakeList.txt with switching on/off in this project to build. I have found it much simpler and clear. To build mxnet for any platforms/configurations, I only need the following three lines: ``` mkdir -p build cd build cmake -DCMAKE_BUILD_TYPE=Release .. make ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r322032045 ## File path: cmake/cmake_options_osx.yml ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: That's interesting: https://preshing.com/20170511/how-to-build-a-cmake-based-project/ I have successfully configured CMakeList.txt with switching on/off in this project to build. I have found it much simpler and clear. To build mxnet, I only need the following three lines: ``` mkdir -p build cd build cmake -DCMAKE_BUILD_TYPE=Release .. make ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r322032045 ## File path: cmake/cmake_options_osx.yml ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: That's interesting: https://preshing.com/20170511/how-to-build-a-cmake-based-project/ I have been successfully configure CMakeList.txt in this project to build without relying on your script. I have found it much simpler. To build mxnet, I only need the following three lines: ``` mkdir -p build cd build cmake -DCMAKE_BUILD_TYPE=Release .. make ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r322031823 ## File path: docs/install/osx_setup.md ## @@ -77,6 +77,10 @@ Install the dependencies, required for MXNet, with the following commands: ```bash brew update +brew install python3 + brew install cmake + brew install ninja Review comment: Same thing for ninja. We can just add a paragraph referring users to ninja and ccache without selling these to them in a combo package with mxnet. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r322031777 ## File path: docs/install/osx_setup.md ## @@ -100,14 +104,21 @@ After you have installed the dependencies, pull the MXNet source code from Git a The file called ```osx.mk``` has the configuration required for building MXNet on OS X. First copy ```make/osx.mk``` into ```config.mk```, which is used by the ```make``` command: ```bash -git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet -cd ~/mxnet -cp make/osx.mk ./config.mk -echo "USE_BLAS = openblas" >> ./config.mk -echo "ADD_CFLAGS += -I/usr/local/opt/openblas/include" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/opt/openblas/lib" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/lib/graphviz/" >> ./config.mk -make -j$(sysctl -n hw.ncpu) +git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet +cd ~/mxnet +mkdir build && cd build +cmake \ +-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ Review comment: Agree. ccache is not a must and it's an advanced compiler tool that should be up to users to choose. To @aaronmarkham 's question, yes it does require user to set up `ccache` and it's not seamless installation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r321942658 ## File path: docs/install/osx_setup.md ## @@ -145,12 +155,16 @@ We have installed MXNet core library. Next, we will install MXNet interface pack To install the MXNet Python binding navigate to the root of the MXNet folder then run the following: ```bash -$ cd python -$ pip install -e . +virtualenv -p`which python3` mxnet_py3 +source mxnet_py3/bin/activate +pip install -e python ``` - +First we create a [virtualenv](https://docs.python-guide.org/dev/virtualenvs/#lower-level-virtualenv) to isolate this installation from our global environment. Review comment: This should not be required for installing mxnet. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r321941620 ## File path: cmake/cmake_options_osx.yml ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: Instead of having this file, can we add a CMakeList_osx.txt instead? I think adding another layer of configurations on top of CMakeList.txt adds unnecessary effort to maintain. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r321941620 ## File path: cmake/cmake_options_osx.yml ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: Instead of having this file, can we add a CMakeList_osx.txt instead? I think adding another layer on top of CMakeList.txt adds unnecessary effort to maintain. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r321941819 ## File path: cmake/cmake_options.yml ## @@ -46,7 +46,8 @@ USE_SIGNAL_HANDLER: "ON" # Print stack traces on segfaults. USE_TENSORRT: "OFF" # Enable infeference optimization with TensorRT. USE_ASAN: "OFF" # Enable Clang/GCC ASAN sanitizers. ENABLE_TESTCOVERAGE: "OFF" # Enable compilation with test coverage metric output -CMAKE_BUILD_TYPE: "Debug" +USE_INT64_TENSOR_SIZE: "OFF" # Use int64_t to represent the total number of elements in a tensor +CMAKE_BUILD_TYPE: "Debug" # Debug | Release | RelWithDebInfo | MinSizeRel Review comment: The danger of this default option is that users are not aware they are building a Debug instead of Release. Why not just let users do: ``` cmake -DCMAKE_BUILD_TYPE=Debug ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r321941620 ## File path: cmake/cmake_options_osx.yml ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: Instead of having this file, can we add a CMakeList_osx.txt instead? I think adding another layer on top of CMakeList.txt is unnecessary and difficult to maintain. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r321942026 ## File path: docs/install/osx_setup.md ## @@ -97,17 +101,23 @@ Install the dependencies, required for MXNet, with the following commands: ### Build MXNet Shared Library After you have installed the dependencies, pull the MXNet source code from Git and build MXNet to produce an MXNet library called ```libmxnet.so```. You can clone the repository as described in the following code block, or you may try the [download links](download.md) for your desired MXNet version. -The file called ```osx.mk``` has the configuration required for building MXNet on OS X. First copy ```make/osx.mk``` into ```config.mk```, which is used by the ```make``` command: - ```bash -git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet -cd ~/mxnet -cp make/osx.mk ./config.mk -echo "USE_BLAS = openblas" >> ./config.mk -echo "ADD_CFLAGS += -I/usr/local/opt/openblas/include" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/opt/openblas/lib" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/lib/graphviz/" >> ./config.mk -make -j$(sysctl -n hw.ncpu) +git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet +cd ~/mxnet && pushd . +mkdir -p build && cd build +cmake \ +-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ +-DCMAKE_C_COMPILER_LAUNCHER=ccache \ +-DUSE_MKL_IF_AVAILABLE=OFF \ +-DUSE_MKLDNN=ON \ Review comment: I feel all these flags are unnecessary. We already have a CMakeList.txt and isn't that the place for user to switch on/off these flags? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r321941914 ## File path: docs/install/osx_setup.md ## @@ -97,17 +101,23 @@ Install the dependencies, required for MXNet, with the following commands: ### Build MXNet Shared Library After you have installed the dependencies, pull the MXNet source code from Git and build MXNet to produce an MXNet library called ```libmxnet.so```. You can clone the repository as described in the following code block, or you may try the [download links](download.md) for your desired MXNet version. -The file called ```osx.mk``` has the configuration required for building MXNet on OS X. First copy ```make/osx.mk``` into ```config.mk```, which is used by the ```make``` command: - ```bash -git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet -cd ~/mxnet -cp make/osx.mk ./config.mk -echo "USE_BLAS = openblas" >> ./config.mk -echo "ADD_CFLAGS += -I/usr/local/opt/openblas/include" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/opt/openblas/lib" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/lib/graphviz/" >> ./config.mk -make -j$(sysctl -n hw.ncpu) +git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet +cd ~/mxnet && pushd . +mkdir -p build && cd build +cmake \ +-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ +-DCMAKE_C_COMPILER_LAUNCHER=ccache \ +-DUSE_MKL_IF_AVAILABLE=OFF \ +-DUSE_MKLDNN=ON \ +-DUSE_CUDA=OFF \ +-DUSE_OPENMP=OFF \ +-DUSE_OPENCV=ON \ +-DUSE_SIGNAL_HANDLER=ON \ +-DCMAKE_BUILD_TYPE=Debug \ +-GNinja .. +ninja +popd Review comment: Why need `pushd .` and `popd`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r321941819 ## File path: cmake/cmake_options.yml ## @@ -46,7 +46,8 @@ USE_SIGNAL_HANDLER: "ON" # Print stack traces on segfaults. USE_TENSORRT: "OFF" # Enable infeference optimization with TensorRT. USE_ASAN: "OFF" # Enable Clang/GCC ASAN sanitizers. ENABLE_TESTCOVERAGE: "OFF" # Enable compilation with test coverage metric output -CMAKE_BUILD_TYPE: "Debug" +USE_INT64_TENSOR_SIZE: "OFF" # Use int64_t to represent the total number of elements in a tensor +CMAKE_BUILD_TYPE: "Debug" # Debug | Release | RelWithDebInfo | MinSizeRel Review comment: The danger of this default option is that users are not aware they are building a Debug instead of Release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r321941620 ## File path: cmake/cmake_options_osx.yml ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: Instead of having this file, can we add a CMakeList_osx.txt instead? I think this adding another layer on top of CMakeList.txt is unnecessary. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r321939887 ## File path: docs/install/osx_setup.md ## @@ -77,6 +77,10 @@ Install the dependencies, required for MXNet, with the following commands: ```bash brew update +brew install python3 Review comment: Should this be python instead of python3? Also it seems the community has not reached an agreement on retiring python2 sypport yet. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r319284515 ## File path: docs/install/osx_setup.md ## @@ -91,23 +95,29 @@ Install the dependencies, required for MXNet, with the following commands: # For visualization of network graphs pip install graphviz==0.8.4 Review comment: If we use pip3, we should change to pip3 all over the doc. Also, as I said this will break for people who uses virtualenv, as I always use pip in my virtualenv. It's up to @aaronmarkham 's call. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r283152581 ## File path: docs/install/osx_setup.md ## @@ -100,14 +104,21 @@ After you have installed the dependencies, pull the MXNet source code from Git a The file called ```osx.mk``` has the configuration required for building MXNet on OS X. First copy ```make/osx.mk``` into ```config.mk```, which is used by the ```make``` command: ```bash -git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet -cd ~/mxnet -cp make/osx.mk ./config.mk -echo "USE_BLAS = openblas" >> ./config.mk -echo "ADD_CFLAGS += -I/usr/local/opt/openblas/include" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/opt/openblas/lib" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/lib/graphviz/" >> ./config.mk -make -j$(sysctl -n hw.ncpu) +git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet +cd ~/mxnet +mkdir build && cd build +cmake \ +-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ Review comment: If that's the case, we should make this default rather than letting users specify. I have found this instruction too complicated to use for first time developers. Copy and paste multiple lines does not work well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r283152608 ## File path: docs/install/osx_setup.md ## @@ -89,25 +92,31 @@ Install the dependencies, required for MXNet, with the following commands: # Get pip easy_install pip # For visualization of network graphs - pip install graphviz + pip3 install graphviz # Jupyter notebook - pip install jupyter + pip3 install jupyter ``` ### Build MXNet Shared Library After you have installed the dependencies, pull the MXNet source code from Git and build MXNet to produce an MXNet library called ```libmxnet.so```. You can clone the repository as described in the following code block, or you may try the download links for your desired MXNet version. -The file called ```osx.mk``` has the configuration required for building MXNet on OS X. First copy ```make/osx.mk``` into ```config.mk```, which is used by the ```make``` command: - ```bash -git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet -cd ~/mxnet -cp make/osx.mk ./config.mk -echo "USE_BLAS = openblas" >> ./config.mk -echo "ADD_CFLAGS += -I/usr/local/opt/openblas/include" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/opt/openblas/lib" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/lib/graphviz/" >> ./config.mk -make -j$(sysctl -n hw.ncpu) +git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet +cd ~/mxnet && pushd . +mkdir build && cd build +cmake \ +-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ +-DCMAKE_C_COMPILER_LAUNCHER=ccache \ +-DUSE_MKL_IF_AVAILABLE=OFF \ Review comment: Can we remove unnecessary flags and make this single line? Copy and paste multiple lines is not user-friendly in bash. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r283152608 ## File path: docs/install/osx_setup.md ## @@ -89,25 +92,31 @@ Install the dependencies, required for MXNet, with the following commands: # Get pip easy_install pip # For visualization of network graphs - pip install graphviz + pip3 install graphviz # Jupyter notebook - pip install jupyter + pip3 install jupyter ``` ### Build MXNet Shared Library After you have installed the dependencies, pull the MXNet source code from Git and build MXNet to produce an MXNet library called ```libmxnet.so```. You can clone the repository as described in the following code block, or you may try the download links for your desired MXNet version. -The file called ```osx.mk``` has the configuration required for building MXNet on OS X. First copy ```make/osx.mk``` into ```config.mk```, which is used by the ```make``` command: - ```bash -git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet -cd ~/mxnet -cp make/osx.mk ./config.mk -echo "USE_BLAS = openblas" >> ./config.mk -echo "ADD_CFLAGS += -I/usr/local/opt/openblas/include" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/opt/openblas/lib" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/lib/graphviz/" >> ./config.mk -make -j$(sysctl -n hw.ncpu) +git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet +cd ~/mxnet && pushd . +mkdir build && cd build +cmake \ +-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ +-DCMAKE_C_COMPILER_LAUNCHER=ccache \ +-DUSE_MKL_IF_AVAILABLE=OFF \ Review comment: Can we make this single line. Comparing to the Makefile instruction, this is too complicated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r283152581 ## File path: docs/install/osx_setup.md ## @@ -100,14 +104,21 @@ After you have installed the dependencies, pull the MXNet source code from Git a The file called ```osx.mk``` has the configuration required for building MXNet on OS X. First copy ```make/osx.mk``` into ```config.mk```, which is used by the ```make``` command: ```bash -git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet -cd ~/mxnet -cp make/osx.mk ./config.mk -echo "USE_BLAS = openblas" >> ./config.mk -echo "ADD_CFLAGS += -I/usr/local/opt/openblas/include" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/opt/openblas/lib" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/lib/graphviz/" >> ./config.mk -make -j$(sysctl -n hw.ncpu) +git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet +cd ~/mxnet +mkdir build && cd build +cmake \ +-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ Review comment: If that's the case, we should make this default rather than letting users to specify. I have found this instruction too complicated to use for me. Copy and paste multiple lines does not work well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r283152581 ## File path: docs/install/osx_setup.md ## @@ -100,14 +104,21 @@ After you have installed the dependencies, pull the MXNet source code from Git a The file called ```osx.mk``` has the configuration required for building MXNet on OS X. First copy ```make/osx.mk``` into ```config.mk```, which is used by the ```make``` command: ```bash -git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet -cd ~/mxnet -cp make/osx.mk ./config.mk -echo "USE_BLAS = openblas" >> ./config.mk -echo "ADD_CFLAGS += -I/usr/local/opt/openblas/include" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/opt/openblas/lib" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/lib/graphviz/" >> ./config.mk -make -j$(sysctl -n hw.ncpu) +git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet +cd ~/mxnet +mkdir build && cd build +cmake \ +-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ Review comment: If that's the case, we should make this default rather than letting users specify. I have found this instruction too complicated to use for me. Copy and paste multiple lines does not work well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r283152543 ## File path: docs/install/osx_setup.md ## @@ -77,6 +77,10 @@ Install the dependencies, required for MXNet, with the following commands: ```bash brew update +brew install python3 Review comment: I also prefer just use python in the instructon. Also, if user use virtualenv, this will not work. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r277049499 ## File path: docs/install/osx_setup.md ## @@ -100,14 +104,21 @@ After you have installed the dependencies, pull the MXNet source code from Git a The file called ```osx.mk``` has the configuration required for building MXNet on OS X. First copy ```make/osx.mk``` into ```config.mk```, which is used by the ```make``` command: Review comment: This will be obsolete if we use cmake, right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r277049357 ## File path: docs/install/osx_setup.md ## @@ -100,14 +104,21 @@ After you have installed the dependencies, pull the MXNet source code from Git a The file called ```osx.mk``` has the configuration required for building MXNet on OS X. First copy ```make/osx.mk``` into ```config.mk```, which is used by the ```make``` command: ```bash -git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet -cd ~/mxnet -cp make/osx.mk ./config.mk -echo "USE_BLAS = openblas" >> ./config.mk -echo "ADD_CFLAGS += -I/usr/local/opt/openblas/include" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/opt/openblas/lib" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/lib/graphviz/" >> ./config.mk -make -j$(sysctl -n hw.ncpu) +git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet +cd ~/mxnet +mkdir build && cd build +cmake \ +-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ Review comment: Got error `CMake Error: The source directory "/Users/lnyuan/work/mxnet/build" does not appear to contain CMakeLists.txt. Specify --help for usage, or press the help button on the CMake GUI.` following this instruction. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r277046526 ## File path: docs/install/osx_setup.md ## @@ -146,10 +157,11 @@ We have installed MXNet core library. Next, we will install MXNet interface pack To install the MXNet Python binding navigate to the root of the MXNet folder then run the following: ```bash -$ cd python -$ pip install -e . +virtualenv -p`which python3` py3_venv Review comment: I think it's a general practice for users to install any package not related to mxnet. But this is non blocking to me. @aaronmarkham please advise. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r277045717 ## File path: docs/install/osx_setup.md ## @@ -100,14 +104,21 @@ After you have installed the dependencies, pull the MXNet source code from Git a The file called ```osx.mk``` has the configuration required for building MXNet on OS X. First copy ```make/osx.mk``` into ```config.mk```, which is used by the ```make``` command: ```bash -git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet -cd ~/mxnet -cp make/osx.mk ./config.mk -echo "USE_BLAS = openblas" >> ./config.mk -echo "ADD_CFLAGS += -I/usr/local/opt/openblas/include" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/opt/openblas/lib" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/lib/graphviz/" >> ./config.mk -make -j$(sysctl -n hw.ncpu) +git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet +cd ~/mxnet +mkdir build && cd build +cmake \ +-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ +-DCMAKE_C_COMPILER_LAUNCHER=ccache \ +-DUSE_MKL_IF_AVAILABLE=O \ +-DUSE_CPP_PACKAGE=ON \ Review comment: I think this flag is off by default in config.mk. Can we also disable it here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r273150364 ## File path: docs/install/osx_setup.md ## @@ -100,14 +104,21 @@ After you have installed the dependencies, pull the MXNet source code from Git a The file called ```osx.mk``` has the configuration required for building MXNet on OS X. First copy ```make/osx.mk``` into ```config.mk```, which is used by the ```make``` command: ```bash -git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet -cd ~/mxnet -cp make/osx.mk ./config.mk -echo "USE_BLAS = openblas" >> ./config.mk -echo "ADD_CFLAGS += -I/usr/local/opt/openblas/include" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/opt/openblas/lib" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/lib/graphviz/" >> ./config.mk -make -j$(sysctl -n hw.ncpu) +git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet +cd ~/mxnet +mkdir build && cd build +cmake \ +-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ +-DCMAKE_C_COMPILER_LAUNCHER=ccache \ Review comment: Can we make this options default in the `cmake_options_osx.yml` so users can run the simplest `cmake` to build MXNet just like we are running `make` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r273150364 ## File path: docs/install/osx_setup.md ## @@ -100,14 +104,21 @@ After you have installed the dependencies, pull the MXNet source code from Git a The file called ```osx.mk``` has the configuration required for building MXNet on OS X. First copy ```make/osx.mk``` into ```config.mk```, which is used by the ```make``` command: ```bash -git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet -cd ~/mxnet -cp make/osx.mk ./config.mk -echo "USE_BLAS = openblas" >> ./config.mk -echo "ADD_CFLAGS += -I/usr/local/opt/openblas/include" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/opt/openblas/lib" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/lib/graphviz/" >> ./config.mk -make -j$(sysctl -n hw.ncpu) +git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet +cd ~/mxnet +mkdir build && cd build +cmake \ +-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ +-DCMAKE_C_COMPILER_LAUNCHER=ccache \ Review comment: Can we make these options default in the `cmake_options_osx.yml` so users can run the simplest `cmake` to build MXNet just like we are running `make` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r273149419 ## File path: docs/install/osx_setup.md ## @@ -146,10 +157,11 @@ We have installed MXNet core library. Next, we will install MXNet interface pack To install the MXNet Python binding navigate to the root of the MXNet folder then run the following: ```bash -$ cd python -$ pip install -e . +virtualenv -p`which python3` py3_venv Review comment: Same for virtualenv. Since this is not required by MXNet, we should let users to choose their own tool (such as conda) instead. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r273149528 ## File path: docs/install/osx_setup.md ## @@ -146,10 +157,11 @@ We have installed MXNet core library. Next, we will install MXNet interface pack To install the MXNet Python binding navigate to the root of the MXNet folder then run the following: ```bash -$ cd python -$ pip install -e . +virtualenv -p`which python3` py3_venv +source py3_venv/bin/activate +pip install -e python ``` - +First we create a [virtualenv](https://docs.python-guide.org/dev/virtualenvs/#lower-level-virtualenv) to isolate this installation from our global environment. Review comment: Same for virtualenv. Since this is not required by MXNet, we should let users to choose their own tool (such as conda) instead. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r273149528 ## File path: docs/install/osx_setup.md ## @@ -146,10 +157,11 @@ We have installed MXNet core library. Next, we will install MXNet interface pack To install the MXNet Python binding navigate to the root of the MXNet folder then run the following: ```bash -$ cd python -$ pip install -e . +virtualenv -p`which python3` py3_venv +source py3_venv/bin/activate +pip install -e python ``` - +First we create a [virtualenv](https://docs.python-guide.org/dev/virtualenvs/#lower-level-virtualenv) to isolate this installation from our global environment. Review comment: Same for virtualenv. This has nothing to do with MXNet. We should let users to choose their own tool (such as conda) instead. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r273149419 ## File path: docs/install/osx_setup.md ## @@ -146,10 +157,11 @@ We have installed MXNet core library. Next, we will install MXNet interface pack To install the MXNet Python binding navigate to the root of the MXNet folder then run the following: ```bash -$ cd python -$ pip install -e . +virtualenv -p`which python3` py3_venv Review comment: Same for `virtualenv`. This has nothing to do with MXNet. We should let users to choose their own tool (such as conda) instead. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r273149044 ## File path: docs/install/osx_setup.md ## @@ -100,14 +104,21 @@ After you have installed the dependencies, pull the MXNet source code from Git a The file called ```osx.mk``` has the configuration required for building MXNet on OS X. First copy ```make/osx.mk``` into ```config.mk```, which is used by the ```make``` command: ```bash -git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet -cd ~/mxnet -cp make/osx.mk ./config.mk -echo "USE_BLAS = openblas" >> ./config.mk -echo "ADD_CFLAGS += -I/usr/local/opt/openblas/include" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/opt/openblas/lib" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/lib/graphviz/" >> ./config.mk -make -j$(sysctl -n hw.ncpu) +git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet +cd ~/mxnet +mkdir build && cd build +cmake \ +-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ Review comment: While `ccache` is really tool for speeding up the compilation time, I still feel we should just provide the minimum required steps for users to build mxnet. Can we suggest these performance tools in a separate doc/section? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r273149044 ## File path: docs/install/osx_setup.md ## @@ -100,14 +104,21 @@ After you have installed the dependencies, pull the MXNet source code from Git a The file called ```osx.mk``` has the configuration required for building MXNet on OS X. First copy ```make/osx.mk``` into ```config.mk```, which is used by the ```make``` command: ```bash -git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet -cd ~/mxnet -cp make/osx.mk ./config.mk -echo "USE_BLAS = openblas" >> ./config.mk -echo "ADD_CFLAGS += -I/usr/local/opt/openblas/include" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/opt/openblas/lib" >> ./config.mk -echo "ADD_LDFLAGS += -L/usr/local/lib/graphviz/" >> ./config.mk -make -j$(sysctl -n hw.ncpu) +git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet +cd ~/mxnet +mkdir build && cd build +cmake \ +-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ Review comment: While `ccache` is really good tool for speeding up the compilation time, I still feel we should just provide the minimum required steps for users to build mxnet. Can we suggest these performance tools in a separate doc/section? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
